Results 1 to 2 of 2
  1. #1
    Join Date
    Jan 2006
    Location
    Netherlands
    Posts
    48
    Plugin Contributions
    0

    Default [Done v155b] Fax number on tpl_account_edit_default.php

    small remark:
    even if the setting in admin->customer details-> fax, have been set to false, the faxnumber is still visible on the account_edit page.

    I would suggest changing the code from template_default/ tpl_account_edit_default.php

    from:

    <label class="inputLabel" for="fax"><?php echo ENTRY_FAX_NUMBER; ?></label>
    <?php echo zen_draw_input_field('fax', $account->fields['customers_fax'], 'id="fax" placeholder="' . ENTRY_FAX_NUMBER_TEXT . '"', 'tel'); ?>
    <br class="clearBoth" />

    to:

    <?php
    if (ACCOUNT_FAX_NUMBER == 'true' ) {
    ?>
    <label class="inputLabel" for="fax"><?php echo ENTRY_FAX_NUMBER; ?></label>
    <?php echo zen_draw_input_field('fax', $account->fields['customers_fax'], 'id="fax" placeholder="' . ENTRY_FAX_NUMBER_TEXT . '"', 'tel'); ?>
    <br class="clearBoth" />
    <?php
    }
    ?>

    I wonder if anybody is still using faxes, in my humble opinion it is quite obsolete. Maybe get rid of the fax number alltogether in next versions?

    Greeting
    Ronald

  2. #2
    Join Date
    Jan 2004
    Posts
    66,373
    Blog Entries
    7
    Plugin Contributions
    274

    Default Re: Fax number on tpl_account_edit_default.php

    Good points. Thanks for reporting this.

    https://github.com/zencart/zencart/pull/1311
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

 

 

Similar Threads

  1. [Done v155b] MasterCard 2-series BIN
    By jackie.taferner in forum Bug Reports
    Replies: 10
    Last Post: 9 Apr 2017, 09:34 PM
  2. Replies: 1
    Last Post: 12 Oct 2016, 01:22 AM
  3. v155 [Done v155b] admin css selector language-dependent
    By torvista in forum Bug Reports
    Replies: 1
    Last Post: 12 Oct 2016, 01:19 AM
  4. v155 [Done v155b] AJAX: Session-variable changes not saved
    By lat9 in forum Bug Reports
    Replies: 5
    Last Post: 18 Aug 2016, 12:20 PM
  5. Replies: 3
    Last Post: 15 Jul 2016, 03:40 AM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR