Page 2 of 2 FirstFirst 12
Results 11 to 13 of 13
  1. #11
    Join Date
    Jul 2012
    Posts
    11,632
    Plugin Contributions
    13

    Default Re: Buy one get one free, tax calculation problem

    On the surface that appears to address what is seen, but when charged, is the correct amount "taken"? I'm also not familiar with the plugin, but the above code change appears to only address one output characteristic and wouldn't want you to be surprised to be charged more than displayed.
    ZC Installation/Maintenance Support <- Site
    Contribution for contributions welcome...
    Upgraded to Zen Cart V1.5.3 from V1.5.1 from V1.5.0 from V1.3.9h

  2. #12
    Join Date
    Jan 2004
    Posts
    64,748
    Blog Entries
    6
    Plugin Contributions
    74

    Default Re: Buy one get one free, tax calculation problem

    Tax is usually done by using zen_add_tax() and passing the relevant tax rates, and then passing that result to the currency->format().

    Looks like this particular BOGO module wasn't written with tax in mind?
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  3. #13
    Join Date
    Oct 2016
    Location
    Belgium
    Posts
    8
    Plugin Contributions
    0

    Default Re: Buy one get one free, tax calculation problem

    Dear DrByte,

    It's seem that this module isn't write with tax in mind indeed. But for now it works fine the way I have changed the program code.

    It looks like this:

    function process() {
    global $order, $currencies;
    $order->info['total'] = $order->info['total'] - $_SESSION['cost_minimize_agg']-($_SESSION['cost_minimize_agg']*0.06);

    if($_SESSION['cost_minimize_agg'] > 0){
    $this->output[] = array('title' => $this->title . ':',
    'text' => '-' . $currencies->format($_SESSION['cost_minimize_agg']+($_SESSION['cost_minimize_agg']*0.06), true, $order->info['currency'], $order->info['currency_value']),
    'value' => $_SESSION['cost_minimize_agg']);

 

 
Page 2 of 2 FirstFirst 12

Similar Threads

  1. v151 % off on a whole order at checkout and buy one get one free option
    By webmiss in forum General Questions
    Replies: 3
    Last Post: 18 Sep 2013, 05:43 PM
  2. Buy One get One Free Add on question
    By stxmona in forum All Other Contributions/Addons
    Replies: 1
    Last Post: 10 May 2012, 10:53 PM
  3. Buy One Get One Free Module - Help Please
    By integrity_designs in forum General Questions
    Replies: 2
    Last Post: 20 Jan 2011, 01:29 AM
  4. Is It Possible To Offer Buy One Get One Free On Zen Cart
    By UrbanGod in forum Managing Customers and Orders
    Replies: 6
    Last Post: 5 Sep 2009, 02:27 PM
  5. Big chooser Buy one Get one Free help
    By Andy_GS in forum Setting Up Categories, Products, Attributes
    Replies: 1
    Last Post: 13 Jan 2009, 12:40 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR