Passing variable to function process_button()

[yaseent]

Hey All,

I'm trying to pass a custom variable to the following function that appears in my Payment Gateway module.

The custom variable is created like this inside classes/order.php like this:

    $getordercount = $db->Execute("select date_purchased
                        from " . TABLE_ORDERS . "
                        where customers_id = '" . ((int)$_SESSION['customer_id']) . "'");

   $orderCount = ($getordercount->RecordCount()) + 1;

   $customOID =  'WOOHOO'. sprintf("%05d", ((int)$_SESSION['customer_id'])) . 'R' . sprintf("%03d",$orderCount); 

What I'm using this for is a custom order reference - so basically I use it in place of the Order ID - BUT REMEMBER, I DO NOT REPLACE THE ORDER ID that stays as is and is unaffected.

Now I've managed to pass the $customOID to the process_button() function in the payment module by adding the following in classes/order.php within the function cart() function, like this:

    $this->orderef = array('orderef' => $customOID); 

And then I call it in the payment module's process_button() like this:

$order->orderef['orderef']; 

I don't like this solution, it seems wrong. Though it works, it just feels wrong. Any guidance? Thanks.

[mc12345678]

Looking at other examples of using the process_button functionality, I saw at least two different things. One was to use a hidden (or not hidden) field on the checkout_payment page such that when the payment is submitted the data within the form from the payment page would be carried over to the checkout_confirmation page where the post data could be read and passed further on to your "next" operation. Otherwise could store as a session variable, or if going to keep with the $order like that, then could "append" it as an additional key to any of the applicable internal variables. Further that could be done using an observer class instead of having to modify the core code in order to append this extra variable/array key to the associated internal variable.

All that also doesn't really include a proper evaluation of whether this is the correct use of that function either, just trying to answer the question asked from a small world view. I have my suspicions that there is something else amiss.

[yaseent]

YES!

Thanks..

I originally tried a session variable, but my problem was I was not assigning inside the function cart() function in classes/order.php.

I was assigning it in a higher up function, therefore it was returning a NULL value and throwing an error.

Completely forgot when finally finding the correction function to retry the SESSION VAR approach.

Thanks for jump starting my brain mate!

[mc12345678]

YES!

Thanks..

I originally tried a session variable, but my problem was I was not assigning inside the function cart() function in classes/order.php.

I was assigning it in a higher up function, therefore it was returning a NULL value and throwing an error.

Completely forgot when finally finding the correction function to retry the SESSION VAR approach.

Thanks for jump starting my brain mate!

Be sure that if you use the session variable approach that you handle the session variable properly as well, ie. it gets cleared, reset, reassigned as applicable based on possible flow directions and operations. Then there's the question of whether that data needs to be generated every time an order is created off of the cart, or if it is only at certain times of processing and is the data available at that point to get your "unique" value, etc...