Logs not being written after upgrade to 1.5.5e/f

[mc12345678]

Meant to have been a continuation of this thread (closed while writing): https://www.zen-cart.com/showthread....de-to-1-5-5e-f

Which also relates to: https://www.zen-cart.com/showthread....-configure-php
And
Https://www.zen-cart.com/showthread....igure-settings


Let's throw in there that both configure.php files (includes/local and includes in that order) are loaded before the ZC 1.5.5 includes/defined_paths.php and (for those that might opt to "overdefine" variables in any of those) that once defined, any future define is "ignored".

Thus (and a bit outside this thread), maintaining an includes/configure.php file from a pre-ZC 1.5.5 version on an upgraded system can lead to discrepancies similar to this. To support continued use of an includes/local/configure.php with an intact includes/configure.php file, the local version must contain defines that apply to the local system and are different than what is in the includes/configure.php.

Unfortunately for some that use this process, then ideally when/if the local file becomes the final version, it should be trimmed down to just contain the defines expected for a base install (ie. Removing the defines that are applicably covered by defined_paths.php).

A change is afoot already to address generation of the local/configure.php file to be suitable to replace the existing configure.php; however, it does not yet address the issue raised by the above.

As can be seen and as I recall discussed elsewhere, it raises a number of additional support issues:
- if an automated process is developed to eventually replace the includes/configure.php file with the includes/local/configure.php file, will it be used consistently.
- manually replacing the file may require revision of the file so that the defines added just to support keeping both files in place may "need" to be removed or at least will look odd when viewed from the outside to support the new install.

And perhaps others that I have missed. As usual, I don't consider these to be reasons to stop such development, change has its own issues and can be worked through when known. :)

Anyways, my couple of thoughts/observations on the subject.

[DrByte]

I'm not sure what your intention is with regard to this post.

There should NEVER be any plan to automatically replace the /includes/configure.php with the includes/local/configure.php.

The "local" file should be for local development ONLY.
And when upgrading a production site, zc_install should be used both to upgrade the main configure.php files and also update the database if relevant changes are detected by zc_install.

[DrByte]

Additionally, is the mention of "v155 e/f" intentional because it ONLY applies to "e" and "f"? Or is the version not actually relevant?

[mc12345678]

Additionally, is the mention of "v155 e/f" intentional because it ONLY applies to "e" and "f"? Or is the version not actually relevant?

It was a restatement of the original thread in which it was identified that there was some sort of "remnant" defines to from a previous version included in the includes/configure.php file.