v155f: Setting the shipping module/method when no shipping is available

**lat9** · 12 Feb 2018, 04:49 PM

Originally Posted by mc12345678

... So, are you trying to replicate the functionality, or trying to be sure that appropriate options are displayed/made available?

What I'm trying to do is point out a discrepancy in settings for the in-core 3-page checkout ... as I attempt to keep the 1-page checkout "in line". My belief is that the statement

Code:

if ((!isset($_SESSION['shipping']) || (!isset($_SESSION['shipping']['id']) || $_SESSION['shipping']['id'] == '') && zen_count_shipping_modules() >= 1)) $_SESSION['shipping'] = $shipping_modules->cheapest();

has misplaced parentheses, causing the cheapest to be returned when there are no shipping modules to be set. Perhaps instead:

Code:

if ((!isset($_SESSION['shipping']) || !isset($_SESSION['shipping']['id']) || $_SESSION['shipping']['id'] == '') && zen_count_shipping_modules() >= 1) {
    $_SESSION['shipping'] = $shipping_modules->cheapest();
}

or, using De Morgan's Laws:

Code:

if (!(isset($_SESSION['shipping']) && isset($_SESSION['shipping']['id']) && $_SESSION['shipping']['id'] != '') && zen_count_shipping_modules() >= 1) {
    $_SESSION['shipping'] = $shipping_modules->cheapest();
}

**mc12345678** · 12 Feb 2018, 05:18 PM

Originally Posted by lat9

What I'm trying to do is point out a discrepancy in settings for the in-core 3-page checkout ... as I attempt to keep the 1-page checkout "in line". My belief is that the statement

Code:

if ((!isset($_SESSION['shipping']) || (!isset($_SESSION['shipping']['id']) || $_SESSION['shipping']['id'] == '') && zen_count_shipping_modules() >= 1)) $_SESSION['shipping'] = $shipping_modules->cheapest();

has misplaced parentheses, causing the cheapest to be returned when there are no shipping modules to be set. Perhaps instead:

Code:

if ((!isset($_SESSION['shipping']) || !isset($_SESSION['shipping']['id']) || $_SESSION['shipping']['id'] == '') && zen_count_shipping_modules() >= 1) {
    $_SESSION['shipping'] = $shipping_modules->cheapest();
}

or, using De Morgan's Laws:

Code:

if (!(isset($_SESSION['shipping']) && isset($_SESSION['shipping']['id']) && $_SESSION['shipping']['id'] != '') && zen_count_shipping_modules() >= 1) {
    $_SESSION['shipping'] = $shipping_modules->cheapest();
}

That may be, but based on $shipping->cheapest() returning false instead of null that there still runs a potential issue in that $_SESSION['shipping'] can be set but not have a value of "worth" (ie. Can become an issue if used at the end notifier.) and that with the way checkout_payment has been modified that it doesn't reject landing at the checkout_payment page if $_SESSION['shipping'] is set to false... ie instead of checking if !isset($_SESSION['shipping']) it should instead check if empty($_SESSION['shipping'])...

The cheapest() function remains an issue as written in regards to $_SESSION['shipping'] remaining either unset or an array if the only shipping method(s) defined are those that are omitted from being returned as a cheapest option.

Such that even if the final above if statement were used, then $_SESSION['shipping'] would be set to false if the only available (and enabled) option were the instore pickup module...

**lat9** · 12 Feb 2018, 05:57 PM

Whether the function returns false or null is immaterial ... as the code stands, it will still result in $_SESSION['shipping'] to be set to a non-array value when no shipping is available.

The point is that the clause under-investigation, IMO, should not set an invalid value into $_SESSION['shipping'] if there are no shipping modules available.

**mc12345678** · 12 Feb 2018, 06:22 PM

Originally Posted by lat9

Whether the function returns false or null is immaterial ... as the code stands, it will still result in $_SESSION['shipping'] to be set to a non-array value when no shipping is available.

The point is that the clause under-investigation, IMO, should not set an invalid value into $_SESSION['shipping'] if there are no shipping modules available.

To be clear then, what is the definition of a shipping module not being available that is being used?

In the first paragraph state that it will be a non-array value if one is not-available but then in second paragraph describe an invalid value for the same lack of an available method.

What constitutes a valid value? Earlier in the thread (understandably a memory recall/direction possibly subject to more information) indicated that it should either be not set or set to an array. Being set to a non-array is still set and doesn't meet that condition.

**lat9** · 12 Feb 2018, 07:04 PM

Originally Posted by mc12345678

To be clear then, what is the definition of a shipping module not being available that is being used?

In the first paragraph state that it will be a non-array value if one is not-available but then in second paragraph describe an invalid value for the same lack of an available method.

What constitutes a valid value? Earlier in the thread (understandably a memory recall/direction possibly subject to more information) indicated that it should either be not set or set to an array. Being set to a non-array is still set and doesn't meet that condition.

Shipping modules can be configured to be enabled for specific zones only ... or based on other conditions, so it's quite possible for a customer to begin a checkout that can't be fulfilled.

As I said before, I believe that $_SESSION['shipping'] should either not be set or set to an array value (which could be empty).