Page 143 of 143 FirstFirst ... 4393133141142143
Results 1,421 to 1,430 of 1430
  1. #1421
    Join Date
    Nov 2005
    Location
    los angeles
    Posts
    2,748
    Plugin Contributions
    11

    Default Re: ZCA Bootstrap 4 Template [Support Thread]

    actually you are correct.

    i am running a module that is overriding the bestseller list; and is using an older version of the module.

    the change did happen in v158a, and specifically this commit:

    https://github.com/zencart/zencart/c...980bee4b28f972

    the old code was like this:

    PHP Code:
      $rows 0;
      while (!
    $best_sellers->EOF) {
        
    $rows++;
        
    $bestsellers_list[$rows]['id'] = $best_sellers->fields['products_id'];
    ... 
    the index value being the var $rows, and here, it starts at 1.

    the new code is like this:

    PHP Code:
        $bestsellers_list = [];
        foreach (
    $best_sellers as $bestseller) {
            
    $best_products_id $bestseller['products_id'];
            
    $bestsellers_list[] = [
                
    'id' => $best_products_id,
                
    'name'  => $bestseller['products_name'],
    ... 
    with no explicit setting of the index, it will definitely start at 0.

    good catch.

    as to what is the most eloquent way to address this error, i can not say.

    but the commit i referenced above is definitely where this bug got introduced.
    author of square Webpay.
    mxWorks now has Apple Pay and Google Pay. donations: venmo or paypal accepted.
    premium consistent excellent support. available for hire.

  2. #1422
    Join Date
    Nov 2006
    Posts
    113
    Plugin Contributions
    0

    Default Re: ZCA Bootstrap 4 Template [Support Thread]

    Thank for confirming, carlwhat.

  3. #1423
    Join Date
    Jun 2012
    Location
    California
    Posts
    207
    Plugin Contributions
    0

    Default Re: ZCA Bootstrap 4 Template [Support Thread]

    ZC 2.0.1
    PHP 8.3
    Bootstrap 3.7.3

    So, I setup a new site and got everything working but for some reason I cannot get it to use the override template files
    ZCs Doc page description is fairly stupid proof but it does not work on my site.
    **********
    Edit includes/languages/english/YOURTEMPLATE/lang.index.php. (Copy includes/languages/english/lang.index.php to includes/languages/english/YOURTEMPLATE/lang.index.php if the override file doesn’t already exist.)
    **********
    I have done the exact method as described above but for changing the "YOURTEMPLATE" to my own template name "wsworx"
    I also did the same thing for the main page logo and it doesn't work either.
    The system will not use my override file.
    I have the bootstrap template selected in the system
    If I inspect the logo element on the main page it shows it using the image from the "template_default" template
    I cleared the cache in my browser

    Any assistance would be greatly appreciated

  4. #1424
    Join Date
    Jun 2012
    Location
    California
    Posts
    207
    Plugin Contributions
    0

    Default Re: ZCA Bootstrap 4 Template [Support Thread]

    I setup the new store in a subfolder as a demo for testing before taking it live
    I just realized when I inspect the logo on the main page it is actually being pulled from the default_template of my live site.
    I don't understand that as I have the includes/configure.php setup to use the demo site as the catalog

  5. #1425
    Join Date
    Jan 2004
    Location
    N of San Antonio TX
    Posts
    9,320
    Plugin Contributions
    11

    Default Re: ZCA Bootstrap 4 Template [Support Thread]

    Quote Originally Posted by wsworx View Post
    I setup the new store in a subfolder as a demo for testing before taking it live
    I just realized when I inspect the logo on the main page it is actually being pulled from the default_template of my live site.
    I don't understand that as I have the includes/configure.php setup to use the demo site as the catalog
    There are two config files. includes/configure.php and YOURADMIN/includes/configure.php

    As to the template being used. If you cloned something to wsworx or created it in some other way, you still need to select it in Tools >> Template Selection

  6. #1426
    Join Date
    Feb 2006
    Location
    Tampa Bay, Florida
    Posts
    10,036
    Plugin Contributions
    124

    Default Re: ZCA Bootstrap 4 Template [Support Thread]

    > I just realized when I inspect the logo on the main page it is actually being pulled from the default_template of my live site.

    You might have an absolute path reference hardcoded somewhere (perhaps in your template).

    Check includes/templates/bootstrap/templates/tpl_header.php in your demo site to see if you changed it to hardcode the logo path?
    That Software Guy. My Store: Zen Cart Support
    Available for hire - See my ad in Services
    Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
    Do you benefit from Zen Cart? Then please support the project.

  7. #1427
    Join Date
    Sep 2009
    Location
    Stuart, FL
    Posts
    12,924
    Plugin Contributions
    89

    Default Re: ZCA Bootstrap 4 Template [Support Thread]

    Quote Originally Posted by carlwhat View Post
    actually you are correct.

    i am running a module that is overriding the bestseller list; and is using an older version of the module.

    the change did happen in v158a, and specifically this commit:

    https://github.com/zencart/zencart/c...980bee4b28f972

    the old code was like this:

    PHP Code:
      $rows 0;
      while (!
    $best_sellers->EOF) {
        
    $rows++;
        
    $bestsellers_list[$rows]['id'] = $best_sellers->fields['products_id'];
    ... 
    the index value being the var $rows, and here, it starts at 1.

    the new code is like this:

    PHP Code:
        $bestsellers_list = [];
        foreach (
    $best_sellers as $bestseller) {
            
    $best_products_id $bestseller['products_id'];
            
    $bestsellers_list[] = [
                
    'id' => $best_products_id,
                
    'name'  => $bestseller['products_name'],
    ... 
    with no explicit setting of the index, it will definitely start at 0.

    good catch.

    as to what is the most eloquent way to address this error, i can not say.

    but the commit i referenced above is definitely where this bug got introduced.
    See this Zen Cart PR for the correction: https://github.com/zencart/zencart/pull/6769

  8. #1428
    Join Date
    Jun 2007
    Location
    Bronx, New York, United States
    Posts
    554
    Plugin Contributions
    3

    Default Re: ZCA Bootstrap 4 Template [Support Thread]

    PHP 8.1.2
    ZC 2.0.1
    ZCA Bootstrap 3.7.3

    Right now I'm running parts of the product pages through a screen reader. One of my pages has the following



    Running it through a screen reader, I hear this:

    Code:
    Enhance Commit 1 foundation: Your (image for) High Attack or (image for) Mid Attack attack gets +1 speed and +1 damage.
    What I wanted to know was, without disabling or changing the IMAGE_ALT_PREFIX define (since it is useful in some cases), is there a way that I can modify the zen_image call to not auto insert the "(image for)" so that a screen reader doesn't insert it?

  9. #1429
    Join Date
    Sep 2009
    Location
    Stuart, FL
    Posts
    12,924
    Plugin Contributions
    89

    Default Re: ZCA Bootstrap 4 Template [Support Thread]

    Quote Originally Posted by retched View Post
    PHP 8.1.2
    ZC 2.0.1
    ZCA Bootstrap 3.7.3

    Right now I'm running parts of the product pages through a screen reader. One of my pages has the following



    Running it through a screen reader, I hear this:

    Code:
    Enhance Commit 1 foundation: Your (image for) High Attack or (image for) Mid Attack attack gets +1 speed and +1 damage.
    What I wanted to know was, without disabling or changing the IMAGE_ALT_PREFIX define (since it is useful in some cases), is there a way that I can modify the zen_image call to not auto insert the "(image for)" so that a screen reader doesn't insert it?
    That (image for) text is coming from the base Zen Cart's zen_image function's use of
    PHP Code:
        'IMAGE_ALT_PREFIX' => '(image for)'
    which is set in the default lang.english.php. You could add that definition to your template-override version, simply setting the language-constant's value to an empty string.

  10. #1430
    Join Date
    Sep 2009
    Location
    Stuart, FL
    Posts
    12,924
    Plugin Contributions
    89

    Default Re: ZCA Bootstrap 4 Template [Support Thread]

    v3.7.4 of the ZCA Bootstrap Template is now available for download: https://www.zen-cart.com/downloads.php?do=file&id=2191

    This release contains changes associated with these GitHub issues:

    #268: Correct image resizing on column-based products' listings.
    #438: "Retire" use of banners_on_ssl field, per zc210 usage.
    #439: Update "Matching Heights" jQuery to its most recent version.
    #442: Correct quantity-entry "shrink" on column-based products' listings.
    #444: Add zc210 notifications to html_header.php and tpl_main_page.php.
    #446: "Hide" the ZCA Bootstrap Colors configuration group.
    #447: Correct best-sellers' sidebox display (was missing the last item).
    #448: Add notifications to tpl_account_history_info.php, primarily for Ty Package Tracker.
    #450: Add notification to tpl_footer.php to enable a footer-menu to be included.
    #452: Add a 'soft' setting to enable the inclusion of Font Awesome Brands' icons, e.g. Twitter or Facebook.

 

 

Similar Threads

  1. v155 Clone a Template [Support Thread]
    By lat9 in forum Addon Admin Tools
    Replies: 98
    Last Post: 27 Jun 2024, 12:47 PM
  2. v150 aBagon Template Support Thread
    By VJef in forum Addon Templates
    Replies: 54
    Last Post: 5 Sep 2020, 08:44 PM
  3. v155 ZCA Bootstrap Template 1.0 (BETA)
    By rbarbour in forum Addon Templates
    Replies: 74
    Last Post: 25 Apr 2018, 07:05 PM
  4. TB Sempre Template Support Thread
    By brandonturpin in forum Addon Templates
    Replies: 48
    Last Post: 19 Mar 2015, 06:33 PM
  5. Wallet Template - Support Thread
    By zami in forum Addon Templates
    Replies: 45
    Last Post: 25 Mar 2010, 10:15 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR