1.5.5F language

[mprough]

So in 1.5.5F if you create a zone, details ... select say united states, then the second dropdown there is no "All Zones" value. It only says "Please Select". The behavior for please select seems to be correct and it should instead say all zones.

[mc12345678]

If I may add a little detail to reproduce the described issue. This is occurring not in the zones area, but the zones definition.

I confirm that when selecting the country (at least United States) that the Zone selection changes from All Zones to Please Select... below this option is all of the active Zones set to the country of United States.

Perhaps a balance between the two statements would be:
All Zones or Select Below...

Would like to say Select Specific Below but starts getting too long... trying to think of something for "beginners" unless some additional instruction is to be added to the page to clarify that 1) Don't actually have to select each and every option, 2) that there are other options available besides the default one.

[DrByte]

Agreed: the wording here is vague, but eventually the problem can be figured out.

As for the cause of the problem, I suspect that an over-aggressive cleanup of duplicated language constants has removed the "All" definition, or a different set of language defines is taking precedence, causing the zones-specific one to not show any longer.

Adding even more defines for "combined meaning" is just unnecessary clutter and even more complication for upgraders and language translators. So any "fix" to this should simply implement what's already present, fixing whatever precedence-clash is preventing previous functionality from firing as intended.

[mc12345678]

Looks like in admin/includes/functions/functions_general.php

Around line 155, the code within the function zen_js_zone_list of admin/includes/functions/htmloutput.php should be changed from:

       if ($num_state == '1') $output_string .= '    ' . $form . '.' . $field . '.options[0] = new Option("' . PLEASE_SELECT . '", "");' . "\n";

To:

       if ($num_state == '1') $output_string .= '    ' . $form . '.' . $field . '.options[0] = new Option("' . TYPE_BELOW . '", "");' . "\n";

Reason seems to follow with what DrByte is referring, though haven't looked to see where else that function is used to determine if that change would upset elsewhere.

Right now, there is a define in the language file for geo_zones called PLEASE_SELECT and it is defined as All Zones. But there is also a define in the admin's language file with the same define but different text.

Based on that, what looks like the issue is and perhaps been that way at least since ZC 1.5.1, is in admin/includes/init_includes/init_languages.php file...

// include the language translations
  require(DIR_WS_LANGUAGES . $_SESSION['language'] . '.php');
  $current_page = basename($PHP_SELF);
  if (file_exists(DIR_WS_LANGUAGES . $_SESSION['language'] . '/' . $current_page)) {
    include(DIR_WS_LANGUAGES . $_SESSION['language'] . '/' . $current_page);
  }
  if ($za_dir = @dir(DIR_WS_LANGUAGES . $_SESSION['language'] . '/extra_definitions')) {
    while ($zv_file = $za_dir->read()) {
      if (preg_match('~^[^\._].*\.php$~i', $zv_file) > 0) {
        require(DIR_WS_LANGUAGES . $_SESSION['language'] . '/extra_definitions/' . $zv_file);
      }
    }
    $za_dir->close();
  }

Which could be fixed by loading the language specific file last instead of first such as:

// include the language translations
  $current_page = basename($PHP_SELF);
  if (file_exists(DIR_WS_LANGUAGES . $_SESSION['language'] . '/' . $current_page)) {
    include(DIR_WS_LANGUAGES . $_SESSION['language'] . '/' . $current_page);
  }
  if ($za_dir = @dir(DIR_WS_LANGUAGES . $_SESSION['language'] . '/extra_definitions')) {
    while ($zv_file = $za_dir->read()) {
      if (preg_match('~^[^\._].*\.php$~i', $zv_file) > 0) {
        require(DIR_WS_LANGUAGES . $_SESSION['language'] . '/extra_definitions/' . $zv_file);
      }
    }
    $za_dir->close();
  }
  require(DIR_WS_LANGUAGES . $_SESSION['language'] . '.php');