Coupon % not working 1.5.6

[JG64]

[Note: remember to include site URL, ZC version, list of plugins, PHP version, etc ... read the Posting Tips shown above for information to include in your post here. And, remove this comment before actually posting!]
I just upgraded from 1.5.4 to 1.5.6 using softaculous (don't usually upgrade this way) and I've got everything working properly except for some reason every time I enter a coupon code with a % at the end ( I only offer % coupons ) when I save the coupon it changes it to a $ amount. I've been using zencart coupons for 10 years and never had this issue before.
PHP version 7.1
Thanks in advance for any suggestions
JG64
www.mark-a-hydrant.com

[swguy]

Confirmed. This is a bug. Working on it.

[JG64]

swguy,

Thank you for the quick reply!
Any idea on a time frame, or workaround?
The reason for the upgrade was a customer waiting on a coupon code to make a purchase -- and 2019 not being available in 1.5.4. Their preference is to purchase online, if possible.
I am very appreciative for the dedication and hard work of all the smart people who make zen cart possible for the rest of us!
JG64

[swguy]

Change admin/coupon_admin.php line 354 from

$_POST['coupon_amount'] = (float)preg_replace('/[^0-9.%]/', '', $_POST['coupon_amount']);

to

Edit: See later post: #8

[mc12345678]

Change admin/coupon_admin.php line 354 from

$_POST['coupon_amount'] = (float)preg_replace('/[^0-9.%]/', '', $_POST['coupon_amount']);

to

$_POST['coupon_amount'] = (float)preg_replace('/[^0-9.][\^%]/', '', $_POST['coupon_amount']);

I haven't looked at other similar replacement functions in respect to this, but was wondering in light of the multi-country/multi-currency aspect, should the number only be filtered on periods or should it be periods and commas?
(Assuming the remainder of the regex is correct)
/[^0-9,.][\^%]/

[JG64]

swguy,

Thanks, but it didn't fix the problem.

JG64

[swguy]

What PHP version are you using? Ugh this seems not to work in PHP7.2.

[swguy]

OK change the above to

$is_pct = (substr($_POST['coupon_amount'], -1) == '%');
$_POST['coupon_amount'] = (float)preg_replace('/[^0-9.]/', '', $_POST['coupon_amount']);
if ($is_pct) $_POST['coupon_amount'] .= "%";

[JG64]

That did it.
Thank you very much!

[swguy]

Great. This update has been submitted and will be part of 1.5.6a.