Coupon Email constant wrong: TEXT_NO_COUPON_IS_VALID_FOR_SALES

[K1979]

zen-cart-v1.5.6a-01042019\zen-cart-v1.5.6a-01042019\admin\coupon_admin.php

Line 70-79

if ($coupon_result->fields['coupon_is_valid_for_sales']) {
$message .= TEXT_COUPON_IS_VALID_FOR_SALES . "\n\n";
} else {
$message .= TEXT_NO_COUPON_IS_VALID_FOR_SALES . "\n\n";
}
if ($coupon_result->fields['coupon_product_count']) {
$message .= TEXT_COUPON_PRODUCT_COUNT_PER_QUANTY . "\n\n";
} else {
$message .= TEXT_COUPON_PRODUCT_COUNT_PER_ORDER . "\n\n";
}

TEXT_COUPON_IS_VALID_FOR_SALES and TEXT_NO_COUPON_IS_VALID_FOR_SALES should be TEXT_COUPON_IS_VALID_FOR_SALES_EMAIL, and TEXT_NO_COUPON_IS_VALID_FOR_SALES_EMAIL.

TEXT_COUPON_PRODUCT_COUNT_PER_QUANTY isn't defined, might be TEXT_COUPON_PRODUCT_COUNT_PER_PRODUCT.

[swguy]

Any first-timers want to build a PR?

[K1979]

Hi,
I’m a computer graphic designer, just try to learn php and have never used GitHub(PR means Pull request, right?)
Anyway I will try my best.

[swguy]

Fantastic! Thanks for your help.

[swguy]

PR: https://github.com/zencart/zencart/pull/2120