v156a Customers function trouble, and mysql_demo.sql has wrong data

[K1979]

It seems that Admin->Customers functions has some bugs.
I'm a php newbie, so I can't find them...

I checked admin\customers.php, it seems that if I delete the customer who wrote reviews, the page will ask me how to treat the reviews(delete or not) and show the number of reviews.
I tested many times but I never get the choice and information.

admin\customers.php
Line 1366-1367
if (isset($cInfo->number_of_reviews) && ($cInfo->number_of_reviews) > 0)
$contents[] = array('text' => '<br>' . zen_draw_checkbox_field('delete_reviews', 'on', true) . ' ' . sprintf(TEXT_DELETE_REVIEWS, $cInfo->number_of_reviews));


I also checked the database during this test, and it seems that the demo data is not correct.

zen-cart-v1.5.6a-01042019\zc_install\sql\demo\mysql_demo.sql

Line 1504
INSERT INTO reviews (reviews_id, products_id, customers_id, customers_name, reviews_rating, date_added, last_modified, reviews_read, status) VALUES (1, 19, 0, 'Bill Smith', 5, '2003-12-23 03:18:19', '0001-01-01 00:00:00', 11, 1);

should be

INSERT INTO reviews (reviews_id, products_id, customers_id, customers_name, reviews_rating, date_added, last_modified, reviews_read, status) VALUES (1, 19, 1, 'Bill Smith', 5, '2003-12-23 03:18:19', '0001-01-01 00:00:00', 11, 1);

[Design75]

You are right, something is missing.

the reviews are missing form the $cInfo array, in the delete switch.

The install sql should indeed be updatet to contain the corrcct customer_id

I'll make a fix on github and let you know.

[Design75]

for fix see: https://github.com/zencart/zencart/pull/2124

[torvista]

Related:
https://www.zen-cart.com/showthread....iews-correctly

I decided that deleting a customer (and maybe leaving a gap in the database for related things to not point to anymore), was not a good idea.
So I modified my shop to only replace the identifiable details of the customer and their orders with a "deleted..." note, and not delete the customer/order records, and also leave the reviews intact since they only have a forename shown with them.