Log files being created every couple of minutes

[Congerman]

HELP Please

My customers site is producing many many log files, we deleted 1.3 million of them this morning that were taking up 17GB of space.

The content is [16-Feb-2019 13:46:22 Europe/London] PHP Fatal error: Call to a member function RecordCount() on a non-object in /home/*******/public_html/***/includes/templates/bana/blocks/banner/view.php on line 4

that file is

<div class="block banner">
<?php
$banner = zen_banner_exists('dynamic', $data['banner-group']);
if ($banner->RecordCount() > 0) :
?>
<?= zen_display_banner('dynamic', $data['banner-group']) ?>
<?php else: ?>
<p class="bg-danger">Add a banner to '<?=$data['banner-group']?>' group</p>
<?php endif; ?>
</div>

[lat9]

The function zen_banner_exists returns either (bool)false if the specified banner doesn't exist or an array of banner-related fields pulled from the database.

Try changing your code-block as follows:

<div class="block banner">
<?php
$banner = zen_banner_exists('dynamic', $data['banner-group']);
if ($banner !== false) :
?>
<?= zen_display_banner('dynamic', $data['banner-group']) ?>
<?php else: ?>
<p class="bg-danger">Add a banner to '<?=$data['banner-group']?>' group</p>
<?php endif; ?>
</div>

[Congerman]

Ok ty. will monitor it for a while. If that does fix it I wonder why it suddenly started producing the error logs

[lat9]

Did the site's PHP version change recently?

[Congerman]

not that I am aware of.

Thank you for your code change, No new error logs have been produced in the last 40 mins. I guess the code does not get to the root cause of the error but just stops it from being reported?

doing the math on the number of files, if they were being created every minute then this has been going on for 2 1/2 years.

[lat9]

not that I am aware of.

Thank you for your code change, No new error logs have been produced in the last 40 mins. I guess the code does not get to the root cause of the error but just stops it from being reported?

doing the math on the number of files, if they were being created every minute then this has been going on for 2 1/2 years.

I misspoke in my original response; zen_banner_exists returns either (bool)false if the banner doesn't exist or the return from the SQL query (a query_factory object) otherwise.

My suspicion is that a banner in the store expired, so that (bool)false was being returned, resulting in the PHP warning.

[Congerman]

Thank you. I will need to track down the culprit banner.

[Congerman]

Having looked in admin, banners I am not seeing any dates associated with the banners. How do I find the expired one?

[lat9]

I'm guessing (since I'm not a big banner user) that the Status column shown in Tools->Banner Manager will show a red icon if the banner is disabled, either manually or due to expiration.

[Congerman]

Yup, I thought that but they all green. looked at each banner and none of them have an expiry date. Hey ho, one of life's little mysteries.

Thank you for your help