Page 27 of 29 FirstFirst ... 172526272829 LastLast
Results 261 to 270 of 290
  1. #261
    Join Date
    Aug 2007
    Location
    Gijón, Asturias, Spain
    Posts
    2,463
    Plugin Contributions
    29

    Default Re: Ceon URI Mapping V5.0

    https://github.com/zencart/zencart/issues/4939

    I also did if (!defined

    I have this mod working in production with ZC158, but since I have the UMM version, I can't make my changes public.
    I invested a lot of time keeping this mod alive in the interim between Conors passing and CEON support being reactivated. I'm not doing that again.

    CEON support needs to clarify the support plan for the free mod.
    Steve
    github.com/torvista: Spanish Language Pack, Google reCaptcha, Structured Data, Multiple Copy-Move-Delete, Image Checker, BackupMySQL Admin/Auto, Product Listing Sorter...

  2. #262
    Join Date
    Nov 2005
    Location
    France
    Posts
    549
    Plugin Contributions
    8

    Default Re: Ceon URI Mapping V5.0

    Quote Originally Posted by swguy View Post
    If you would set one up, that would be great, I have some fixes as well and I'm sure others do.

    If CEON Support hasn't been responsive over several months, we'll need to proceed on our own.
    Hi Scott,

    Apologoes this has taken a while to get round to. I've been busy of late as I've recently taken over JSWeb.
    Anyway, here's the GitHub link for CEON URI MAPPING

    https://github.com/JSWebSteve/Ceon-URI-Mapping-V5.1.0

  3. #263
    Join Date
    Aug 2007
    Location
    Gijón, Asturias, Spain
    Posts
    2,463
    Plugin Contributions
    29

    Default Re: Ceon URI Mapping V5.0

    @Strelitzia
    I have forked your repository and pushed my changes for ZC158/php8.2 to my fork.
    Steve
    github.com/torvista: Spanish Language Pack, Google reCaptcha, Structured Data, Multiple Copy-Move-Delete, Image Checker, BackupMySQL Admin/Auto, Product Listing Sorter...

  4. #264
    Join Date
    Feb 2009
    Posts
    79
    Plugin Contributions
    0

    Default Re: Ceon URI Mapping V5.0

    Can I ask, @torvista or anyone here, what you do about EZ pages, if anything? I just ran into ezpage URLs not working in my 1.5.8 upgrade, I traced it to the fact that URIMappingHandler basically sets $_GET['id'] = (int)$associated_db_id, and later sanitize.php checks with a strict ctype_digit test, so an integer value in $_GET['id'] is discarded, and the ez page header.php gets an empty $ezpage_id and panic redirects to the home page.

    This change seems to have come in from lat9 pull #4954 here 4 months ago https://github.com/zencart/zencart/p...9eb3e460775e64

    Your fork doesn't appear to address this issue. I'm guessing you don't use EZ pages :) My Mickey Mouse fix is to hack the URIMappingHandler to set $_GET values to strings instead of integers, i.e.: $_GET['id'] = "$associated_db_id";

  5. #265
    Join Date
    Aug 2007
    Location
    Gijón, Asturias, Spain
    Posts
    2,463
    Plugin Contributions
    29

    Default Re: Ceon URI Mapping V5.0

    I'm guessing you don't use EZ pages

    Correct. Sorry.
    Steve
    github.com/torvista: Spanish Language Pack, Google reCaptcha, Structured Data, Multiple Copy-Move-Delete, Image Checker, BackupMySQL Admin/Auto, Product Listing Sorter...

  6. #266
    Join Date
    Jul 2012
    Posts
    16,488
    Plugin Contributions
    17

    Default Re: Ceon URI Mapping V5.0

    Quote Originally Posted by neekfenwick View Post
    Can I ask, @torvista or anyone here, what you do about EZ pages, if anything? I just ran into ezpage URLs not working in my 1.5.8 upgrade, I traced it to the fact that URIMappingHandler basically sets $_GET['id'] = (int)$associated_db_id, and later sanitize.php checks with a strict ctype_digit test, so an integer value in $_GET['id'] is discarded, and the ez page header.php gets an empty $ezpage_id and panic redirects to the home page.

    This change seems to have come in from lat9 pull #4954 here 4 months ago https://github.com/zencart/zencart/p...9eb3e460775e64

    Your fork doesn't appear to address this issue. I'm guessing you don't use EZ pages :) My Mickey Mouse fix is to hack the URIMappingHandler to set $_GET values to strings instead of integers, i.e.: $_GET['id'] = "$associated_db_id";
    There is also the following known issue with ez pages in the released version of Zen Cart 1.5.8: https://www.zen-cart.com/showthread....72#post1390772

    Why the core code was changed to necessitate the values to be a string in order to validate that the string is made of numbers seems silly to me. Instead of removing the cast to an integer, why not then cast it to a string?
    ZC Installation/Maintenance Support <- Site
    Contribution for contributions welcome...

  7. #267
    Join Date
    Feb 2009
    Posts
    79
    Plugin Contributions
    0

    Default Re: Ceon URI Mapping V5.0

    Quote Originally Posted by strelitzia View Post
    Apologoes this has taken a while to get round to. I've been busy of late as I've recently taken over JSWeb.
    Anyway, here's the GitHub link for CEON URI MAPPING

    https://github.com/JSWebSteve/Ceon-URI-Mapping-V5.1.0
    @strelitzia Hi, are you a Ceon support rep, and is this the official Ceon URI Mapping repo, and can we issue Pull Requests? Or if not there, then where? The repo doesn't seem to be forked from anywhere, but also the files don't have much history so it seems to have been borrowed rather than formally developed. It would be nice to be able to feed useful code fixes back to the addon.

    First, I'd like to see a little discussion as @mc12345678 mentioned, why the init_sanitize code works the way it does. I presume the logic behind using ctype_digit() is that a $_GET parameter _ought_ to have come in via a query parameter, which _ought_ to only be able to be text, so any non-string data _probably_ is a hack, but this seems rather tenuous logic and I don't know of any spec that defines what data type $_GET parameters may be. It is amusing that products_id is not sanitised (it's not in the array of fields to check), so URIMappingHandler can set $_GET['products_id'] = 123 without problems, which is possibly why this 'bug/feature' hasn't been noticed before since it doesn't affect product pages.

  8. #268
    Join Date
    Feb 2006
    Location
    Tampa Bay, Florida
    Posts
    8,973
    Plugin Contributions
    119

    Default Re: Ceon URI Mapping V5.0

    > First, I'd like to see a little discussion as @mc12345678 mentioned, why the init_sanitize code works the way it does.
    Please open an issue on Github.

    https://github.com/zencart/zencart
    That Software Guy. My Store: Zen Cart Modifications
    Available for hire - See my ad in Services
    Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
    Do you benefit from Zen Cart? Then please support the project.

  9. #269
    Join Date
    Jul 2012
    Posts
    16,488
    Plugin Contributions
    17

    Default Re: Ceon URI Mapping V5.0

    Quote Originally Posted by neekfenwick View Post
    It is amusing that products_id is not sanitised (it's not in the array of fields to check), so URIMappingHandler can set $_GET['products_id'] = 123 without problems, which is possibly why this 'bug/feature' hasn't been noticed before since it doesn't affect product pages.
    The parameter products_id is not strictly an integer because many, many years ago, it was determined that the products_id would be used to support carrying the attribute information related to the product.

    Not everyone uses attributes in every store, so yes, it may in part be possible that a store could operate with such integer sanitization. But, the broader use of the field is numerical and whatever character(s) result from hashing the attributes separated by a colon.

    In a way that hashing can be useful to recreate the product, though nearly falls apart when the product has an attribute allowing user provided text.
    ZC Installation/Maintenance Support <- Site
    Contribution for contributions welcome...

  10. #270
    Join Date
    Feb 2009
    Posts
    79
    Plugin Contributions
    0

    Default Re: Ceon URI Mapping V5.0

    Quote Originally Posted by swguy View Post
    Please open an issue on Github.
    Fair point, thanks. https://github.com/zencart/zencart/issues/5366

 

 
Page 27 of 29 FirstFirst ... 172526272829 LastLast

Similar Threads

  1. Ceon URI Mapping v4.x
    By conor in forum All Other Contributions/Addons
    Replies: 2444
    Last Post: 7 Oct 2020, 03:13 AM
  2. v139d Ceon uri mapping, how to generate uri mapping for bulk bulk-imported products?
    By mybiz9999 in forum All Other Contributions/Addons
    Replies: 3
    Last Post: 8 Jan 2013, 06:52 AM
  3. CEON URI Mapping
    By jmkent in forum All Other Contributions/Addons
    Replies: 3
    Last Post: 22 Nov 2012, 04:28 PM
  4. Ceon URI Mapping v4
    By conor in forum All Other Contributions/Addons
    Replies: 110
    Last Post: 14 Aug 2011, 02:51 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR