1.5.6b paypal undefined constant MODULE_PAYMENT_PAYPAL_IPN_DEBUG error

**nuganics** · 23 Jun 2019, 02:24 AM

PHP Version: 7.3.5-1+ubuntu16.04.1+deb.sury.org+1 (Zend: 3.3.5)
Database Engine: MySQL 5.7.26-0ubuntu0.16.04.1
Zen Cart 1.5.6b

[22-Jun-2019 16:16:46 Australia/Melbourne] Request URI: /ipn_main_handler.php, IP address: 173.0.81.1
#1 doPayPalIPNFsockopenPostback() called at [/home/****/public_html/includes/modules/payment/paypal/paypal_functions.php:463]
#2 ipn_postback() called at [/home/****/public_html/ipn_main_handler.php:136]
--> PHP Warning: Use of undefined constant MODULE_PAYMENT_PAYPAL_IPN_DEBUG - assumed 'MODULE_PAYMENT_PAYPAL_IPN_DEBUG' (this will throw an Error in a future version of PHP) in /home/****/public_html/includes/modules/payment/paypal/paypal_functions.php on line 484.

Using Paypal Express

Can't roll back to PHP 5.6 but I guess it is caused by issues in PHP 7.2 - 7.3. I get a heap of these "Use of undefined constant" errors with plugins so would be nice to know process to solve them if possible for a non-programmer?

Cheers
Tim

**mc12345678** · 23 Jun 2019, 03:30 AM

To be clear (concise?) these aren't "errors" yet... they are warnings. There is a difference and it's big. With warnings, the store/software still operates, not ideal, but it does. With errors, it's an all stop.

Then there's a few things that can be done. From the user side, can report the issue like here, but expect to be told that possibly it has already been corrected and given the location of how/where it was fixed or expect to be given some guidance on how it likely is to be fixed in a more permanent version.

Regardless, with so many lines of code and options, it takes the community to continue to improve on the existing code while also still developing new code that doesn't have the same problem(s).

Could keep an eye on the various reporting locations for bugs and fixes. There are likely a number of other little things that will help

**nuganics** · 23 Jun 2019, 04:28 AM

Yes just warnings but trying to keep /logs/ clean so when there is a serious error I don't miss it :)

/public_html/includes/modules/payment/paypal/paypal_functions.php on line 484 is below:

if (MODULE_PAYMENT_PAYPAL_IPN_DEBUG == 'Yes') {

I looked at some other commits to core from mods with similar warning and maybe the below will fix but not sure if correct or backwards compatible with older PHP versions.

if (defined('MODULE_PAYMENT_PAYPAL_IPN_DEBUG') == 'Yes') {

**mc12345678** · 23 Jun 2019, 06:28 PM

Originally Posted by nuganics

Yes just warnings but trying to keep /logs/ clean so when there is a serious error I don't miss it :)

/public_html/includes/modules/payment/paypal/paypal_functions.php on line 484 is below:

if (MODULE_PAYMENT_PAYPAL_IPN_DEBUG == 'Yes') {

I looked at some other commits to core from mods with similar warning and maybe the below will fix but not sure if correct or backwards compatible with older PHP versions.

if (defined('MODULE_PAYMENT_PAYPAL_IPN_DEBUG') == 'Yes') {

Actually in the case of this code, if the PayPal plugin had been properly installed (meaning possibly uninstalled and then reinstalled) and this debug was still being generated, then this code:

Code:

if (MODULE_PAYMENT_PAYPAL_IPN_DEBUG == 'Yes') {

Would become:

Code:

if (defined('MODULE_PAYMENT_PAYPAL_IPN_DEBUG') && MODULE_PAYMENT_PAYPAL_IPN_DEBUG == 'Yes') {

But, seeing as this constant was incorporated earlier than in version 1.5.6, no action has been incorporated to auto-ensure that it is defied. See, previously the expected process was to reinstall payment and shipping methods. By going through the installation process after that constant had been incorporated into the code, then it would be added to the database and not need a check of whether it was defined or not.

Basically this debug log indicates that the associated paypal method has not been installed to ensure that all database records are up-to-date. It was previously installed and upgrades were performed, but the database never received this record. So make note of your settings, remove the paypal module which is: Paypal Payments Standard from the looks of it.

**swguy** · 23 Jun 2019, 10:34 PM

The problem is that the functions file is common code, but the define is only created by PayPal (not EC). So the change @MC suggested is appropriate, and has been submitted for Zen Cart 1.5.7. You can make it locally now to suppress this log.