[Done 156c] Coupon "not valid for products on sales" issue

[stellarweb]

Version 1.5.6B

If you go to https://americanchainmail.com and enter a coupon code of: Gencon2019 You will see :

Certain other restrictions may apply. Please see below for other details.
TEXT_NO_PROD_SALES

This happens when you set the coupon in admin and click for it to not be valid for items that are already on sale.

It also happens if I flip to the classic template as well

[mc12345678]

Looks like missing the definition in:
includes/languages/english/discount_coupon.php as the constant is defined in includes/languages/english/popup_coupon_help.php

[stellarweb]

define('TEXT_NO_PROD_SALES', '<p>This coupon is not valid for products on sale.</p>');

That is included in the file already

Looks like missing the definition in:
includes/languages/english/discount_coupon.php as the constant is defined in includes/languages/english/popup_coupon_help.php

[mc12345678]

define('TEXT_NO_PROD_SALES', '<p>This coupon is not valid for products on sale.</p>');

That is included in the file already

Which file(s)?

[stellarweb]

I just looked in includes/languages/english/popup_coupon_help.php

Which file(s)?

[mc12345678]

I just looked in includes/languages/english/popup_coupon_help.php

Good, so looks like we are in agreement that the definition exists in the popup_coupon_help file. The problem is that the same constant is used in the discount_coupon page but there is no definition in the discount_coupon language file and therefore you will see the constant as a raw piece of text. To alleviate that problem a definition is needed in includes/languages/english/discount_coupon.php.

I don't know if the words used in the popup help work with the discount_coupon page or if they should be modified slightly, but the fact is the constant is not defined where it is used.

Looks like missing the definition in:
includes/languages/english/discount_coupon.php as the constant is defined in includes/languages/english/popup_coupon_help.php

[stellarweb]

Do you have any solutions?

[lankeeyankee]

Do you have any solutions?

To alleviate that problem a definition is needed in includes/languages/english/discount_coupon.php.

this is the solution

define('TEXT_NO_PROD_SALES', '<p>This coupon is not valid for products on sale.</p>'); 

in includes/languages/english/discount_coupon.php

[DrByte]

This will be included in the v156c update.