Hide empty div in emails

[lat9]

Have you considered using `str_replace()` to remove the extra_info block if it's empty? That's how I would implement this change.

The problem lies in the email template(s) themselves, so I don't see how str_replace could be used.

[swguy]

The templates are read into memory. See functions_email line 551 (in Github latest). You can perform arbitrary manipulations at that point.

[lat9]

The templates are read into memory. See functions_email line 551 (in Github latest). You can perform arbitrary manipulations at that point.

Yes, but there are very few notifiers within those email-generating functions.

[swguy]

I'm suggesting a core change to do this. It's a useful fix, and this is how I'd implement it. But this is just a suggestion -let's see what Simon comes up with before we debug it. :)

[simon1066]

Hope you're not expecting too much!

Using your str_replace idea, and to temporarily avoid the complication of CR/LF I put the code in email_template_direct_email.html on one line like so:

<div class="extra-info">$EXTRA_INFO</div>

in a direct email this gives html code:

<div class="extra-info"></div>

so I thought that in functions_email.php adding line #539 would make sense:

    //strip linebreaks and tabs out of the template
//  $file_holder = str_replace(array("\r\n", "\n", "\r", "\t"), '', $file_holder);
    $file_holder = str_replace(array("\t"), ' ', $file_holder);
$file_holder = str_replace('<div class="extra-info"></div>', '', $file_holder);

no luck nothing is replaced. Although if I just use:

    //strip linebreaks and tabs out of the template
//  $file_holder = str_replace(array("\r\n", "\n", "\r", "\t"), '', $file_holder);
    $file_holder = str_replace(array("\t"), ' ', $file_holder);
	$file_holder = str_replace('<div class="extra-info">', '', $file_holder);

then <div class="extra-info"> IS replaced. So it 'thinks' there is still something inside the div tags? I wondered whether the str_replace should be later in the code.

That's as far as I got.

[simon1066]

$file_holder = str_replace('<div class="extra-info">$EXTRA_INFO</div>', '', $file_holder);

obviously removes that entire line from the template. So maybe there needs to be a condition where it is only removed if $extra_info is empty. Tried

if (empty($extra_info)) {
	$file_holder = str_replace('<div class="extra-info">$EXTRA_INFO</div>', '', $file_holder);
}

no joy.

[lat9]

How about something like

if (empty($block['EXTRA_INFO']) || empty(trim($block['EXTRA_INFO']))) {
    $file_holder = preg_replace('/<div class="extra-info">\s?\$EXTRA_INFO\s?<\/div>', '', $file_holder);
}

That way, if either the 'EXTRA_INFO' block is not present or contains only 'whitespace' characters, the entire 'extra-info' div will be removed from the email template.

[swguy]

+1. Nice.

[simon1066]

How about something like

if (empty($block['EXTRA_INFO']) || empty(trim($block['EXTRA_INFO']))) {
    $file_holder = preg_replace('/<div class="extra-info">\s?\$EXTRA_INFO\s?<\/div>', '', $file_holder);
}

That way, if either the 'EXTRA_INFO' block is not present or contains only 'whitespace' characters, the entire 'extra-info' div will be removed from the email template.

Previously received HTML emails are now in text-only format. Error logs pointed me in the direction of a missing '/' like so:

if (empty($block['EXTRA_INFO']) || empty(trim($block['EXTRA_INFO']))) {
    $file_holder = preg_replace('/<div class="extra-info">\s?\$EXTRA_INFO\s?<\/div>/', '', $file_holder);
}

Your code works as intended. Thanks.

[lat9]

Previously received HTML emails are now in text-only format. Error logs pointed me in the direction of a missing '/' like so:

if (empty($block['EXTRA_INFO']) || empty(trim($block['EXTRA_INFO']))) {
    $file_holder = preg_replace('/<div class="extra-info">\s?\$EXTRA_INFO\s?<\/div>/', '', $file_holder);
}

Your code works as intended. Thanks.

Thanks for the update; those pesky delimiters! FWIW, I use https://rubular.com/ to help me with those regular expressions.