Hide empty div in emails

[simon1066]

v1.5.6b

Applies to email_template_welcome.html but may also apply to others.

The EXTRA_INFO section, used for the admin version of the welcome email is wrapped in a div like so:

<div class="extra-info">
$EXTRA_INFO
</div>

this is obviously empty in the customer's version but due to the way it's styled in email_common.css it shows as an empty, coloured box.

Rather than altering the styling of this div, would suggest adding the following to the .css

.extra-info:empty {
display:none;
}

[swguy]

Good suggestion! Can you open a PR for this?

[simon1066]

Sure, I'll give it a go.

[lat9]

Agreed (and I learned something, as I was unaware of that :empty selector), but will all email programs "understand" that?

[simon1066]

My first PR.

I've created my own fork of the ZC repo and cloned it to my PC (Sourcetree), now trying to make a working-branch.
The instructions say,

SourceTree [using v3.1.3]:

First, make sure you're in "Log View" (View, Log View)
Find where it shows upstream/develop, and right-click on that row. Choose Branch... from the pop-up menu
Give it the new branch name
Leave the "checkout new branch" box checked
Click Create Branch or OK

There's no Log View option, I'm in History View. The only thing that's close to an 'upstream/develop' in my current view is an 'upstream/v157' tag on the most recent branch (15 Jul 2019, Ian Wilson).

Do I just select the 'Branch' icon from the menu ribbon and create my branch in there? If so is the commit 'Working copy parent' or 'specified commit'?

edit - perhaps I should have started a new thread for this.

[simon1066]

Agreed (and I learned something, as I was unaware of that :empty selector), but will all email programs "understand" that?

Good point. Doing some testing and it seems that the type of Client may determine whether or not it's recognised

Yahoo
Thunderbird client - yes

Outlook
Web client - no
Win 10 Mail - yes

Gmail
Web Client - no

Unfortunately my over-judicious use of the Admin email system has caused a temporary IP ban with AOL/Yahoo. I'll do some more thorough checks when I can - but for now it seems that :empty is not the ideal solution.

[simon1066]

Yahoo
Web Client - yes
Thunderbird client - yes

Outlook
Web client - no
Win 10 Mail - yes

Gmail
Web Client - no
Thunderbird client - yes

AOL
Web Client - yes (to be expected as it's Yahoo)

Note: for it to work, sometimes, it requires to have the extra_info code on the same line:

<div class="extra-info">$EXTRA_INFO</div>

[swguy]

The only thing that's close to an 'upstream/develop' in my current view is an 'upstream/v157' tag on the most recent branch (15 Jul 2019, Ian Wilson).

That's what you want. Develop is the 2.0 branch.

[simon1066]

That's what you want. Develop is the 2.0 branch.

Ok, thank you. Although I don't think it's worth doing a PR in this case - as the css change isn't a proper fix, that's good to know for the future.

[swguy]

Have you considered using `str_replace()` to remove the extra_info block if it's empty? That's how I would implement this change.