Results 1 to 2 of 2
  1. #1
    Join Date
    Jan 2004
    Location
    N of San Antonio TX
    Posts
    7,225
    Plugin Contributions
    8

    Default 1.5.6c $column_width backport problem

    Fresh install of 1.5.6c with no products, demo or otherwise. Several mods but none effecting the $column_width variable.

    Both includes/modules/column_left.php and includes/modules/colummn_right.php were changed in 1.5.7 and backported to 1.5.6c in an effort to turn the BOX_WIDTH_LEFT and BOX_WIDTH_RIGHT into integers by adding the prefix (int) to each. The rationale was that ZC needed to do math with these settings.

    Since math has no idea what PX would be, the change was made. However, css validation requires that
    Code:
    Value Error : width only 0 can be a unit. You must put a unit after your number : 150
    The Admin >> Configuration >> Layout Settings suggest that these widths be set to 150px with the note
    px maybe included
    If px is NOT included, the css will not validate. Also, removing the (int) prefix to each of the BOX_WIDTH_## validates the css.

    I have not had the time to get past this point to see where it may be breaking the math but, did need to get this back into consideration. I have removed the (int) from both files on this install and will keep an eye out.

    It seems that the entire treatment of width and height need to be examined. The use of px in the image specification for logo.gif violates html as it USES px where it should not.

    Did you read the posting tips?!?
    Responsive Color Changes for 155-156c demo here.
    Zen Cart PCI Compatible Hosting

  2. #2
    Join Date
    Jul 2012
    Posts
    14,370
    Plugin Contributions
    17

    Default Re: 1.5.6c $column_width backport problem

    It appears that the (int) was added to the constants so that when includes/templates/YOUR_TEMPLATE/sideboxes/tpl_search.php was accessed the subtraction performed there would not require casting the value to an int. The current version of that file in ZC 1.5.7 adds the unit(s) 'px' after the math. Thus any determined unit entered in the admin is ignored and elsewhere that $column_width is used also ignores the use of a unit.

    It seems that an additional variable should be considered that represents the unit(s) as entered in the admin so that they may be used in the template. Regardless it appears that a template would require modification if these three modules include casting the constant to an integer. The generic tpl_search sidebox may have been corrected to not need to cast the value to an integer, but at the "cost" of other template files.

    The three module files affected are: column_left.php, column_right.php and column_single.php

    These affect the left and right template columns as well as the search sidebox in a default install.
    ZC Installation/Maintenance Support <- Site
    Contribution for contributions welcome...
    Upgraded to Zen Cart V1.5.3 from V1.5.1 from V1.5.0 from V1.3.9h

 

 

Similar Threads

  1. UPS xml problem. Anybody else have this problem?
    By FrantzArt in forum Addon Shipping Modules
    Replies: 0
    Last Post: 2 Mar 2012, 11:10 PM
  2. Can I backport the 1.3.9a login to my 1.3.8a site?
    By JohnBoyCR in forum Upgrading from 1.3.x to 1.3.9
    Replies: 6
    Last Post: 19 May 2010, 04:25 AM
  3. Download Link Problem & Gift Card Problem too...
    By Miss Tiina in forum General Questions
    Replies: 2
    Last Post: 14 Mar 2009, 03:58 PM
  4. Customer said had problem creating account-dob problem
    By wtashby in forum General Questions
    Replies: 5
    Last Post: 1 Sep 2008, 11:38 AM
  5. Problem with Navigation In IE below 7.0! Minor Problem, need help!
    By bajanboost in forum Templates, Stylesheets, Page Layout
    Replies: 1
    Last Post: 6 Aug 2007, 04:09 AM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR