Originally Posted by
gprit
How convulated is that???!!! Canada shows as &cID=38 whereas the code suggest 108
I DO see UK as 222 but it doesn't seem to stack up to me....if the code says Canada is 108...(and that is wrong) then why should UK be correct??!!
Well, I haven't looked into the history of the country number designations to know when 108 was correct for Canada and when it became wrong. Looking at what the code does and expects in addition to seeing the end result of that, identifying the correct value as associated to the store's database will provide the associated country to whatever that value is and it matches the value from the cID= parameter. That's also why I suggested a process to identify the value desired instead of using a note/comment.
Unfortunately, such a comment is likely overlooked as it doesn't do anything to site operation, but does confuse those that are trying to follow it.
Having come back around to this (as I think I saw it a few years ago), I plan to propose a PR to correct the code in:
includes/functions/html_output.php
Code:
// Set some default entries at top of list:
if (STORE_COUNTRY != SHOW_CREATE_ACCOUNT_DEFAULT_COUNTRY) $countriesAtTopOfList[] = SHOW_CREATE_ACCOUNT_DEFAULT_COUNTRY;
$countriesAtTopOfList[] = STORE_COUNTRY;
// IF YOU WANT TO ADD MORE DEFAULTS TO THE TOP OF THIS LIST, SIMPLY ENTER THEIR NUMBERS HERE.
// Duplicate more lines as needed
// Example: Canada is 108, so use 108 as shown:
//$countriesAtTopOfList[] = 108;
May add to it a way to determine the country id to provide further assistance if/when that number changes...
Bookmarks