division by zero

[jimmie]

im getting this warning in logs
PHP Warning: Division by zero in /var/www/clients/xxx/xxx/web/includes/templates/xxx/jscript/super_data_head.php on line 281.
line 281

$ratingValue = round($ratingSum / $reviewCount, 1);

[swguy]

if ($reviewCount != 0) {
$ratingValue = round($ratingSum / $reviewCount, 1);
} else {
... do something. maybe $ratingValue = "N/A";
}

[jimmie]

here is a little more of the code

$ratingSum = 0;
    $ratingValue = 0;
    $reviewCount = 0;
    if (isset($reviewArray) && (is_array($reviewArray))){
        $reviewCount = sizeof($reviewArray);
        foreach ($reviewArray as $row) {
            $ratingSum += $row['reviewRating'];
        }
        $ratingValue = round($ratingSum / $reviewCount, 1);
    }
    if ( $reviewCount > 0 ) { //do not bother if no reviews at all. Note note best/worstRating is for the max and min rating used in this review system. Default is 1 and 5 so no need to be declared ?>
  ,
  "aggregateRating": {
    "@type": "AggregateRating",
    "ratingValue": "<?php echo $ratingValue; //average rating based on all reviews ?>",
    "reviewCount": "<?php echo $reviewCount; ?>"
  }

[jimmie]

this did not work
if ($reviewCount != 0) {

[balihr]

Here's a working copy:

if (isset($reviewArray) && (is_array($reviewArray))){
        $reviewCount = sizeof($reviewArray);
        foreach ($reviewArray as $row) {
            $ratingSum += $row['reviewRating'];
        }
        if ($reviewCount > 0) {
            $ratingValue = round($ratingSum / $reviewCount, 1);
        } else {
            // do not bother
        }
    }

[jimmie]

can u be a little bit more precise, i tried but it blanks the screen.
how do i change this

    $ratingSum = 0;
    $ratingValue = 0;
    $reviewCount = 0;
    if (isset($reviewArray) && (is_array($reviewArray))){
        $reviewCount = sizeof($reviewArray);
        foreach ($reviewArray as $row) {
            $ratingSum += $row['reviewRating'];
        }
        $ratingValue = round($ratingSum / $reviewCount, 1);
    }
    if ($reviewCount != 0) { //do not bother if no reviews at all. Note note best/worstRating is for the max and min rating used in this review system. Default is 1 and 5 so no need to be declared ?>
  ,
  "aggregateRating": {
    "@type": "AggregateRating",
    "ratingValue": "<?php echo $ratingValue; //average rating based on all reviews ?>",
    "reviewCount": "<?php echo $reviewCount; ?>"
  },
  "review" : [
  <?php for ($i = 0, $n = sizeof($reviewArray); $i<$n; $i ++) { ?>
  {
    "@type" : "Review",
    "author" : {
      "@type" : "Person",
      "name" : <?php echo json_encode(strtok($reviewArray[$i]['customerName']," ")); //steve to use only the forename, encoded, does NOT need enclosing quotation marks ?>
    },
    "reviewBody" : <?php echo json_encode($reviewArray[$i]['reviewText']); //steve added json_encode to catch quotation marks and pesky accents etc., does NOT need enclosing quotation marks ?>,
    "datePublished" : "<?php echo substr($reviewArray[$i]['dateAdded'], 0, 10); ?>",
    "reviewRating" : {
      "@type" : "Rating",
      "ratingValue" : "<?php echo $reviewArray[$i]['reviewRating']; //steve bug: was fixed at $ratingValue ?>"
      }
    }<?php if ($i+1 != $n) { ?>,<?php } ?>
  <?php } ?>
  ]
<?php } //if no reviews, aggregateRating makes no sense ?>
}
</script>
        <?php } //eof Product Schema
    }//eof Schema enabled ?>

into this

if (isset($reviewArray) && (is_array($reviewArray))){
        $reviewCount = sizeof($reviewArray);
        foreach ($reviewArray as $row) {
            $ratingSum += $row['reviewRating'];
        }
        if ($reviewCount > 0) {
            $ratingValue = round($ratingSum / $reviewCount, 1);
        } else {
            // do not bother
        }
    }

i think cause i took away the closing ?>

[mc12345678]

here is a little more of the code

$ratingSum = 0;
    $ratingValue = 0;
    $reviewCount = 0;
    if (isset($reviewArray) && (is_array($reviewArray))){
        $reviewCount = sizeof($reviewArray);
        foreach ($reviewArray as $row) {
            $ratingSum += $row['reviewRating'];
        }
        $ratingValue = round($ratingSum / $reviewCount, 1);
    }
    if ( $reviewCount > 0 ) { //do not bother if no reviews at all. Note note best/worstRating is for the max and min rating used in this review system. Default is 1 and 5 so no need to be declared ?>
  ,
  "aggregateRating": {
    "@type": "AggregateRating",
    "ratingValue": "<?php echo $ratingValue; //average rating based on all reviews ?>",
    "reviewCount": "<?php echo $reviewCount; ?>"
  }

can u be a little bit more precise, i tried but it blanks the screen.
how do i change this

    $ratingSum = 0;
    $ratingValue = 0;
    $reviewCount = 0;
    if (isset($reviewArray) && (is_array($reviewArray))){
        $reviewCount = sizeof($reviewArray);
        foreach ($reviewArray as $row) {
            $ratingSum += $row['reviewRating'];
        }
        $ratingValue = round($ratingSum / $reviewCount, 1);
    }
    if ($reviewCount != 0) { //do not bother if no reviews at all. Note note best/worstRating is for the max and min rating used in this review system. Default is 1 and 5 so no need to be declared ?>
  ,
  "aggregateRating": {
    "@type": "AggregateRating",
    "ratingValue": "<?php echo $ratingValue; //average rating based on all reviews ?>",
    "reviewCount": "<?php echo $reviewCount; ?>"
  },
  "review" : [
  <?php for ($i = 0, $n = sizeof($reviewArray); $i<$n; $i ++) { ?>
  {
    "@type" : "Review",
    "author" : {
      "@type" : "Person",
      "name" : <?php echo json_encode(strtok($reviewArray[$i]['customerName']," ")); //steve to use only the forename, encoded, does NOT need enclosing quotation marks ?>
    },
    "reviewBody" : <?php echo json_encode($reviewArray[$i]['reviewText']); //steve added json_encode to catch quotation marks and pesky accents etc., does NOT need enclosing quotation marks ?>,
    "datePublished" : "<?php echo substr($reviewArray[$i]['dateAdded'], 0, 10); ?>",
    "reviewRating" : {
      "@type" : "Rating",
      "ratingValue" : "<?php echo $reviewArray[$i]['reviewRating']; //steve bug: was fixed at $ratingValue ?>"
      }
    }<?php if ($i+1 != $n) { ?>,<?php } ?>
  <?php } ?>
  ]
<?php } //if no reviews, aggregateRating makes no sense ?>
}
</script>
        <?php } //eof Product Schema
    }//eof Schema enabled ?>

into this

if (isset($reviewArray) && (is_array($reviewArray))){
        $reviewCount = sizeof($reviewArray);
        foreach ($reviewArray as $row) {
            $ratingSum += $row['reviewRating'];
        }
        if ($reviewCount > 0) {
            $ratingValue = round($ratingSum / $reviewCount, 1);
        } else {
            // do not bother
        }
    }

i think cause i took away the closing ?>

I have/suggest a simpler correction for this issue considering that at least the three variables have an initial assignment that helps with the rest of the processing.

Using the first group of additional code change:

$ratingSum = 0;
    $ratingValue = 0;
    $reviewCount = 0;
    if (isset($reviewArray) && (is_array($reviewArray))){
        $reviewCount = sizeof($reviewArray);
        foreach ($reviewArray as $row) {
            $ratingSum += $row['reviewRating'];
        }
        $ratingValue = round($ratingSum / $reviewCount, 1);
    }
    if ( $reviewCount > 0 ) { //do not bother if no reviews at all. Note note best/worstRating is for the max and min rating used in this review system. Default is 1 and 5 so no need to be declared ?>
  ,
  "aggregateRating": {
    "@type": "AggregateRating",
    "ratingValue": "<?php echo $ratingValue; //average rating based on all reviews ?>",
    "reviewCount": "<?php echo $reviewCount; ?>"
  }

To:

$ratingSum = 0;
    $ratingValue = 0;
    $reviewCount = 0;
    if (!empty($reviewArray) && (is_array($reviewArray))){
        $reviewCount = sizeof($reviewArray);
        foreach ($reviewArray as $row) {
            $ratingSum += $row['reviewRating'];
        }
        $ratingValue = round($ratingSum / $reviewCount, 1);
    }
    if ( $reviewCount > 0 ) { //do not bother if no reviews at all. Note note best/worstRating is for the max and min rating used in this review system. Default is 1 and 5 so no need to be declared ?>
  ,
  "aggregateRating": {
    "@type": "AggregateRating",
    "ratingValue": "<?php echo $ratingValue; //average rating based on all reviews ?>",
    "reviewCount": "<?php echo $reviewCount; ?>"
  }

The reason I suggest this is, the test of '!empty' basically says if there is data in the variable (which includes an array that has 1 or more elements). If there are no elements in the array or variable, then the divide by zero line will not be processed and the $reviewCount will be 0 and therefore continue processing as if there was no rating to evaluate. Further, even if there is data assigned to the variable, it is necessary to know if it is an array or as is available/better in more recent php versions to check if the variable is iterable or traversable. Otherwise, you can accomplish the above direction by changing:

$ratingSum = 0;
    $ratingValue = 0;
    $reviewCount = 0;
    if (isset($reviewArray) && (is_array($reviewArray))){
        $reviewCount = sizeof($reviewArray);
        foreach ($reviewArray as $row) {
            $ratingSum += $row['reviewRating'];
        }
        $ratingValue = round($ratingSum / $reviewCount, 1);
    }
    if ( $reviewCount > 0 ) { //do not bother if no reviews at all. Note note best/worstRating is for the max and min rating used in this review system. Default is 1 and 5 so no need to be declared ?>
  ,
  "aggregateRating": {
    "@type": "AggregateRating",
    "ratingValue": "<?php echo $ratingValue; //average rating based on all reviews ?>",
    "reviewCount": "<?php echo $reviewCount; ?>"
  }

to:

$ratingSum = 0;
    $ratingValue = 0;
    $reviewCount = 0;
    if (isset($reviewArray) && (is_array($reviewArray))){
        $reviewCount = sizeof($reviewArray);
        foreach ($reviewArray as $row) {
            $ratingSum += $row['reviewRating'];
        }
        if ($reviewCount > 0) {
        $ratingValue = round($ratingSum / $reviewCount, 1);
        }
    }
    if ( $reviewCount > 0 ) { //do not bother if no reviews at all. Note note best/worstRating is for the max and min rating used in this review system. Default is 1 and 5 so no need to be declared ?>
  ,
  "aggregateRating": {
    "@type": "AggregateRating",
    "ratingValue": "<?php echo $ratingValue; //average rating based on all reviews ?>",
    "reviewCount": "<?php echo $reviewCount; ?>"
  }

Or even better than that to:

$ratingSum = 0;
    $ratingValue = 0;
    $reviewCount = 0;
    if (isset($reviewArray) && (is_array($reviewArray))){
        $reviewCount = sizeof($reviewArray);
        foreach ($reviewArray as $row) {
            $ratingSum += $row['reviewRating'];
        }
    }
    if ( $reviewCount > 0 ) { //do not bother if no reviews at all. Note note best/worstRating is for the max and min rating used in this review system. Default is 1 and 5 so no need to be declared 
        $ratingValue = round($ratingSum / $reviewCount, 1);
?>
  ,
  "aggregateRating": {
    "@type": "AggregateRating",
    "ratingValue": "<?php echo $ratingValue; //average rating based on all reviews ?>",
    "reviewCount": "<?php echo $reviewCount; ?>"
  }

Since the check for $reviewCount is already present...

Looking at the "longer code":

    $ratingSum = 0;
    $ratingValue = 0;
    $reviewCount = 0;
    if (isset($reviewArray) && (is_array($reviewArray))){
        $reviewCount = sizeof($reviewArray);
        foreach ($reviewArray as $row) {
            $ratingSum += $row['reviewRating'];
        }
        $ratingValue = round($ratingSum / $reviewCount, 1);
    }
    if ($reviewCount != 0) { //do not bother if no reviews at all. Note note best/worstRating is for the max and min rating used in this review system. Default is 1 and 5 so no need to be declared ?>
  ,
  "aggregateRating": {
    "@type": "AggregateRating",
    "ratingValue": "<?php echo $ratingValue; //average rating based on all reviews ?>",
    "reviewCount": "<?php echo $reviewCount; ?>"
  },
  "review" : [
  <?php for ($i = 0, $n = sizeof($reviewArray); $i<$n; $i ++) { ?>
  {
    "@type" : "Review",
    "author" : {
      "@type" : "Person",
      "name" : <?php echo json_encode(strtok($reviewArray[$i]['customerName']," ")); //steve to use only the forename, encoded, does NOT need enclosing quotation marks ?>
    },
    "reviewBody" : <?php echo json_encode($reviewArray[$i]['reviewText']); //steve added json_encode to catch quotation marks and pesky accents etc., does NOT need enclosing quotation marks ?>,
    "datePublished" : "<?php echo substr($reviewArray[$i]['dateAdded'], 0, 10); ?>",
    "reviewRating" : {
      "@type" : "Rating",
      "ratingValue" : "<?php echo $reviewArray[$i]['reviewRating']; //steve bug: was fixed at $ratingValue ?>"
      }
    }<?php if ($i+1 != $n) { ?>,<?php } ?>
  <?php } ?>
  ]
<?php } //if no reviews, aggregateRating makes no sense ?>
}
</script>
        <?php } //eof Product Schema
    }//eof Schema enabled ?>

Oye there are some improvements that can be made here:

    $ratingSum = 0;
    $ratingValue = 0;
    $reviewCount = 0;
    if (!empty($reviewArray) && (is_array($reviewArray))){
        $reviewCount = sizeof($reviewArray);
        foreach ($reviewArray as $row) {
            $ratingSum += $row['reviewRating'];
        }
    }
    if ($reviewCount != 0) { //do not bother if no reviews at all. Note note best/worstRating is for the max and min rating used in this review system. Default is 1 and 5 so no need to be declared 
        $ratingValue = round($ratingSum / $reviewCount, 1);
?>
  ,
  "aggregateRating": {
    "@type": "AggregateRating",
    "ratingValue": "<?php echo $ratingValue; //average rating based on all reviews ?>",
    "reviewCount": "<?php echo $reviewCount; ?>"
  },
  "review" : [
  <?php for ($i = 0; $i<$reviewCount; $i ++) { ?>
  {
    "@type" : "Review",
    "author" : {
      "@type" : "Person",
      "name" : <?php echo json_encode(strtok($reviewArray[$i]['customerName']," ")); //steve to use only the forename, encoded, does NOT need enclosing quotation marks ?>
    },
    "reviewBody" : <?php echo json_encode($reviewArray[$i]['reviewText']); //steve added json_encode to catch quotation marks and pesky accents etc., does NOT need enclosing quotation marks ?>,
    "datePublished" : "<?php echo substr($reviewArray[$i]['dateAdded'], 0, 10); ?>",
    "reviewRating" : {
      "@type" : "Rating",
      "ratingValue" : "<?php echo $reviewArray[$i]['reviewRating']; //steve bug: was fixed at $ratingValue ?>"
      }
    }<?php if ($i+1 != $reviewCount) { ?>,<?php } ?>
  <?php } ?>
  ]
<?php } //if no reviews, aggregateRating makes no sense ?>
}
</script>
        <?php } //eof Product Schema
    }//eof Schema enabled ?>

To capture the specific modifications only (because I can't seem to stop seeking improved code):

    $ratingSum = 0;
    $ratingValue = 0;
    $reviewCount = 0;
    if (isset($reviewArray) && (is_array($reviewArray))){
        $reviewCount = sizeof($reviewArray);
        foreach ($reviewArray as $row) {
            $ratingSum += $row['reviewRating'];
        }
        if ($reviewCount > 0) {
        $ratingValue = round($ratingSum / $reviewCount, 1);
        } else {
          // do not bother
        }
    }
    if ($reviewCount != 0) { //do not bother if no reviews at all. Note note best/worstRating is for the max and min rating used in this review system. Default is 1 and 5 so no need to be declared ?>
  ,
  "aggregateRating": {
    "@type": "AggregateRating",
    "ratingValue": "<?php echo $ratingValue; //average rating based on all reviews ?>",
    "reviewCount": "<?php echo $reviewCount; ?>"
  },
  "review" : [
  <?php for ($i = 0, $n = sizeof($reviewArray); $i<$n; $i ++) { ?>
  {
    "@type" : "Review",
    "author" : {
      "@type" : "Person",
      "name" : <?php echo json_encode(strtok($reviewArray[$i]['customerName']," ")); //steve to use only the forename, encoded, does NOT need enclosing quotation marks ?>
    },
    "reviewBody" : <?php echo json_encode($reviewArray[$i]['reviewText']); //steve added json_encode to catch quotation marks and pesky accents etc., does NOT need enclosing quotation marks ?>,
    "datePublished" : "<?php echo substr($reviewArray[$i]['dateAdded'], 0, 10); ?>",
    "reviewRating" : {
      "@type" : "Rating",
      "ratingValue" : "<?php echo $reviewArray[$i]['reviewRating']; //steve bug: was fixed at $ratingValue ?>"
      }
    }<?php if ($i+1 != $n) { ?>,<?php } ?>
  <?php } ?>
  ]
<?php } //if no reviews, aggregateRating makes no sense ?>
}
</script>
        <?php } //eof Product Schema
    }//eof Schema enabled ?>

Some other "routine" changes that have been presented in other code would be to change "sizeof" to "count" and to remove some of the extra parentheses that do not serve a true purpose such as changing: "&& (is_array($reviewArray))" to "&& is_array($reviewArray)".

Had enough yet? :)