Inventory Updater...

[carlwhat]

ok, a new version has been submitted for approval.

thanks to both @jcrennan and @simon1066 for pointing out the problem and the proposed fix.

hope you find the new version more useful. i did incorporate a small change so that one can see all products in sub-categories of a particular category. you can always select the sub-category to see only those products. sub-sub categories require selecting that category, or 1 level above. hopefully once approved, and you play with the changes you will see what i mean.

best.

[carlwhat]

new version is now available here:

https://www.zen-cart.com/downloads.php?do=file&id=2279

makes better use of the ZC category tree structure.

constructive critiques are always welcome.

best.

[dianeg]

thank you for that! i'm glad you find it useful.

as this plugin is a new page, it does not make use of any notifiers. it does make use of the existing ZC infrastructure, so it has the same look and feel.

i was thinking about adding another field for potential updating from this page; perhaps the base price. i was also thinking about adding a search field; so one could search for something, and then update the results. for example, if one had a lot of inventory from a specific manufacturer, you could search for that manufacturer and then update the inventory for those search results.

its a convenient way if one has to update inventory after taking a physical or spot check or perhaps after purchasing new stock without having to dig into each item individually.

I've been waiting for someone to write a module like this. Thankyou.
A field for updating the base price would be very useful.

[carlwhat]

version 1.2.0 has been submitted. i will post when approved and ready for download.

due to popular demand, base price can now be updated!

there is also some additional error checking so that item updated counts are more accurate.

@gernot, i gave some serious thought to changing models as well as product name; i thought about adding a selector so that an admin can select a field that they want to update. but i chose to not implement these things. as someone who has implemented a number of wine sites, i am of the firm opinion that a new vintage is a new product. and that vintage should be stored as a separate field in your database. perhaps vintage is not as crucial for the wines you sell; but i find it hard to go against my beliefs!

i will post when the new version is ready to download. all feedback is appreciated.

best.

[simon1066]

I haven't tried v1.2.0 but one issue I'm having on the previous version is that after adding the Inventory admin page to a user profile other than Superuser, I get

...your security clearance does not allow you to access this resource.

I thought it might be related to the Admin Page Registration, not knowing much about the process I attempted different page key and menu choice but still the same error. Perhaps something in the code.

Edit: ZC v1.56c, plus plenty of mods which I probably should have listed.

[simon1066]

I haven't tried v1.2.0 but one issue I'm having on the previous version is that after adding the Inventory admin page to a user profile other than Superuser, I get

...your security clearance does not allow you to access this resource.

I thought it might be related to the Admin Page Registration, not knowing much about the process I attempted different page key and menu choice but still the same error. Perhaps something in the code.

Edit: ZC v1.56c, plus plenty of mods which I probably should have listed.

Found the answer, https://www.zen-cart.com/showthread....97#post1131197

admin/includes/extra_datafiles/inventory.php

define('FILENAME_INVENTORY', 'inventory.php');

to

define('FILENAME_INVENTORY', 'inventory');

[carlwhat]

Found the answer, https://www.zen-cart.com/showthread....97#post1131197

admin/includes/extra_datafiles/inventory.php

define('FILENAME_INVENTORY', 'inventory.php');

to

define('FILENAME_INVENTORY', 'inventory');

man, what a bloody waste!

the idea that back in 2013, we had this error, and it was supposed to be corrected back then, and the correction does not fix the problem..... wow.

i digress....

your solution does work. the core ZC should have taken care of my error, but alas it does not....

feel free to implement that. i will do another submit shortly. as well as fix the base zen code. i hope.

thanks for pointing this out.

best.

[carlwhat]

@simon1066, version 1.2.1 removes the .php from the filename.

in addition, hopefully the ZC team will merge this PR that actually does fix this issue for other plugin authors like myself that make the same mistake:

https://github.com/zencart/zencart/pull/3653

best.

[carlwhat]

version 1.2.1 now available for download here:

https://www.zen-cart.com/downloads.php?do=file&id=2279

update base price as well as inventory!

also, no modifications necessary to work within admin profile security.

best.

[simon1066]

Inventory Updater v1.2.1
PHP v7.2.10

Upgrading to ZCv1.57, I get these myDEBUG logs notices when viewing the Inventory Updater page - I know the notices are not critical but if I don't address these undefined index notices (and many others unrelated to Inventory Updater, across the site) the number of log files will become unmanageable.

[08-Jul-2020 10:59:08 Europe/London] PHP Notice:  Undefined index: sort in D:\wamp64\www\mydomain.co.uk\myadmin\inventory.php on line 73
[08-Jul-2020 10:59:08 Europe/London] PHP Stack trace:
[08-Jul-2020 10:59:08 Europe/London] PHP   1. {main}() D:\wamp64\www\mydomain.co.uk\myadmin\index.php:0
[08-Jul-2020 10:59:08 Europe/London] PHP   2. require() D:\wamp64\www\mydomain.co.uk\myadmin\index.php:11
[08-Jul-2020 10:59:08 Europe/London] PHP Notice:  Undefined index: sort in D:\wamp64\www\mydomain.co.uk\myadmin\inventory.php on line 285
[08-Jul-2020 10:59:08 Europe/London] PHP Stack trace:
[08-Jul-2020 10:59:08 Europe/London] PHP   1. {main}() D:\wamp64\www\mydomain.co.uk\myadmin\index.php:0
[08-Jul-2020 10:59:08 Europe/London] PHP   2. require() D:\wamp64\www\mydomain.co.uk\myadmin\index.php:11

... followed by a line 285 entry for every product listed.

inventory.php line 71-76

$sort = (isset($_GET['sort']) ? $_GET['sort'] : '0');
	$order_by = " ";
	switch ($_GET['sort']) {
		case (0):
			$order_by = " ORDER BY p.products_sort_order, pd.products_name";
			break;

inventory.php line 284-286

 <a href="<?= zen_href_link(FILENAME_INVENTORY,
        'action=tg_stat' . '&pid=' . $prod_list->fields['products_id'] . $cid_params . '&sort=' . $_GET['sort'] . '&active=' . $_GET['active'],
        'SSL'); ?>">

'PHP Notice: Undefined index:' seems to be a bit of a theme with my upgrade to ZCv1.57 - seems to be mainly caused by old mods and my crude hacking of php files, still trying to get my head around the whys and wherefores.