Results 1 to 3 of 3
  1. #1
    Join Date
    Mar 2007
    Posts
    249
    Plugin Contributions
    6

    Default OT coupon code tax error of excluded products

    in the includes/modules/order_total/ot_coupon.php the tax amount of an excluded product is removed twice from the total price resulting in unexpected amount showing as part of the order total.


    approx line 620 gives:

    Code:
            if ($this->include_tax == 'true') {
             $orderTotal -= $productsTaxAmount;
            }
            if (DISPLAY_PRICE_WITH_TAX == 'true')
            {
              $orderTotal -= $productsTaxAmount;
            }
    resolution appears to be chnging if to include 'or' or simply removing second 'if' statement

  2. #2
    Join Date
    Jan 2004
    Posts
    66,373
    Blog Entries
    7
    Plugin Contributions
    274

    Default Re: OT coupon code tax error of excluded products

    Yes an "or" probably makes sense.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  3. #3
    Join Date
    Feb 2006
    Location
    Tampa Bay, Florida
    Posts
    9,703
    Plugin Contributions
    123

    Default Re: OT coupon code tax error of excluded products

    If anyone would like to build a PR, that would be great.

    https://github.com/zencart/zencart/issues/3612
    That Software Guy. My Store: Zen Cart Modifications
    Available for hire - See my ad in Services
    Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
    Do you benefit from Zen Cart? Then please support the project.

 

 

Similar Threads

  1. v151 Doing a tax-included/excluded override based on customers group
    By rued in forum General Questions
    Replies: 4
    Last Post: 21 Feb 2013, 03:19 AM
  2. coupon code error
    By wowemall in forum Addon Payment Modules
    Replies: 0
    Last Post: 6 Jun 2012, 11:03 AM
  3. discount coupon tax error
    By Soniccc in forum General Questions
    Replies: 0
    Last Post: 21 Oct 2010, 01:52 PM
  4. Coupon error code
    By Henrietta in forum Discounts/Coupons, Gift Certificates, Newsletters, Ads
    Replies: 3
    Last Post: 29 Oct 2009, 12:09 AM
  5. Tax amount excluded from total amount transferred to Paypal
    By Rykmann in forum Built-in Shipping and Payment Modules
    Replies: 15
    Last Post: 1 Dec 2007, 11:29 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR