[Done v157a] Parameter $zf_order_id is not being transferred to after_order_create

[yesaul]

Hello,

Sorry, if my question is stupid - I'm not a pro and supporting my onw web-shop only, but...

Is this code (appeared in V157 in includes/classes/payment.php) really correct:

  function after_order_create($zf_order_id) {
    if (!is_array($this->modules)) return;
    if (!is_object($GLOBALS[$this->selected_module])) return;
    if (!$GLOBALS[$this->selected_module]->enabled) return;
    $function = __FUNCTION__;
    if (!method_exists($GLOBALS[$this->selected_module], $function)) return;
    return $GLOBALS[$this->selected_module]->after_order_create($function);
  }

I've got an issue using this method in one of my own payment modules - it seems the parameter ($zf_order_id) is not being transferred corrctly into the method

(also the same for admin_notification method of the same class, but I do not know, if it is actually in use somewhere)

[mc12345678]

This is slightly incorrect. The last line should use $zf_order_id instead of $function.

Preparing a PR for these two occurrences.

[mc12345678]

This is slightly incorrect. The last line should use $zf_order_id instead of $function.

Preparing a PR for these two occurrences.

PR: https://github.com/zencart/zencart/pull/3769
File changes: https://github.com/zencart/zencart/pull/3769/files

[swguy]

@yesaul - would you please make a note of the symptoms you saw that led you to investigate this? (This will help less experienced people find this post and @mc's fix).

Thanks guys.

[yesaul]

@yesaul - would you please make a note of the symptoms you saw that led you to investigate this? (This will help less experienced people find this post and @mc's fix)

I'm not sure, if my experience in this case can be helpful for somebody, but anyway:

I use my own module for card payments, where after_order_create method is being used to associate the payment transaction with order number assigned by Zen-Cart (in special transaction log table)

After upgrade to v.157 I have started getting log records with no order number

This have been the only problem

There were no PHP warnings, nor errors, etc appeared