FEC error: Parameter must be an array or an object that implements Countable

[vanhorn_s]

I just had a bot from russia go through my website, and spam me with product inquiry emails, but they also set over 3500 errors in the log folder. The most common one was the same as the first post here. Any suggestions to keep this from happening again? It takes forever to empty out the logs folder in filezilla.

[dbltoe]

6500 here.

[mc12345678]

Change line from:

for ($i=0, $n=sizeof($_POST['products_id']); $i<$n; $i++) {

to:

for ($i=0, $n=sizeof($_POST['products_id'] ?? []); $i<$n; $i++) {

I was able to reproduce the "issue" though its relatively obviously not through normal page load...

[mc12345678]

Change line from:

for ($i=0, $n=sizeof($_POST['products_id']); $i<$n; $i++) {

to:

for ($i=0, $n=sizeof($_POST['products_id'] ?? []); $i<$n; $i++) {

I was able to reproduce the "issue" though its relatively obviously not through normal page load...

That is, assuming php 7.x is being used. If for some reason/some how php 5.x is being used then modify the original line changing
$_POST['products_id'] to:
!empty($_POST['products_id']) ? $_POST['products_id'] : array()

FYI, I used !empty instead of isset to more clearly direct to an empty array instead of the literal translation of ?? which is the null coelesce operator that supposedly does a check against isset. The null coelesce operator works more succinctly than this longer logic/assignment.

[vanhorn_s]

Thank you for the fix. My logs folder has been empty for almost 48 hours now.
I banned the ip address that was spamming my site that day, because it looked at almost 2,000 pages in 10 minutes, according to my tracking software.

[swguy]

MC's fix has been added to 1.5.7a. Thanks, @mc12345678!

[mc12345678]

Thank you for the fix. My logs folder has been empty for almost 48 hours now.
I banned the ip address that was spamming my site that day, because it looked at almost 2,000 pages in 10 minutes, according to my tracking software.

MC's fix has been added to 1.5.7a. Thanks, @mc12345678!

Well, something like it anyways.

After I discovered one method of reproducing the problem and the associated solution above, I found a separate way to cause a similar issue (even with the above applied) so came up with a more complete solution that involved minimal modification. There may be ways in the future to do things differently and there may be those here that figure out that different process.

Anyways, the currently approved solution is: https://github.com/zencart/zencart/pull/3976/files

While the original modification seemed to resolve the issue, it also depends on what it is the actor is trying to do as to the need for additional evaluation/action.