Page 2 of 2 FirstFirst 12
Results 11 to 17 of 17
  1. #11
    Join Date
    Apr 2010
    Posts
    243
    Plugin Contributions
    1

    Default Re: shipstation no longer importing orders after upgrade.

    He just got back with me. It's an issue within Zen-cart in the order_date field. Instead of a date, it shows DATE_TIME_FORMAT


    https://p-1mfgye.b3.n0.cdn.getclouda...e98f1b2b27ea47

  2. #12
    Join Date
    Sep 2009
    Location
    Stuart, FL
    Posts
    10,637
    Plugin Contributions
    78

    Default Re: shipstation no longer importing orders after upgrade.

    Well, that's wonderful (not). Apparently the constants DATE_TIME_FORMAT and DATE_FORMAT_SHORT, which used to be present in the main language file (e.g. /includes/languages/english.php) have magically disappeared in zc157.

    Those definitions, for prior ZC versions, were

    Code:
      define('DATE_FORMAT_SHORT', '%m/%d/%Y');  // this is used for strftime()
      define('DATE_TIME_FORMAT', DATE_FORMAT_SHORT . ' %H:%M:%S');
    Update: Zen Cart GitHub issue opened (https://github.com/zencart/zencart/issues/3975)
    Last edited by lat9; 24 Sep 2020 at 07:34 PM.

  3. #13
    Join Date
    Apr 2010
    Posts
    243
    Plugin Contributions
    1

    Default Re: shipstation no longer importing orders after upgrade.

    My workaround was to change line 104 in shipstation_zc.php from this:
    Code:
        return strftime(DATE_TIME_FORMAT, mktime($hour, $minute, $second, $month, $day, $year))
    To this:
    Code:
        return strftime('%m/%d/%Y %H:%M:%S', mktime($hour, $minute, $second, $month, $day, $year));

  4. #14
    Join Date
    Jan 2004
    Posts
    66,350
    Blog Entries
    7
    Plugin Contributions
    271

    Default Re: shipstation no longer importing orders after upgrade.

    Question: for the way shipstation is using this, does it really need to rely on a constant in Zen Cart? ie: is it critical that it know something about Zen Cart in order to do what it's doing in this part of the code? Or does shipstation's processing actually need/expect a certain format (which "coincidentally" matched what Zen Cart had in that constant) and therefore it would be more sensible to hard-code the expected format instead of using any constants in Zen Cart anyway?
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  5. #15
    Join Date
    Sep 2014
    Posts
    60
    Plugin Contributions
    0

    Default Re: shipstation no longer importing orders after upgrade.

    vanhorn_s: could i get clarification here? Exactly what does work? We're having the same issue and trying to solve it. What precisely did you do/ change to get shipstation working?

    Thank you!

  6. #16
    Join Date
    Apr 2010
    Posts
    243
    Plugin Contributions
    1

    Default Re: shipstation no longer importing orders after upgrade.

    When I originally tried post #12, it didn't work, but I accidentally messed it up. If you add those exact 2 lines to the end of the lines that look like that, it will work again.

  7. #17
    Join Date
    Jan 2004
    Posts
    66,350
    Blog Entries
    7
    Plugin Contributions
    271

    Default Re: shipstation no longer importing orders after upgrade.

    DATE_TIME_FORMAT fixes applied to https://www.zen-cart.com/downloads.php?do=file&id=1324
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

 

 
Page 2 of 2 FirstFirst 12

Similar Threads

  1. After upgrade to 1.5.5a admin login no longer possible
    By weif in forum Upgrading to 1.5.x
    Replies: 2
    Last Post: 1 Aug 2016, 04:21 PM
  2. Replies: 0
    Last Post: 30 Sep 2009, 08:18 PM
  3. Importing products from 1.3.0 to 1.3.7 after upgrade?
    By Lisk in forum Upgrading from 1.3.x to 1.3.9
    Replies: 2
    Last Post: 13 Jan 2007, 04:41 AM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR