Attribute file upload bug if too many periods in filename?

[jeking]

In Zen Cart 1.5.7, a file uploaded with an order as an attribute is accessible via the admin. Very nice addition!!

But if the file uploaded contains a period in the file name, it cannot be downloaded. The file exists on the server so is uploaded properly.

To 'fix' this, I edited /ADMIN/includes/functions/general.php line 3847
It was:
return $filenum . "." . $filetype;

it is now:
return $filenum . "." . pathinfo($filename, PATHINFO_EXTENSION);

[mc12345678]

May I suggest perhaps changing line 3846 as below:

  function zen_get_uploaded_file($filename) {3842
    global $db; 
    $parts = explode(". ", $filename, 2);
    $filenum = $parts[0];
    $filename = $parts[1]; 
    $file_parts = explode(".", $filename, 2);
    $filetype = $file_parts[sizeof($file_parts) - 1]; 
    return $filenum . "." . $filetype; 
  }

  function zen_get_uploaded_file($filename) {3842
    global $db; 
    $parts = explode(". ", $filename, 2);
    $filenum = $parts[0];
    $filename = $parts[1]; 
    $file_parts = explode(".", $filename);
    $filetype = $file_parts[sizeof($file_parts) - 1]; 
    return $filenum . "." . $filetype; 
  }

from

$file_parts = explode(".", $filename, 2);

to

$file_parts = explode(".", $filename);

Or if necessary just change the assignment of $filetype using the above suggested code. This would then look like:

  function zen_get_uploaded_file($filename) {3842
    global $db; 
    $parts = explode(". ", $filename, 2);
    $filenum = $parts[0];
    $filename = $parts[1]; 
    //$file_parts = explode(".", $filename);
    $filetype = pathinfo($filename, PATHINFO_EXTENSION); 
    return $filenum . "." . $filetype; 
  }

$fileparts becomes unnecessary when pathinfo is used, though one interesting thing about attempting to use that function is that it seems that the filesystem in some way is accessed because when I try to use that function on a publicly available php site, they say they have disabled the function for security purposes...