Page 1 of 3 123 LastLast
Results 1 to 10 of 25
  1. #1
    Join Date
    Dec 2007
    Location
    Payson, AZ
    Posts
    1,060
    Plugin Contributions
    14

    Default SitemapXML v4 [Support thread]

    uploading shortly a new update for Site Map XML to version 4 for ZC1.5.7 if accepted, should show up on it's own. If you are interested in helping out, got some ideas or just want something to play with, GitHub location.

    I still have some things I want to play with, but for now as is it's working as before on ZC1.5.7 and PHP7.4 with allot easier install. A number of files was changed or deleted, thus I would not suggest this as a easy update, but a new install.
    Dave
    Always forward thinking... MySite..

  2. #2
    Join Date
    Aug 2007
    Location
    Gijón, Asturias, Spain
    Posts
    2,205
    Plugin Contributions
    29

    Default Re: SitemapXML v4 [Support thread]

    Thanks for the effort, duly noted.
    Steve
    github.com/torvista: Spanish Language Pack, Image Checker, Structured Data, BackupMySQL Admin/Auto, Product Listing Sorter, Redsys payment module...

  3. #3
    Join Date
    Dec 2007
    Location
    Payson, AZ
    Posts
    1,060
    Plugin Contributions
    14

    Default Re: SitemapXML v4 [Support thread]

    If you use the EzPage template, it was pointed out that the language wasn't following along. Actually, it had some issues with tables and such so I cleaned it up and push to GitHub. I have no way to test it, so if you do, please let me know it it's working as you would expect it to.. Thanks..
    Dave
    Always forward thinking... MySite..

  4. #4
    Join Date
    Jan 2006
    Posts
    27
    Plugin Contributions
    1

    Default Re: SitemapXML v4 [Support thread]

    Thanks for the work on this plugin. I noticed a few things. First, \includes\templates\template_default\sitemapxml\html_header.php has a missing closing curly bracket. Second, the first parameter passed to the $snifer->field_exists and $sniffer->table_exists in \includes\modules\pages\sitemapxml\sitemapxml_ezpages.php should be without quotes. And third, TABLE_EZPAGES_TEXT is used but TABLE_EZPAGES_CONTENT should be used instead in \includes\modules\pages\sitemapxml\sitemapxml_ezpages.php. With these modifications I was able to generate the three xml files for categories, products and ezpages. Haven't tried the others.

  5. #5
    Join Date
    Dec 2007
    Location
    Payson, AZ
    Posts
    1,060
    Plugin Contributions
    14

    Default Re: SitemapXML v4 [Support thread]

    Quote Originally Posted by vasilt View Post
    Thanks for the work on this plugin. I noticed a few things. First, \includes\templates\template_default\sitemapxml\html_header.php has a missing closing curly bracket. Second, the first parameter passed to the $snifer->field_exists and $sniffer->table_exists in \includes\modules\pages\sitemapxml\sitemapxml_ezpages.php should be without quotes. And third, TABLE_EZPAGES_TEXT is used but TABLE_EZPAGES_CONTENT should be used instead in \includes\modules\pages\sitemapxml\sitemapxml_ezpages.php. With these modifications I was able to generate the three xml files for categories, products and ezpages. Haven't tried the others.
    Looks like header page got cut short... ezpage is in Github not the download yet as pointed out in the post.. still working on some things to add..
    well push up the corrected header file too..
    Dave
    Always forward thinking... MySite..

  6. #6
    Join Date
    Dec 2007
    Location
    Payson, AZ
    Posts
    1,060
    Plugin Contributions
    14

    Default Re: SitemapXML v4 [Support thread]

    pushed to Github fixes for bugs pointed out as well code changes.

    - bug.. Undefined table sent to be sniffed out. plugins that may or may not exist for all users.
    - Change in ezpage, no need to sniff out what exists in ZC1.5.7!

    Still working on some ideas before sending in an update.
    Dave
    Always forward thinking... MySite..

  7. #7
    Join Date
    Jul 2009
    Posts
    4
    Plugin Contributions
    0

    Default Re: SitemapXML v4 [Support thread]

    Dave,

    I was just experimenting with your plug-in (as pulled from github). It wouldn't install through Zen Cart until I changed:

    $this->executeInstallerSql($sql);

    to

    $db->Execute($sql);

    in ScriptedInstaller.php.

    After that, it seemed to work.

    One nitpick ... the "Create Sitemap's" button text should be "Create Sitemaps" in \admin\includes\languages\english\sitemapxml.php.
    Last edited by jadebox; 6 Oct 2020 at 07:41 PM.

  8. #8
    Join Date
    Dec 2007
    Location
    Payson, AZ
    Posts
    1,060
    Plugin Contributions
    14

    Default Re: SitemapXML v4 [Support thread]

    Quote Originally Posted by jadebox View Post
    Dave,

    I was just experimenting with your plug-in (as pulled from github). It wouldn't install through Zen Cart until I changed:

    $this->executeInstallerSql($sql);

    to

    $db->Execute($sql);

    in ScriptedInstaller.php.

    After that, it seemed to work.

    One nitpick ... the "Create Sitemap's" button text should be "Create Sitemaps" in \admin\includes\languages\english\sitemapxml.php.
    $this->executeInstallerSql($sql);
    should work on ZC1.5.7 as is... I use $db->Execute($sql); for debugging but not having any issues with a vanilla install with the default $this->executeInstallerSql($sql); statement.. What's the environment?

    Difference in spell check... but such is why language files are created for..
    Dave
    Always forward thinking... MySite..

  9. #9
    Join Date
    Sep 2009
    Location
    Stuart, FL
    Posts
    10,271
    Plugin Contributions
    78

    Default Re: SitemapXML v4 [Support thread]

    Quote Originally Posted by davewest View Post
    $this->executeInstallerSql($sql);
    should work on ZC1.5.7 as is... I use $db->Execute($sql); for debugging but not having any issues with a vanilla install with the default $this->executeInstallerSql($sql); statement.. What's the environment?

    Difference in spell check... but such is why language files are created for..
    Dave, it's not a difference in spell check. The difference is between possessive (its) and contractions (it's = it is). In this case, it's the difference between plural (Sitemaps) and contractions (Sitemap's = Sitemap is).
    Last edited by lat9; 6 Oct 2020 at 09:05 PM. Reason: Added plural case.

  10. #10
    Join Date
    Dec 2007
    Location
    Payson, AZ
    Posts
    1,060
    Plugin Contributions
    14

    Default Re: SitemapXML v4 [Support thread]

    Quote Originally Posted by lat9 View Post
    Dave, it's not a difference in spell check. The difference is between possessive (its) and contractions (it's = it is). In this case, it's the difference between plural (Sitemaps) and contractions (Sitemap's = Sitemap is).
    LOL.. After 70 some years you think I could figure it out... nop... 3's and E's still can't tell the difference.. I'm told quite often NOP is spelled wrong too...

    pushed an update for the spelling...
    Dave
    Always forward thinking... MySite..

 

 
Page 1 of 3 123 LastLast

Similar Threads

  1. Hebrew Support - latest release [Support Thread]
    By eranariel in forum Addon Language Packs
    Replies: 16
    Last Post: 22 Mar 2021, 01:11 AM
  2. v156 PWA, Offline support Push notifications addon [Support Thread]
    By perfumbg in forum All Other Contributions/Addons
    Replies: 0
    Last Post: 23 May 2019, 02:27 PM
  3. Commentics [Support Thread]
    By Commentics in forum All Other Contributions/Addons
    Replies: 11
    Last Post: 30 Jan 2013, 10:11 PM
  4. PurpleShades Support Thread
    By kobra in forum Addon Templates
    Replies: 122
    Last Post: 18 May 2011, 07:18 PM
  5. ZJ Silver Support Thread
    By anthonyd in forum Addon Templates
    Replies: 220
    Last Post: 5 Nov 2010, 03:30 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR