Duplicate products added to shopping cart

[johnjlarge]

Hi Dr Byte.

I'm troubleshooting a live 1.5.6c store, so I've done what you said with 1.5.6c

Fresh install, fresh database.

Bare minimum adjustments. In admin, I set currency to GBP default & I also edited admin>config>Product Listing> Display Product Add to Cart Button (0=off; 1=on; 2=on with Qty Box per Product) to 1 to show the buy now buttons.

Added two test products and replicted the behaviour I described. If I add using the Buy Now button on the product listing page (category view) it adds to the cart with a straightforward product ID. If I click through to the products page and add it to cart from there, it will add it to my cart but with id:hash - duplicating the products in my basket

See screenshot :-

[DrByte]

Most bizarre.

I can't replicate the problem.

I've tried the currency switch. Makes no difference. (Shouldn't anyway)

I've tried switching among all the settings for "Display Product Add to Cart Button (0=off; 1=on; 2=on with Qty Box per Product)"
and also for "Display Multiple Products Qty Box Status and Set Button Location".
This means I've been able to test each of the following scenarios:
- Buy Now button from product listing
- Add To Cart button from product listing after entering "1" for quantity
- Add To Cart button from product page after entering "1" for quantity
- Multiple-Add-To-Cart-Buttons (top/bottom) from product listing after entering "1" for quantity
- click to product (already in cart) from shopping-cart page and click Add To Cart with "1" in the quantity box, which now adds one more to cart, making it show "2" for quantity and still just a single row in the shopping cart page.

For reference, to create the product I tested with I used the same settings found on the "Sample of Product General Type" product in the demo products.

I also tried testing with the actual demo product suite. Trying all these actions with products having no attributes worked normally. For those with attributes assigned to them I got the id:hash pattern as discussed, as expected.

[johnjlarge]

The products I added where straightforward products. No attributes, I haven't added any attributes to this database in attributes controller. I didn't add in any demo products during install as I wanted to keep the database clear of everything.

Trying to think what specific thing is causing it.

I'm using UTF8 encoding and not the newer UTF8-MB4
I'm running on php 7.2 on litespeed
I've got SQL query cache set to database

They are the only options I specifically chose during install, to match my own legacy store.

Any ideas? I can give you access to the store on my dev server. It isn't technically online, but I can give you the ip and url to add to your hosts file on your computer allowing you to see the test website. I can also give you login credentials as its a completley empty store with non of my customer info or anything in.

[johnjlarge]

I'm not sure what is causing this, but it's definitely one of the changes to /includes/classes/shopping_cart.php

The store I'm running which has the bug is v1.5.6c

If I take the /includes/classes/shopping_cart.php from the previous v1.5.6b and drop it in my 1.5.6c the problem is resolved.

Both /includes/classes/shopping_cart.php from v1.5.6c and 1.5.7 cause this bug, so its a change made between the file dated @version $Id: DrByte 2019 Apr 07 Modified in v1.5.6b and @version $Id: DrByte 2019 Jul 16 Modified in v1.5.6c

This bug is completely random, I have another store (different business) running 1.5.7. Same upgrade path, same server & doesn't exhibit this issue.

[johnjlarge]

I've narrowed it down to a single line of code.

In /includes/classes/shopping_cart.php version from 1.5.6c we have the following line at line number 1962

$real_ids = isset($_POST['id']) ? $_POST['id'] : array();

If I replace this line of code with the equivalent line from version 1.5.6b the shopping cart duplication issue is solved

$real_ids = isset($_POST['id']) ? $_POST['id'] : "";

Not being familiar with all the changes made to this code & seeing as you guys authored it, maybe that will shed some light onto this bug?

[mc12345678]

I've narrowed it down to a single line of code.

In /includes/classes/shopping_cart.php version from 1.5.6c we have the following line at line number 1962

$real_ids = isset($_POST['id']) ? $_POST['id'] : array();

If I replace this line of code with the equivalent line from version 1.5.6b the shopping cart duplication issue is solved

$real_ids = isset($_POST['id']) ? $_POST['id'] : "";

Not being familiar with all the changes made to this code & seeing as you guys authored it, maybe that will shed some light onto this bug?

What do you have for line 564 of includes/functions/functions_general.php and then also separately provide the code that includes 5 lines before to 5 lines after that line number.

[johnjlarge]

Hi.

It's the standard functions_general.php file from the 1.5.6c zip.

Around that line I have the following. Line 564 in bold :-


* @param array|string $params
* @return string
*/
function zen_get_uprid($prid, $params) {
$uprid = $prid;
if ( !is_array($params) || strstr($prid, ':')) return $prid;

foreach($params as $option => $value) {
if (is_array($value)) {
foreach($value as $opt => $val) {
$uprid = $uprid . '{' . $option . '}' . trim($opt);

[lat9]

Are the problematic products, by chance, using radio-button attributes? If so, have you made sure that one of those attribute-values is identified as being the 'default'?

[mc12345678]

Unfortunately, that is the contents of that line for ZC 1.5.6c. At some point after that release, a condition such as this was identified and a change was pushed to apply to the next sub-release and also captured in the next full release. The line has become:

    if ( !is_array($params) || empty($params) || strstr($prid, ':')) return $prid;

[johnjlarge]

Unfortunately, that is the contents of that line for ZC 1.5.6c. At some point after that release, a condition such as this was identified and a change was pushed to apply to the next sub-release and also captured in the next full release. The line has become:

    if ( !is_array($params) || empty($params) || strstr($prid, ':')) return $prid;

Hi mc12345678

I'm troubleshooting a 1.5.6c store. If I change line 564 of functions.php to the code you supplied, will this be the only fix required? is there a list of any other fixes that came up from that release that I should keep in mind?

lat9, I'm only using text input attributes and one page uses a file upload attribute. No radio buttons.