A non-numeric value encountered in shopping_cart.php

[Carbonless]

I don't dispute that it may have created a log on "your" server while I was attempting to figure out what I might need to create to replicate the problem.
My point is that by using the steps I outlined, I could not recreate it on my system, so I'm wondering whether I missed a step in how I set up the product or its attributes?

I have tested with the default template, no changes to template files, and the error is still created... so it's not a template file issue caused by modification.

[davewest]

I have tested with the default template, no changes to template files, and the error is still created... so it's not a template file issue caused by modification.

I was able to recreate it, a walk around would be to replace line 737 with

$freeShippingTotal += (!empty($shipping_attributes_price) ? $shipping_attributes_price : 0) ;

This fixes the warnings without getting to the source of the empty value. Not sure if Not Empty is correct! there maybe a better answer.. or casting it to a float?

Recreated with a free shipping item with a cost, required text attribute without setting a price.
Heavy modified ZC1.5.7b and php7.4

[DrByte]

I was able to recreate it, a walk around would be to replace line 737 with

$freeShippingTotal += (!empty($shipping_attributes_price) ? $shipping_attributes_price : 0) ;

This fixes the warnings without getting to the source of the empty value. Not sure if Not Empty is correct! there maybe a better answer.. or casting it to a float?

Recreated with a free shipping item with a cost, required text attribute without setting a price.
Heavy modified ZC1.5.7b and php7.4

While that bandage will work, I'd also like to figure out where the empty string value is coming from and why, in case the fix should be made "there" instead.

[mc12345678]

While that bandage will work, I'd also like to figure out where the empty string value is coming from and why, in case the fix should be made "there" instead.

PR coming... Looks like the use of an empty string ('') within the function called in the line before is a cause. Further it appears (using a php sandbox with PHP 7.4.16) that similar messages would be made from within the zen_get_discount_calc.

PR is: https://github.com/zencart/zencart/pull/4166

Haven't yet seen where the use of 0 will/may cause either a calculation issue or display of incorrect information where not desired. (E.g. showing the price of something as 0 where instead it should be "empty") Also haven't run this against the "upcoming" zen_not_null function in case the value returned is a zero which would be an integer...

[DrByte]

Confirmed: the updates to includes/functions/functions_prices.php to fix this are staged in v157c, at:
https://github.com/zencart/zencart/r...ons_prices.php
which can safely be used in v157b

[Carbonless]

Confirmed: the updates to includes/functions/functions_prices.php to fix this are staged in v157c, at:
https://github.com/zencart/zencart/r...ons_prices.php
which can safely be used in v157b

Tested & Confirming as well: This fix eliminated the creation of error log entry when an item has been added to cart!