A non-numeric value encountered in shopping_cart.php

[simon1066]

ZC v1.5.7b
PHP 7.2.10
Mods: OPC, CEON Mapping, DPU, Quantity Discounts, Structured Data, SitemapXML, Inventory, Dynamic Filet, Colorbox, CSS/JS Loader

Updating from ZC v1.5.6c to ZC v1.5.7b, I get a warning in logs when adding to cart a product marked as:

'Product is Virtual: Yes, Skip Shipping Address'
'Always Free Shipping: No, Normal Shipping Rules'

[23-Dec-2020 14:22:34 Europe/London] Request URI: /mycategory/myproduct, IP address: 127.0.0.1
#1  shoppingCart->calculate() called at [D:\wamp64\www\mydomain.co.uk\includes\classes\shopping_cart.php:1362]
#2  shoppingCart->show_total() called at [D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\common\tpl_header.php:58]
#3  require(D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\common\tpl_header.php) called at [D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\common\tpl_main_page.php:138]
#4  require(D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\common\tpl_main_page.php) called at [D:\wamp64\www\mydomain.co.uk\index.php:94]
--> PHP Warning: A non-numeric value encountered in D:\wamp64\www\mydomain.co.uk\includes\classes\shopping_cart.php on line 737.

The product is not priced by attributes and has only one read-only attribute applied to it. If I remove this attribute I get no warnings.

Line 734 to 737 of shopping_cart.php is:

/ appears to confuse products priced by attributes
                if ($product->fields['product_is_always_free_shipping'] == '1' or $product->fields['products_virtual'] == '1') {
                  $shipping_attributes_price = zen_get_discount_calc($product->fields['products_id'], $attribute_price->fields['products_attributes_id'], $attribute_price->fields['options_values_price'], $qty);
                  $freeShippingTotal += $shipping_attributes_price;

I guess I have something blank when it shouldn't be and I won't rule out file merging errors during upgrade, any clues where to look?

P.S. If I then visit the shopping cart page I get a larger number of warnings:

[23-Dec-2020 14:54:56 Europe/London] Request URI: /shopping-cart, IP address: 127.0.0.1
#1  shoppingCart->calculate() called at [D:\wamp64\www\mydomain.co.uk\includes\classes\shopping_cart.php:1385]
#2  shoppingCart->show_weight() called at [D:\wamp64\www\mydomain.co.uk\includes\modules\pages\shopping_cart\header_php.php:30]
#3  require(D:\wamp64\www\mydomain.co.uk\includes\modules\pages\shopping_cart\header_php.php) called at [D:\wamp64\www\mydomain.co.uk\index.php:35]
--> PHP Warning: A non-numeric value encountered in D:\wamp64\www\mydomain.co.uk\includes\classes\shopping_cart.php on line 737.

[23-Dec-2020 14:54:56 Europe/London] Request URI: /shopping-cart, IP address: 127.0.0.1
#1  shoppingCart->calculate() called at [D:\wamp64\www\mydomain.co.uk\includes\classes\shopping_cart.php:1362]
#2  shoppingCart->show_total() called at [D:\wamp64\www\mydomain.co.uk\includes\modules\pages\shopping_cart\header_php.php:45]
#3  require(D:\wamp64\www\mydomain.co.uk\includes\modules\pages\shopping_cart\header_php.php) called at [D:\wamp64\www\mydomain.co.uk\index.php:35]
--> PHP Warning: A non-numeric value encountered in D:\wamp64\www\mydomain.co.uk\includes\classes\shopping_cart.php on line 737.

[23-Dec-2020 14:54:56 Europe/London] Request URI: /shopping-cart, IP address: 127.0.0.1
#1  shoppingCart->calculate() called at [D:\wamp64\www\mydomain.co.uk\includes\classes\shopping_cart.php:1362]
#2  shoppingCart->show_total() called at [D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\common\tpl_header.php:58]
#3  require(D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\common\tpl_header.php) called at [D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\common\tpl_main_page.php:138]
#4  require(D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\common\tpl_main_page.php) called at [D:\wamp64\www\mydomain.co.uk\index.php:94]
--> PHP Warning: A non-numeric value encountered in D:\wamp64\www\mydomain.co.uk\includes\classes\shopping_cart.php on line 737.

[23-Dec-2020 14:54:56 Europe/London] Request URI: /shopping-cart, IP address: 127.0.0.1
#1  shoppingCart->calculate() called at [D:\wamp64\www\mydomain.co.uk\includes\classes\shopping_cart.php:1362]
#2  shoppingCart->show_total() called at [D:\wamp64\www\mydomain.co.uk\includes\modules\shipping_estimator.php:143]
#3  require(D:\wamp64\www\mydomain.co.uk\includes\modules\shipping_estimator.php) called at [D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\templates\tpl_shopping_cart_default.php:191]
#4  require(D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\templates\tpl_shopping_cart_default.php) called at [D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\common\tpl_main_page.php:220]
#5  require(D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\common\tpl_main_page.php) called at [D:\wamp64\www\mydomain.co.uk\index.php:94]
--> PHP Warning: A non-numeric value encountered in D:\wamp64\www\mydomain.co.uk\includes\classes\shopping_cart.php on line 737.

[23-Dec-2020 14:54:56 Europe/London] Request URI: /shopping-cart, IP address: 127.0.0.1
#1  shoppingCart->calculate() called at [D:\wamp64\www\mydomain.co.uk\includes\classes\shopping_cart.php:1385]
#2  shoppingCart->show_weight() called at [D:\wamp64\www\mydomain.co.uk\includes\modules\shipping_estimator.php:149]
#3  require(D:\wamp64\www\mydomain.co.uk\includes\modules\shipping_estimator.php) called at [D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\templates\tpl_shopping_cart_default.php:191]
#4  require(D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\templates\tpl_shopping_cart_default.php) called at [D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\common\tpl_main_page.php:220]
#5  require(D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\common\tpl_main_page.php) called at [D:\wamp64\www\mydomain.co.uk\index.php:94]
--> PHP Warning: A non-numeric value encountered in D:\wamp64\www\mydomain.co.uk\includes\classes\shopping_cart.php on line 737.

[23-Dec-2020 14:54:56 Europe/London] Request URI: /shopping-cart, IP address: 127.0.0.1
#1  shoppingCart->calculate() called at [D:\wamp64\www\mydomain.co.uk\includes\classes\shopping_cart.php:1385]
#2  shoppingCart->show_weight() called at [D:\wamp64\www\mydomain.co.uk\includes\functions\functions_general.php:906]
#3  zen_get_shipping_enabled() called at [D:\wamp64\www\mydomain.co.uk\includes\modules\shipping\flat.php:24]
#4  flat->__construct() called at [D:\wamp64\www\mydomain.co.uk\includes\classes\shipping.php:68]
#5  shipping->__construct() called at [D:\wamp64\www\mydomain.co.uk\includes\modules\shipping_estimator.php:153]
#6  require(D:\wamp64\www\mydomain.co.uk\includes\modules\shipping_estimator.php) called at [D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\templates\tpl_shopping_cart_default.php:191]
#7  require(D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\templates\tpl_shopping_cart_default.php) called at [D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\common\tpl_main_page.php:220]
#8  require(D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\common\tpl_main_page.php) called at [D:\wamp64\www\mydomain.co.uk\index.php:94]
--> PHP Warning: A non-numeric value encountered in D:\wamp64\www\mydomain.co.uk\includes\classes\shopping_cart.php on line 737.

[23-Dec-2020 14:54:56 Europe/London] Request URI: /shopping-cart, IP address: 127.0.0.1
#1  shoppingCart->calculate() called at [D:\wamp64\www\mydomain.co.uk\includes\classes\shopping_cart.php:1660]
#2  shoppingCart->free_shipping_items() called at [D:\wamp64\www\mydomain.co.uk\includes\functions\functions_general.php:921]
#3  zen_get_shipping_enabled() called at [D:\wamp64\www\mydomain.co.uk\includes\modules\shipping\flat.php:24]
#4  flat->__construct() called at [D:\wamp64\www\mydomain.co.uk\includes\classes\shipping.php:68]
#5  shipping->__construct() called at [D:\wamp64\www\mydomain.co.uk\includes\modules\shipping_estimator.php:153]
#6  require(D:\wamp64\www\mydomain.co.uk\includes\modules\shipping_estimator.php) called at [D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\templates\tpl_shopping_cart_default.php:191]
#7  require(D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\templates\tpl_shopping_cart_default.php) called at [D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\common\tpl_main_page.php:220]
#8  require(D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\common\tpl_main_page.php) called at [D:\wamp64\www\mydomain.co.uk\index.php:94]
--> PHP Warning: A non-numeric value encountered in D:\wamp64\www\mydomain.co.uk\includes\classes\shopping_cart.php on line 737.

[23-Dec-2020 14:54:56 Europe/London] Request URI: /shopping-cart, IP address: 127.0.0.1
#1  shoppingCart->calculate() called at [D:\wamp64\www\mydomain.co.uk\includes\classes\shopping_cart.php:1660]
#2  shoppingCart->free_shipping_items() called at [D:\wamp64\www\mydomain.co.uk\includes\functions\functions_general.php:924]
#3  zen_get_shipping_enabled() called at [D:\wamp64\www\mydomain.co.uk\includes\modules\shipping\flat.php:24]
#4  flat->__construct() called at [D:\wamp64\www\mydomain.co.uk\includes\classes\shipping.php:68]
#5  shipping->__construct() called at [D:\wamp64\www\mydomain.co.uk\includes\modules\shipping_estimator.php:153]
#6  require(D:\wamp64\www\mydomain.co.uk\includes\modules\shipping_estimator.php) called at [D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\templates\tpl_shopping_cart_default.php:191]
#7  require(D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\templates\tpl_shopping_cart_default.php) called at [D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\common\tpl_main_page.php:220]
#8  require(D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\common\tpl_main_page.php) called at [D:\wamp64\www\mydomain.co.uk\index.php:94]
--> PHP Warning: A non-numeric value encountered in D:\wamp64\www\mydomain.co.uk\includes\classes\shopping_cart.php on line 737.


[23-Dec-2020 14:54:56 Europe/London] Request URI: /shopping-cart, IP address: 127.0.0.1
#1  shoppingCart->calculate() called at [D:\wamp64\www\mydomain.co.uk\includes\classes\shopping_cart.php:1362]
#2  shoppingCart->show_total() called at [D:\wamp64\www\mydomain.co.uk\includes\modules\shipping_estimator.php:155]
#3  require(D:\wamp64\www\mydomain.co.uk\includes\modules\shipping_estimator.php) called at [D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\templates\tpl_shopping_cart_default.php:191]
#4  require(D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\templates\tpl_shopping_cart_default.php) called at [D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\common\tpl_main_page.php:220]
#5  require(D:\wamp64\www\mydomain.co.uk\includes\templates\my_template\common\tpl_main_page.php) called at [D:\wamp64\www\mydomain.co.uk\index.php:94]
--> PHP Warning: A non-numeric value encountered in D:\wamp64\www\mydomain.co.uk\includes\classes\shopping_cart.php on line 737.

[DrByte]

Something to test as part of researching "why":

try adding the extra line as shown:

                  $shipping_attributes_price = zen_get_discount_calc($product->fields['products_id'], $attribute_price->fields['products_attributes_id'], $attribute_price->fields['options_values_price'], $qty);
if (!is_numeric($shipping_attributes_price)) { var_dump($shipping_attributes_price); die(); }
                  $freeShippingTotal += $shipping_attributes_price;

it should then show on screen what the non-numeric value is ... which will help in exploring how it came to be non-numeric in the first place

[simon1066]

Something to test as part of researching "why":

try adding the extra line as shown:

                  $shipping_attributes_price = zen_get_discount_calc($product->fields['products_id'], $attribute_price->fields['products_attributes_id'], $attribute_price->fields['options_values_price'], $qty);
if (!is_numeric($shipping_attributes_price)) { var_dump($shipping_attributes_price); die(); }
                  $freeShippingTotal += $shipping_attributes_price;

it should then show on screen what the non-numeric value is ... which will help in exploring how it came to be non-numeric in the first place

Thank you, that's useful.

I think it showed that the non-numeric value was 0

3 item(s) - D:\wamp64\www\mydomain.co.uk\includes\classes\shopping_cart.php:737: string(0) ""

On a hunch, I changed the price prefix of the read-only attribute from +0.000 to +1.0000 and the warnings disappeared. Can't think why that might be.

[DrByte]

'string(0) ""' means "empty string, of length 0" ... and doesn't convert to a number automatically (whereas a 0 or 1 would)

I'm unable to replicate the scenario on an uncustomized site.
Using demo-products on a new site, I went to the Mixed Product Types category and clicked Copy on Product General Type to make a duplicate product.
Then I enabled the product after changing its name to "test virtual product" and setting Virtual: Yes as you mentioned above.
Then I went to Attributes and found the 'Shipping [Read Only]' option, clicked on it and chose the "Free shipping included!" value, and set the "is Display Only" setting to yes. Price-prefix defaulted to +0.0000.
(I chose that attribute only because it's a "read only" option type, not because it's related to free shipping)
Attempting to add the product to cart triggers no errors. Nor does opening Shipping Estimator screen.
I also enabled shipping-estimator on shopping-cart page. No errors triggered.
I have Flat Rate shipping enabled with just defaults.

[simon1066]

'string(0) ""' means "empty string, of length 0" ... and doesn't convert to a number automatically (whereas a 0 or 1 would)

I'm unable to replicate the scenario.
Using demo-products on a new site, I went to the Mixed Product Types category and clicked Copy on Product General Type to make a duplicate product.
Then I enabled the product after changing its name to "test virtual product" and setting Virtual: Yes as you mentioned above.
Then I went to Attributes and found the 'Shipping [Read Only]' option, clicked on it and chose the "Free shipping included!" value, and set the "is Display Only" setting to yes. Price-prefix defaulted to +0.0000.
(I chose that attribute only because it's a "read only" option type, not because it's related to free shipping)
Attempting to add the product to cart triggers no errors. Nor does opening Shipping Estimator screen.
I also enabled shipping-estimator on shopping-cart page. No errors triggered.
I have Flat Rate shipping enabled with just defaults.

Thanks for trying DrByte, I'll do some further digging - perhaps after I've slept on it.

[Carbonless]

ZC 1.5.7b
php vers 7.3
with Shopping cart Reminder
Edit Orders
TY Package tracker
Email Export
Clone Template
ZCA Boot 4
and Order Comment Boiler plate


When adding an item to the shopping cart, we are receiving the following error log:
Code:

[07-Jan-2021 19:10:14 America/Chicago] Request URI: /index.php?main_page=shopping_cart, IP address: xxxxx
#1 shoppingCart->calculate() called at [/includes/classes/shopping_cart.php:1362]
#2 shoppingCart->show_total() called at [/includes/modules/pages/shopping_cart/header_php.php:45]
#3 require(/includes/modules/pages/shopping_cart/header_php.php) called at [/index.php:35]
--> PHP Warning: A non-numeric value encountered in /includes/classes/shopping_cart.php on line 737.

[DrByte]

Again, looking for steps to recreate a product that triggers this error when adding to cart or displaying the cart.

Latest attempt, based on Carbonless's posts:

New product:
- is-always-free-shipping: yes
- price = 0

Created Option Names:
- Qty
- Imprint

Created Option Values:
- Qty: 1, 2, 4, 6
- Imprint: text

Assigned attributes:
- Qty: 1: $19, 2: 30, 4: 51, 6: $73
- Imprint: text

Adding this item to cart isn't triggering any errors for me.

[Carbonless]

Again, looking for steps to recreate a product that triggers this error when adding to cart or displaying the cart.

Latest attempt, based on Carbonless's posts:

New product:
- is-always-free-shipping: yes
- price = 0

Created Option Names:
- Qty
- Imprint

Created Option Values:
- Qty: 1, 2, 4, 6
- Imprint: text

Assigned attributes:
- Qty: 1: $19, 2: 30, 4: 51, 6: $73
- Imprint: text

Adding this item to cart isn't triggering any errors for me.

It did create an error log, and repeated this error 33 times in the log file:

[07-Jan-2021 22:48:03 America/Chicago] Request URI: /index.php?main_page=shopping_cart, IP address: xxxxx
#1  shoppingCart->calculate() called at [/includes/classes/shopping_cart.php:1362]
#2  shoppingCart->show_total() called at [/includes/modules/pages/shopping_cart/header_php.php:45]
#3  require(/includes/modules/pages/shopping_cart/header_php.php) called at [/index.php:35]
--> PHP Warning: A non-numeric value encountered in /includes/classes/shopping_cart.php on line 737.

It doesnt seem to hinder the shopping experience from the customer side or display any errors to them. Only to the error log.

[DrByte]

I don't dispute that it may have created a log on "your" server while I was attempting to figure out what I might need to create to replicate the problem.
My point is that by using the steps I outlined, I could not recreate it on my system, so I'm wondering whether I missed a step in how I set up the product or its attributes?

[Carbonless]

Misunderstood what you were trying to achieve...

example of current setup. Error is occurring on any product.

New product:
Product is free - NO
Priced by attributes - NO
Product is Virtual - NO
Always Free Shipping - YES
Show Qty Box - NO
Qty Min - 1
Qty Max - 0
Qty/min/max - NO

Attributes
Option names: Order, Title, Previous Order#, Stock, Backside
Option values:
Order : new, exact, repeat with changes all 0 value
Title: text
Previous Order#: text
Stock: glossy 2 side (0), glossy 1 side (0), matte (2.0)
Backside: no (0), B&W (1.50), Color (3.0)