Results 1 to 7 of 7
  1. #1
    Join Date
    Apr 2013
    Location
    eglisau switzerland
    Posts
    531
    Plugin Contributions
    0

    Default V157b order status comments have additional empty lines between the text

    V157b responsive classic

    When I add comments to update a customer order status it looks OK but when I send the email it is not wsywig, there are additional empty lines added to my comments; the standard zen cart beginning and end in navy are OK.
    When I go back in admin and check the comments they also now have these additional empty lines.

    My text editor is CKEditor.

    I use the same text editor with the same settings to write product descriptions with no additional empty lines added.

    Here is a test in the German language, I get the same effect in English; maybe I can configure the text editor somewhere?

    Sehr geehrte(r) marton hasenberg,
    Bestellnummer: 1786
    Bestelldetails
    Bestelldatum: Mittwoch, 27. Januar 2021
    Die Kommentare für Ihre Bestellung lauten:


    This is a test to check

    how does it look?


    Just a status comment


    Usually, I add a discount for repeat orders.


    Der Status Ihrer Bestellung hat sich nicht ge�ndert:
    Aktueller Status: Bearbeitung
    Bitte antworten Sie auf diese E-Mail, wenn Sie Fragen haben.
    Simones Hunde Design

  2. #2
    Join Date
    Jul 2012
    Posts
    15,913
    Plugin Contributions
    17

    Default Re: V157b order status comments have additional empty lines between the text

    This is a result of continued oversanitization. There is/has been some improvement, but there still is (as indicated) these extra lines.

    Changing the editor's mode to "source mode" I believe would allow entering the content without the html characters including the extra line endings... I likely am wrong about how to not have those extra spaces, though wouldn't be the first time.
    ZC Installation/Maintenance Support <- Site
    Contribution for contributions welcome...

  3. #3
    Join Date
    Jan 2004
    Posts
    66,350
    Blog Entries
    7
    Plugin Contributions
    271

    Default Re: V157b order status comments have additional empty lines between the text

    Extra sanitization is applied to the "first" comment on any order. This is in case the customer enters anything malicious in it, so that it can't negatively harm your store.
    Subsequent comments are normally only entered via an Admin and thus the sanitization is less aggressive.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  4. #4
    Join Date
    Apr 2013
    Location
    eglisau switzerland
    Posts
    531
    Plugin Contributions
    0

    Default Re: V157b order status comments have additional empty lines between the text

    Quote Originally Posted by mc12345678 View Post
    This is a result of continued oversanitization. There is/has been some improvement, but there still is (as indicated) these extra lines.

    Changing the editor's mode to "source mode" I believe would allow entering the content without the html characters including the extra line endings... I likely am wrong about how to not have those extra spaces, though wouldn't be the first time.
    You mean when I write the comment in Admin to click on the "source" box above right?
    Tried that but sadly the same issue, you will have to go down the mine and look for another nugget with a fix. :)

    Is it possible to configure the CKeditor anywhere? There is no CK entry in admin/configuration in English or German.
    I am using a new 157b installation.

  5. #5
    Join Date
    Jan 2004
    Posts
    66,350
    Blog Entries
    7
    Plugin Contributions
    271

    Default Re: V157b order status comments have additional empty lines between the text

    Quote Originally Posted by marton_1 View Post
    Is it possible to configure the CKeditor anywhere?
    /editors/ckeditor/config.js
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

  6. #6
    Join Date
    Apr 2013
    Location
    eglisau switzerland
    Posts
    531
    Plugin Contributions
    0

    Default Re: V157b order status comments have additional empty lines between the text

    I tried commenting out the AutoParagraph but it did not help

    When I write my comment and look at it in source mode it looks like this
    Code:
    <p>This is a test<br />
    try two lines</p>
    
    <p>how does this look</p>
    Then I send it and it now looks like this
    Code:
    <p>This is a test<br /><br />
    try two lines</p><br />
    <br />
    <p>how does this look</p>
    Somehow it has picked up some extra <br />s

  7. #7
    Join Date
    Sep 2009
    Location
    Stuart, FL
    Posts
    10,514
    Plugin Contributions
    78

    Default Re: V157b order status comments have additional empty lines between the text

    Quote Originally Posted by marton_1 View Post
    I tried commenting out the AutoParagraph but it did not help

    When I write my comment and look at it in source mode it looks like this
    Code:
    <p>This is a test<br />
    try two lines</p>
    
    <p>how does this look</p>
    Then I send it and it now looks like this
    Code:
    <p>This is a test<br /><br />
    try two lines</p><br />
    <br />
    <p>how does this look</p>
    Somehow it has picked up some extra <br />s
    There's most likely a call to nl2br (converting new-lines to <br>'s) somewhere in the processing.

 

 

Similar Threads

  1. Reduce empty lines of between product listing
    By digulu in forum Templates, Stylesheets, Page Layout
    Replies: 11
    Last Post: 11 Jan 2010, 05:05 PM
  2. I have noticed that updating the order status does not reflect on the Invoice?
    By Website Rob in forum Managing Customers and Orders
    Replies: 1
    Last Post: 24 Oct 2009, 02:04 AM
  3. Changing the text in the Order Status drop down on Edit Order page
    By jcountryman in forum Managing Customers and Orders
    Replies: 3
    Last Post: 15 Oct 2009, 04:34 AM
  4. Increasing gap between text lines
    By Matt Smith in forum Basic Configuration
    Replies: 1
    Last Post: 2 Jul 2009, 11:41 AM
  5. spacing between lines of text
    By hilary in forum General Questions
    Replies: 4
    Last Post: 26 Aug 2008, 12:47 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR