Customer email text/format problems - $EMAIL_SALUTATION + $EMAIL_ORDER_MESSAGE_UPDATE

[swguy]

A PR has been created.

https://github.com/lat9/edit_orders/pull/185

[carlwhat]

the more i think about this, the less unsure i am about it.

we could get into the whole structure of sending email.... which frankly is far too complex and to me in need of a refactor...

the actual sending of the email gets done in the function zen_mail. this is where the PHPMailer object gets created. and yet this same function is also dealing with this html_msg array (now called block).

and if we look at this section of code:

https://github.com/zencart/zencart/b....php#L101-L109

or this section of code:

https://github.com/zencart/zencart/b....php#L581-L595

there is a bunch of testing for isset of elements of the array.

if ZC is to provide plugins the ability to use a template for sending a mail, should ZC not account for elements of the array not included in the message?

i am not sure what the answer is, but if the zen_mail function is the only time ZC sends an email, i think there is far too much going on to process an array utilizing some template that has required elements, that if not provided, result in the email seen by ted.

[Ted Grapler]

Adding the recommended code around line 242 of YOUR_ADMIN/edit_orders.php solved this issue for me My order status update emails now have "Dear" as salutation and no extra unwanted text. Thank you carlwhat.

[carlwhat]

Adding the recommended code around line 242 of YOUR_ADMIN/edit_orders.php solved this issue for me My order status update emails now have "Dear" as salutation and no extra unwanted text. Thank you carlwhat.