A non-numeric value encountered in functions_general.php

[Philibel]

ZC: v1.5.7b
PHP: 7.4.15
Mods:

• edit_orders-4.5.5
• catalog_invoice
• ip_blocker-2.2.0
• sales_report-3.4.0
• quantity_discounts

In logs this appeared when I logged in with my test-account:

[23-Feb-2021 12:58:07 Europe] Request URI: /index.php?main_page=login, IP address: *.*.*.*
#1  zen_set_field_length()
 called at [/data/sites/web/your_site/www/includes/templates/template_default/templates/tpl_modules_create_account.php:142]
#2  require(/data/sites/web/your_site/www/includes/templates/template_default/templates/tpl_modules_create_account.php)
 called at [/data/sites/web/your_site/www/includes/templates/template_default/templates/tpl_login_default.php:90]
#3  require(/data/sites/web/your_site/www/includes/templates/template_default/templates/tpl_login_default.php)
 called at [/data/sites/web/your_site/www/includes/templates/responsive_classic/common/tpl_main_page.php:178]
#4  require(/data/sites/web/your_site/www/includes/templates/responsive_classic/common/tpl_main_page.php)
 called at [/data/sites/web/your_site/www/index.php:94]
--> PHP Warning: A non-numeric value encountered in
 /data/sites/web/your_site/www/includes/functions/functions_general.php on line 746.

I took the advice from DrByte from post #2 in A non-numeric value encountered in shopping_cart.php and adjusted it to the line.

Location of the adjustment in includes/functions/functions_general.php.

            $length = 'size="' . ($field_length + 1) . '" maxlength="' . $field_length . '"'; //Line 746
            // To find out what goes wrong
if (!is_numeric($length)) { var_dump($length); die(); } //Only this line added
            break;
    }
    return $length; 

When I try to log in as a customer, on the login page in the new account field:
First Name:string(24) "size="33" maxlength="32""

I couldn't a solution. Than I change the varchar in the database from 32 to 34 for the column "customer_firstname"
Result: both number went up: size and maxlength.

Is ip_blocker-2.2.0 maybe to blame? That's the last add-on.

[carlwhat]

In logs this appeared when I logged in with my test-account:
[CODE][23-Feb-2021 12:58:07 Europe] Request URI: /index.php?main_page=login, IP address: *.*.*.*
#1 zen_set_field_length()
called at [/data/sites/web/your_site/www/includes/templates/template_default/templates/tpl_modules_create_account.php:142]

the problem looks to be with date of birth. line 142:

https://github.com/zencart/zencart/b...count.php#L142

do you require date of birth for customers? does it exist in your customers table?

best.

[DrByte]

Does editing line 740 of functions_general like this help?

$field_length = (int)zen_field_length($tbl, $fld);

[Philibel]

@carlwhat
line 142: same as the Github-version

<?php echo zen_draw_input_field('dob','', zen_set_field_length(TABLE_CUSTOMERS, 'customers_dob', '20') . ' id="dob" placeholder="' . ENTRY_DATE_OF_BIRTH_TEXT . '"' . (ACCOUNT_DOB == 'true' && (int)ENTRY_DOB_MIN_LENGTH != 0 ? ' required' : '')); ?>

date of birth: is set "true"
It exists in the customers table:

  `customers_dob` datetime NOT NULL DEFAULT '0001-01-01 00:00:00', 

I'm going to try DrByte's suggestion next and get back on that.

[Philibel]

$field_length = (int)zen_field_length($tbl, $fld);

It doesn't give a warning log anymore, so that good.
Until I tried to register as a customer: the date of birth field accepts nothing. You can select it but numbers nor text appears.

After I removed (int), typing was enabled again.

[carlwhat]

$field_length = (int)zen_field_length($tbl, $fld);

It doesn't give a warning log anymore, so that good.
Until I tried to register as a customer: the date of birth field accepts nothing. You can select it but numbers nor text appears.

After I removed (int), typing was enabled again.

definite bug in the code. see:



max_length for datetime length is an empty string. casting it to an integer gives you 0.

you have a few options. 2 off the top of my head are:

• turn the requirement for DOB off.
• hand code the html that gets generated in this section as below.

zen_draw_input_field('dob','', 'size="20" maxlength="35" id="dob" placeholder="' . ENTRY_DATE_OF_BIRTH_TEXT . '"' . (ACCOUNT_DOB == 'true' && (int)ENTRY_DOB_MIN_LENGTH != 0 ? ' required' : '')); 

feel free to change the size and maxlength to numbers of your liking.

hope that helps.

[DrByte]

Thanks @carlwhat. We'll probably need to hard-code that into core.

@Philibel what MySQL version are you using?

[Philibel]

@carlwhat:

I've an appointment so I'll take a look later on.

@DrByte:

Database Engine: MySQL 5.7.31-34-log

[Philibel]

@carlwhat:

I replaced line 142 in /includes/templates/template_default/templates/tpl_modules_create_account.php with:

<?php echo zen_draw_input_field('dob','', 'size="20" maxlength="35" id="dob" placeholder="' . ENTRY_DATE_OF_BIRTH_TEXT . '"' . (ACCOUNT_DOB == 'true' && (int)ENTRY_DOB_MIN_LENGTH != 0 ? ' required' : '')); ?>

* Typing in the field works
* No error log is created
* looks ok now

Thank you both for helping me out on this.

[mc12345678]

definite bug in the code. see:



max_length for datetime length is an empty string. casting it to an integer gives you 0.

you have a few options. 2 off the top of my head are:

• turn the requirement for DOB off.
• hand code the html that gets generated in this section as below.

zen_draw_input_field('dob','', 'size="20" maxlength="35" id="dob" placeholder="' . ENTRY_DATE_OF_BIRTH_TEXT . '"' . (ACCOUNT_DOB == 'true' && (int)ENTRY_DOB_MIN_LENGTH != 0 ? ' required' : '')); 

feel free to change the size and maxlength to numbers of your liking.

hope that helps.

Thanks @carlwhat. We'll probably need to hard-code that into core.

@Philibel what MySQL version are you using?

Isn't the maximum length of a datetime field 26 characters based on:

the range for DATETIME values is '1000-01-01 00:00:00.000000' to '9999-12-31 23:59:59.999999'

As provided at: https://dev.mysql.com/doc/refman/8.0/en/datetime.html or the 5.7 equivalent?

Where this could be "addressed" in https://github.com/zencart/zencart/b...ry_factory.php at/around line 717 with something like:

    $this->max_length = preg_replace('/[a-z\(\)]/', '', $type);
    if ($type == 'datetime') {
      $this->max_length = '26';
    }

In this way, templates don't need to do something "special" if the field is a datetime? Possibly another/additional method could be used such as determining if the word 'time' is in the $type and use some "predefined" size as the other "time" type fields are somewhat similar?

FYI, I chose a string version of the number instead of just assigning it to a number to maintain the datatype the same throughout.