157c Featured Product addition error when using South Africa dates.

[Louis]

Using 157c (same issue found in 157b)

When adding featured products in admin, if no date is selected, the product is added successfully. If however you enter the start and end dates the following error is generated.

Newly upgraded to 157c, date format set as ddmmyyyy for use in South Africa. PHP 7.4 and MySQL 5.7

Admin directory name changed for security reasons.


08-Mar-2021 19:31:30 Africa/Johannesburg] Request URI: /xxxxxxadmin/index.php?cmd=featured&page=2&action=insert, IP address: 197.184.44.194
#1 trigger_error() called at [/includes/classes/db/mysql/query_factory.php:170]
#2 queryFactory->show_error() called at [/includes/classes/db/mysql/query_factory.php:142]
#3 queryFactory->set_error() called at [/includes/classes/db/mysql/query_factory.php:269]
#4 queryFactory->Execute() called at [/xxxxxxadmin/featured.php:39]
#5 require(/xxxxxxxadmin/featured.php) called at [/xxxxxxxadmin/index.php:11]
--> PHP Fatal error: 1292:Incorrect date value: '20213103' for column 'expires_date' at row 1 :: INSERT INTO astro_featured (products_id, featured_date_added, expires_date, status, featured_date_available)
VALUES (3725,
now(),
'20213103',
'1',
'20210103') ==> (as called by) /xxxxxxadmin/featured.php on line 39 <== in /includes/classes/db/mysql/query_factory.php on line 170.

[Louis]

I just noticed, it is also generating a fatal error in specials.

--> PHP Fatal error: 1292:Incorrect date value: '20213103' for column 'expires_date' at row 1 :: UPDATE astro_specials
SET specials_new_products_price = '30.4340',
specials_last_modified = now(),
expires_date = '20213103',
specials_date_available = '20210103'
WHERE specials_id = 227 ==> (as called by) /xxxxxadmin/specials.php on line 103 <== in /includes/classes/db/mysql/query_factory.php on line 170.

[swguy]

You probably need to get some slashes in your date format, i.e. dd/mm/yyyy

[carlwhat]

Using 157c (same issue found in 157b)

When adding featured products in admin, if no date is selected, the product is added successfully. If however you enter the start and end dates the following error is generated.

Newly upgraded to 157c, date format set as ddmmyyyy for use in South Africa. PHP 7.4 and MySQL 5.7

Admin directory name changed for security reasons.


08-Mar-2021 19:31:30 Africa/Johannesburg] Request URI: /xxxxxxadmin/index.php?cmd=featured&page=2&action=insert, IP address: 197.184.44.194
#1 trigger_error() called at [/includes/classes/db/mysql/query_factory.php:170]
#2 queryFactory->show_error() called at [/includes/classes/db/mysql/query_factory.php:142]
#3 queryFactory->set_error() called at [/includes/classes/db/mysql/query_factory.php:269]
#4 queryFactory->Execute() called at [/xxxxxxadmin/featured.php:39]
#5 require(/xxxxxxxadmin/featured.php) called at [/xxxxxxxadmin/index.php:11]
--> PHP Fatal error: 1292:Incorrect date value: '20213103' for column 'expires_date' at row 1 :: INSERT INTO astro_featured (products_id, featured_date_added, expires_date, status, featured_date_available)
VALUES (3725,
now(),
'20213103',
'1',
'20210103') ==> (as called by) /xxxxxxadmin/featured.php on line 39 <== in /includes/classes/db/mysql/query_factory.php on line 170.

wow. who knew...

in admin/featured.php, try adding the following code between lines 33 and 34:

// first line below is 34
      $products_id = (int)$_POST['products_id'];
//new code below:

        $featured_date_available_raw = zen_db_prepare_input($_POST['featured_date_available']);
        if (DATE_FORMAT_DATE_PICKER != 'yy-mm-dd' && !empty($featured_date_available_raw)) {
          $local_fmt = zen_datepicker_format_fordate();
          $dt = DateTime::createFromFormat($local_fmt, $featured_date_available_raw);
          $featured_date_available_raw = 'null';
          if (!empty($dt)) {
            $featured_date_available_raw = $dt->format('Y-m-d');
          }
        }
        $featured_date_available = (date('Y-m-d') < $featured_date_available_raw) ? $featured_date_available_raw : '0001-01-01';
        $expires_date_raw = zen_db_prepare_input($_POST['expires_date']);
        if (DATE_FORMAT_DATE_PICKER != 'yy-mm-dd' && !empty($expires_date_raw)) {
          $local_fmt = zen_datepicker_format_fordate();
          $dt = DateTime::createFromFormat($local_fmt, $expires_date_raw);
          $expires_date_raw = 'null';
          if (!empty($dt)) {
            $expires_date_raw = $dt->format('Y-m-d');
          }
        }
        $expires_date = (date('Y-m-d') < $expires_date_raw) ? $expires_date_raw : '0001-01-01';
// end of new code. 

[carlwhat]

I just noticed, it is also generating a fatal error in specials.

--> PHP Fatal error: 1292:Incorrect date value: '20213103' for column 'expires_date' at row 1 :: UPDATE astro_specials
SET specials_new_products_price = '30.4340',
specials_last_modified = now(),
expires_date = '20213103',
specials_date_available = '20210103'
WHERE specials_id = 227 ==> (as called by) /xxxxxadmin/specials.php on line 103 <== in /includes/classes/db/mysql/query_factory.php on line 170.

yeah. code duplication is a problem... i was looking at combining specials and featured together.... but time and other things get in the way...

lmk if the code provided works....

best.

[Louis]

Sorry guys, never mind.

The date format in admin/includes/English.php was not changed.

I updated this to the following and the functions mentioned above are now working as they were intended.

Return date in raw format

// $date should be in format dd/mm/yyyy

// raw date is in format YYYYMMDD, or DDMMYYYY

function zen_date_raw($date, $reverse = false) {

  if ($reverse) {

    return substr($date, 0, 2) . substr($date, 3, 2) . substr($date, 6, 4);

  } else {

    return substr($date, 6, 4) . substr($date, 3, 2) . substr($date, 0, 2);

  }

} 

//