Extra Characters in the comment section on printed forms

[wsworx]

ZC 1.5.7c
PHP 7.2
Edit Order 4.6
TyPackage Tracker 4.0 with corrections from GitHub

I am getting HTML tags etc along with the comments on printed forms.
The on screen comments do not have this issue.
Is there a way to prevent this?

[simon1066]

ZC v1.5.7c

I, too, see this. (invoice.php & packingslip.php are unchanged from stock)

[simon1066]

Looking at the ZC Github repo, I see that in ZC v1.5.8 the instances of 'zen_db_input' in admin/invoice.php & packingslip.php have been changed to 'zen_output_string_protected'. Working from this I believe that changing

zen_db_input

to

zen_output_string

in those two files will allow HTML to be properly displayed in the order comments fields of the packing slip and invoice previews.

[wsworx]

Looking at the ZC Github repo, I see that in ZC v1.5.8 the instances of 'zen_db_input' in admin/invoice.php & packingslip.php have been changed to 'zen_output_string_protected'. Working from this I believe that changing

zen_db_input

to

zen_output_string

in those two files will allow HTML to be properly displayed in the order comments fields of the packing slip and invoice previews.

Thank you for the input.
I tried your recommendation but it did not work.
It does not break anything but the extra characters are still there.
Your repair suggestion is on the extract from the database side, the error is occurring when the data is first being placed in the database.

[wsworx]

Thank you for the input.
I tried your recommendation but it did not work.
It does not break anything but the extra characters are still there.
Your repair suggestion is on the extract from the database side, the error is occurring when the data is first being placed in the database.

One note is that if I use the comments input window in EditOrders 4.6 I do not get the extra characters in the comments window of the order or on the invoice and packing slip. I do not want to do that though as it means extra clicking and wait time just to update shipping info. So however EO has the input setup is how ZC needs it setup.

[carlwhat]

in my testing, the screenshot from the OP is not an unmodified version of the invoice or the packingslip. both of these scripts only print the first comment.

the line in question is here:

https://github.com/zencart/zencart/b...voice.php#L293

in my testing, the removal of the zen function does the job, ie,

<td><?php echo ($order_history['comments'] == '' ? TEXT_NONE : nl2br($order_history['comments'])); ?>&nbsp;</td>

One note is that if I use the comments input window in EditOrders 4.6 I do not get the extra characters in the comments window of the order or on the invoice and packing slip. I do not want to do that though as it means extra clicking and wait time just to update shipping info. So however EO has the input setup is how ZC needs it setup.

i would not jump to such conclusions.

my feeling is that you are using the ckeditor to edit your comments. removal of that editor and using plain text (which looks to be what EO does, despite the config value for the editor) would also resolve your problem.... although not for the comments already stored in your db. you would also lose all of the functionality that ckeditor provides.

removal goes like so:

admin -> tools -> define pages editor -> top right is a pull down for text editor.

hope that helps.

[wsworx]

in my testing, the screenshot from the OP is not an unmodified version of the invoice or the packingslip. both of these scripts only print the first comment.

the line in question is here:

https://github.com/zencart/zencart/b...voice.php#L293

in my testing, the removal of the zen function does the job, ie,

<td><?php echo ($order_history['comments'] == '' ? TEXT_NONE : nl2br($order_history['comments'])); ?>##</td>

i would not jump to such conclusions.

my feeling is that you are using the ckeditor to edit your comments. removal of that editor and using plain text (which looks to be what EO does, despite the config value for the editor) would also resolve your problem.... although not for the comments already stored in your db. you would also lose all of the functionality that ckeditor provides.

removal goes like so:

admin -> tools -> define pages editor -> top right is a pull down for text editor.

hope that helps.

Thank you carlwhat, that took care of it.
My only concern is why would they have it written that way and was it just an oversight.