Help with a couple of error logs (Create Account & Dirbankaus)

**rlexyd** · 9 Aug 2021, 11:36 AM

Running recent install of zen cart 1.5.7c on PHP 7.3 with OPC and Direct Bank plugins.
I have been getting a couple of error logs and can't find reason why.

First error log:

Code:

[09-Aug-2021 20:17:01 Australia/Sydney] Request URI: /admin/index.php?cmd=orders&origin=index&page=1&oID=327&action=edit, IP address: 60.
#1  dirbankaus->update_status() called at [/includes/modules/payment/dirbankaus.php:41]
#2  dirbankaus->__construct() called at [/admin/orders.php:521]
#3  require(/admin/orders.php) called at [/admin/index.php:11]
--> PHP Warning: Illegal string offset 'id' in /includes/modules/payment/dirbankaus.php on line 50.

Line 50 in that .php file is: (I have 2 zone definitions set, 1st: Australian Zones - All Local Zones & 2nd: World Zones - All International Zones and State & Country as Dropdowns.) $check = $db->Execute("select zone_id from " . TABLE_ZONES_TO_GEO_ZONES . " where geo_zone_id = '" . MODULE_PAYMENT_DIRBANKAUS_ZONE . "' and zone_country_id = '" . $order->delivery['country']['id'] . "' order by zone_id");

Second error log: (I have FAX set to False in customer details.)

Code:

[09-Aug-2021 20:13:42 Australia/Sydney] Request URI: /index.php?main_page=create_account, IP address: 60.
#1  include(/includes/modules/create_account.php) called at [/includes/modules/pages/create_account/header_php.php:17]
#2  require(/includes/modules/pages/create_account/header_php.php) called at [/index.php:35]
--> PHP Notice: Undefined index: fax in /includes/modules/create_account.php on line 76.

Line 76 in that .php file is:
$fax = zen_db_prepare_input($_POST['fax']);

**rlexyd** · 9 Aug 2021, 10:45 PM

3rd error log:

Code:

[09-Aug-2021 22:44:57 Australia/Sydney] Request URI: /, IP address: 54.......
#1  zen_is_spider_session() called at [/includes/classes/OnePageCheckout.php:357]


#2  OnePageCheckout->initializeGuestCheckout() called at [/includes/classes/OnePageCheckout.php:162]
#2  OnePageCheckout->initializeGuestCheckout() called at [/includes/classes/OnePageCheckout.php:254]


#3  OnePageCheckout->guestCheckoutEnabled() called at [/includes/classes/observers/class.checkout_one_observer.php:107]
#3  OnePageCheckout->initTemporaryAddresses() called at [/includes/classes/observers/class.checkout_one_observer.php:200]


#4  checkout_one_observer->__construct() called at [/includes/autoload_func.php:44]
#5  require(/includes/autoload_func.php) called at [/includes/application_top.php:222]
#6  require(/includes/application_top.php) called at [/index.php:25]
--> PHP Notice: Undefined index: HTTP_USER_AGENT in /includes/functions/extra_functions/one_page_checkout_functions.php on line 86.

Line 86 in that .php file is:

$user_agent = strtolower($_SERVER['HTTP_USER_AGENT']);

4th error log:

Code:

[10-Aug-2021 01:24:21 Australia/Sydney] Request URI: /index.php?main_page=featured_products, IP address: 184.
#1  require(/includes/modules/pages/featured_products/header_php.php) called at [/index.php:35]
--> PHP Notice: Undefined variable: how_many in /includes/modules/pages/featured_products/header_php.php on line 84.


[10-Aug-2021 01:24:21 Australia/Sydney] Request URI: /index.php?main_page=featured_products, IP address: 184.
#1  require(/includes/templates/responsive_classic/templates/tpl_featured_products_default.php) called at [/includes/templates/responsive_classic/common/tpl_main_page.php:178]
#2  require(/includes/templates/responsive_classic/common/tpl_main_page.php) called at [/index.php:94]
--> PHP Notice: Undefined variable: show_top_submit_button in /includes/templates/responsive_classic/templates/tpl_featured_products_default.php on line 56.


[10-Aug-2021 01:24:21 Australia/Sydney] Request URI: /index.php?main_page=featured_products, IP address: 184.
#1  require(/includes/templates/responsive_classic/templates/tpl_featured_products_default.php) called at [/includes/templates/responsive_classic/common/tpl_main_page.php:178]
#2  require(/includes/templates/responsive_classic/common/tpl_main_page.php) called at [/index.php:94]
--> PHP Notice: Undefined variable: show_bottom_submit_button in /includes/templates/responsive_classic/templates/tpl_featured_products_default.php on line 92.


[10-Aug-2021 01:24:21 Australia/Sydney] Request URI: /index.php?main_page=featured_products, IP address: 184.
#1  require(/includes/templates/responsive_classic/templates/tpl_featured_products_default.php) called at [/includes/templates/responsive_classic/common/tpl_main_page.php:178]
#2  require(/includes/templates/responsive_classic/common/tpl_main_page.php) called at [/index.php:94]
--> PHP Notice: Undefined variable: show_bottom_submit_button in /includes/templates/responsive_classic/templates/tpl_featured_products_default.php on line 110.


[10-Aug-2021 01:24:21 Australia/Sydney] Request URI: /index.php?main_page=featured_products, IP address: 184.
#1  require(/includes/templates/responsive_classic/templates/tpl_featured_products_default.php) called at [/includes/templates/responsive_classic/common/tpl_main_page.php:178]
#2  require(/includes/templates/responsive_classic/common/tpl_main_page.php) called at [/index.php:94]
--> PHP Notice: Undefined variable: show_bottom_submit_button in /includes/templates/responsive_classic/templates/tpl_featured_products_default.php on line 131.


[10-Aug-2021 01:24:21 Australia/Sydney] Request URI: /index.php?main_page=featured_products, IP address: 184.
#1  require(/includes/templates/responsive_classic/templates/tpl_featured_products_default.php) called at [/includes/templates/responsive_classic/common/tpl_main_page.php:178]
#2  require(/includes/templates/responsive_classic/common/tpl_main_page.php) called at [/index.php:94]
--> PHP Notice: Undefined variable: show_top_submit_button in /includes/templates/responsive_classic/templates/tpl_featured_products_default.php on line 140.


[10-Aug-2021 01:24:21 Australia/Sydney] Request URI: /index.php?main_page=featured_products, IP address: 184.
#1  require(/includes/templates/responsive_classic/templates/tpl_featured_products_default.php) called at [/includes/templates/responsive_classic/common/tpl_main_page.php:178]
#2  require(/includes/templates/responsive_classic/common/tpl_main_page.php) called at [/index.php:94]
--> PHP Notice: Undefined variable: show_bottom_submit_button in /includes/templates/responsive_classic/templates/tpl_featured_products_default.php on line 140.

Here are the associated Lines in that PHP file: (This is a stock 1.5.7c file, it has not been modified in anyway)Line 56: if ($show_top_submit_button == true) {
Line 92: if ($show_bottom_submit_button == false && PREV_NEXT_BAR_LOCATION == '1') {
Line 110: if ($show_bottom_submit_button == true) {
Line 131: if ($show_bottom_submit_button == false && PREV_NEXT_BAR_LOCATION == '1') {
Line 140: if ($show_top_submit_button == true or $show_bottom_submit_button == true) {

**rlexyd** · 14 Aug 2021, 12:36 PM

Has anyone had a chance to look into these error logs? I know I'm one of many zenners are also looking for assistance and I would appreciate someone glancing over them and see if they can help

**mc12345678** · 14 Aug 2021, 01:50 PM

in includes/modules/pages/featured_pages/header_php.php
line 49:

Code:

  $how_many = 0;

should be moved up and before line 45:

Code:

if (PRODUCT_FEATURED_LISTING_MULTIPLE_ADD_TO_CART > 0 and $show_submit == true and $featured_products_split->number_of_rows > 0) {

changing to:

Code:

$how_many = 0;

// check whether to use multiple-add-to-cart, and whether top or bottom buttons are displayed
if (PRODUCT_FEATURED_LISTING_MULTIPLE_ADD_TO_CART > 0 and $show_submit == true and $featured_products_split->number_of_rows > 0) {

Though looks like ZC 1.5.8 has addressed this and made some other changes: That said, the specific issue was addressed for this page and a few others by PR4325

Looks like some more changes need to be made within that same if statement original lines 72-81(Not yet captured in ZC 1.5.8):

Code:

  if ( (($how_many > 0 and $show_submit == true and $featured_products_split->number_of_rows > 0) and (PRODUCT_FEATURED_LISTING_MULTIPLE_ADD_TO_CART == 1 or  PRODUCT_FEATURED_LISTING_MULTIPLE_ADD_TO_CART == 3)) ) {
    $show_top_submit_button = true;
  } else {
    $show_top_submit_button = false;
  }
  if ( (($how_many > 0 and $show_submit == true and $featured_products_split->number_of_rows > 0) and (PRODUCT_FEATURED_LISTING_MULTIPLE_ADD_TO_CART >= 2)) ) {
    $show_bottom_submit_button = true;
  } else {
    $show_bottom_submit_button = false;
  }

Should be changed to:

Code:

  if ( (($how_many > 0 and $show_submit == true and $featured_products_split->number_of_rows > 0) and (PRODUCT_FEATURED_LISTING_MULTIPLE_ADD_TO_CART == 1 or  PRODUCT_FEATURED_LISTING_MULTIPLE_ADD_TO_CART == 3)) ) {
    $show_top_submit_button = true;
  }
  if ( (($how_many > 0 and $show_submit == true and $featured_products_split->number_of_rows > 0) and (PRODUCT_FEATURED_LISTING_MULTIPLE_ADD_TO_CART >= 2)) ) {
    $show_bottom_submit_button = true;
  }

And up in the same area where $how_many = 0; was applied, could add:

Code:

$show_top_submit_button = false;
$show_bottom_submit_button = false;

The above "two" changes would resolve the reported issues noting that the first item is addressed in ZC 1.5.8 files.

**rlexyd** · 14 Aug 2021, 02:09 PM

Thank you very much mc, will action your steps in the morning.

**mc12345678** · 14 Aug 2021, 02:29 PM

Can also see PR 4445 at least for related code moves as provided in PR 4325. PR 4445 hasn't been approved, but addresses the above remaining issue(s).

**rlexyd** · 14 Aug 2021, 10:40 PM

Originally Posted by mc12345678

in includes/modules/pages/featured_pages/header_php.php
line 49:

Code:

  $how_many = 0;

should be moved up and before line 45:

Code:

if (PRODUCT_FEATURED_LISTING_MULTIPLE_ADD_TO_CART > 0 and $show_submit == true and $featured_products_split->number_of_rows > 0) {

changing to:

Code:

$how_many = 0;

// check whether to use multiple-add-to-cart, and whether top or bottom buttons are displayed
if (PRODUCT_FEATURED_LISTING_MULTIPLE_ADD_TO_CART > 0 and $show_submit == true and $featured_products_split->number_of_rows > 0) {

Though looks like ZC 1.5.8 has addressed this and made some other changes: That said, the specific issue was addressed for this page and a few others by PR4325

Looks like some more changes need to be made within that same if statement original lines 72-81(Not yet captured in ZC 1.5.8):

Code:

  if ( (($how_many > 0 and $show_submit == true and $featured_products_split->number_of_rows > 0) and (PRODUCT_FEATURED_LISTING_MULTIPLE_ADD_TO_CART == 1 or  PRODUCT_FEATURED_LISTING_MULTIPLE_ADD_TO_CART == 3)) ) {
    $show_top_submit_button = true;
  } else {
    $show_top_submit_button = false;
  }
  if ( (($how_many > 0 and $show_submit == true and $featured_products_split->number_of_rows > 0) and (PRODUCT_FEATURED_LISTING_MULTIPLE_ADD_TO_CART >= 2)) ) {
    $show_bottom_submit_button = true;
  } else {
    $show_bottom_submit_button = false;
  }

Should be changed to:

Code:

  if ( (($how_many > 0 and $show_submit == true and $featured_products_split->number_of_rows > 0) and (PRODUCT_FEATURED_LISTING_MULTIPLE_ADD_TO_CART == 1 or  PRODUCT_FEATURED_LISTING_MULTIPLE_ADD_TO_CART == 3)) ) {
    $show_top_submit_button = true;
  }
  if ( (($how_many > 0 and $show_submit == true and $featured_products_split->number_of_rows > 0) and (PRODUCT_FEATURED_LISTING_MULTIPLE_ADD_TO_CART >= 2)) ) {
    $show_bottom_submit_button = true;
  }

And up in the same area where $how_many = 0; was applied, could add:

Code:

$show_top_submit_button = false;
$show_bottom_submit_button = false;

The above "two" changes would resolve the reported issues noting that the first item is addressed in ZC 1.5.8 files.

Thank you very much mc,
I just applied BOTH changes on all 3 effected files using your directions:
includes/modules/pages/featured_products/header_php.php
includes/modules/pages/products_all/header_php.php
/includes/modules/pages/products_new/header_php.php

Will keep an eye out on error log and report back.

**rlexyd** · 14 Aug 2021, 11:07 PM

Seems to be going good, the 4th error log is no longer generated, Thank you mc

Now any advice you have re: the other 3 error logs?

**carlwhat** · 15 Aug 2021, 01:19 AM

Originally Posted by rlexyd

Seems to be going good, the 4th error log is no longer generated, Thank you mc

Now any advice you have re: the other 3 error logs?

you can change your fax line to:

PHP Code:


$fax = isset($_POST['fax']) ? zen_db_prepare_input($_POST['fax']) : '';

with regards to your dirkenhaus problem, you would need to post that whole file.

frankly, the handling of countries in ZC needs work. i run into problems with it all the time. your error is coming from the admin. if you look at the order class and the querying of the delivery array, country is NOT an array. see line 133:

https://github.com/zencart/zencart/b....php#L126-L134

but yet when we are in the cart, country is an array. look at line 400:

https://github.com/zencart/zencart/b....php#L390-L402

your payment class needs to account for that difference.

i do not use OPC, but the issue is with the server configuration, as The User-Agent header is optional. i would contact your host to ask them about that. in the interim, you could change line 86 as such:

PHP Code:


$user_agent = strtolower($_SERVER['HTTP_USER_AGENT'] ?? '');

best.

**rlexyd** · 15 Aug 2021, 02:30 AM

Hi Paul, thank you very much, will implement your suggestions today and report.

Please view the entire /includes/modules/payment/dirbankaus.php contents.

Code:

<?php
//
// +----------------------------------------------------------------------+
// |zen-cart Open Source E-commerce                                       |
// +----------------------------------------------------------------------+
// | Copyright (c) 2003 The zen-cart developers                           |
// |                                                                      |   
// | http://www.zen-cart.com/index.php                                    |   
// |                                                                      |   
// | Portions Copyright (c) 2003 osCommerce                               |
// +----------------------------------------------------------------------+
// | This source file is subject to version 2.0 of the GPL license,       |
// | that is bundled with this package in the file LICENSE, and is        |
// | available through the world-wide-web at the following url:           |
// | http://www.zen-cart.com/license/2_0.txt.                             |
// | If you did not receive a copy of the zen-cart license and are unable |
// | to obtain it through the world-wide-web, please send a note to       |
// | [email protected] so we can mail you a copy immediately.          |
// +----------------------------------------------------------------------+
// $Id: DIRBANKAUS.php 1106 2009-11-24 22:05:35Z CRYSTAL JONES $ modify from Auzbank of OZcommerce module by birdbrain
//


  class dirbankaus {
    var $code, $title, $description, $enabled;


// class constructor
    function __construct() {
      global $order;


      $this->code = 'dirbankaus';
      $this->title = MODULE_PAYMENT_DIRBANKAUS_TEXT_TITLE;
      $this->description = MODULE_PAYMENT_DIRBANKAUS_TEXT_DESCRIPTION;
      $this->email_footer = MODULE_PAYMENT_DIRBANKAUS_TEXT_EMAIL_FOOTER;
      $this->sort_order = MODULE_PAYMENT_DIRBANKAUS_SORT_ORDER;
      $this->enabled = ((MODULE_PAYMENT_DIRBANKAUS_STATUS == 'True') ? true : false);


      if ((int)MODULE_PAYMENT_DIRBANKAUS_ORDER_STATUS_ID > 0) {
        $this->order_status = MODULE_PAYMENT_DIRBANKAUS_ORDER_STATUS_ID;
      }


      if (is_object($order)) $this->update_status();
    }


// class methods
    function update_status() {
      global $order, $db;


      if ( ($this->enabled == true) && ((int)MODULE_PAYMENT_DIRBANKAUS_ZONE > 0) ) {
        $check_flag = false;
        $check = $db->Execute("select zone_id from " . TABLE_ZONES_TO_GEO_ZONES . " where geo_zone_id = '" . MODULE_PAYMENT_DIRBANKAUS_ZONE . "' and zone_country_id = '" . $order->delivery['country']['id'] . "' order by zone_id");
        while (!$check->EOF) {
          if ($check->fields['zone_id'] < 1) {
            $check_flag = true;
            break;
          } elseif ($check->fields['zone_id'] == $order->delivery['zone_id']) {
            $check_flag = true;
            break;
          }
          $check->MoveNext();
        }


        if ($check_flag == false) {
          $this->enabled = false;
        }
      }
// disable the module if the order only contains virtual products
      if ($this->enabled == true) {
        if ($order->content_type == 'virtual') {
          $this->enabled = false;
        }
      }
    }


    function javascript_validation() {
      return false;
    }


    function selection() {
      return array('id' => $this->code,
                   'module' => $this->title);
    }


    function pre_confirmation_check() {
      return false;
    }


    function confirmation() {
      return array('title' => MODULE_PAYMENT_DIRBANKAUS_TEXT_DESCRIPTION);
    }


    function process_button() {
      return false;
    }


    function before_process() {
      return false;
    }


    function after_order_create($order_id) {
      $this->email_footer = sprintf(MODULE_PAYMENT_DIRBANKAUS_TEXT_EMAIL_FOOTER, $order_id);
    }


    function after_process() {
      return false;
    }


    function get_error() {
      return false;
    }


    function check() {
      global $db;
      if (!isset($this->_check)) {
        $check_query = $db->Execute("select configuration_value from " . TABLE_CONFIGURATION . " where configuration_key = 'MODULE_PAYMENT_DIRBANKAUS_STATUS'");
        $this->_check = $check_query->RecordCount();
      }
      return $this->_check;
    }


    function install() {
      global $db;
     $db->Execute("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, date_added) values ('Enable Direct Bank Deposit/Cheque Module', 'MODULE_PAYMENT_DIRBANKAUS_STATUS', 'True', 'Do you want to accept Australian Bank Deposit payments, cheques and money orders?', '6', '1', 'zen_cfg_select_option(array(\'True\', \'False\'), ', now())");
     $db->Execute("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, use_function, set_function, date_added) values ('Payment Zone', 'MODULE_PAYMENT_DIRBANKAUS_ZONE', '0', 'If a zone is selected, only enable this payment method for that zone.', '6', '2', 'zen_get_zone_class_title', 'zen_cfg_pull_down_zone_classes(', now())");
     $db->Execute("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Sort order of display.', 'MODULE_PAYMENT_DIRBANKAUS_SORT_ORDER', '0', 'Sort order of display. Lowest is displayed first.', '6', '0', now())");
     $db->Execute("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('BSB Number', 'MODULE_PAYMENT_DIRBANKAUS_BSB', '000-000', 'BSB Number in the format 000-000', '6', '1', now());");
     $db->Execute("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Bank Account No.', 'MODULE_PAYMENT_DIRBANKAUS_ACCNUM', '12345678', 'Bank Account No.', '6', '1', now());");
     $db->Execute("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('PayID Email.', 'MODULE_PAYMENT_DIRBANKAUS_PAYID', 'PayID Email Address', 'PayID Email.', '6', '1', now());");
     $db->Execute("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Bank Account Name', 'MODULE_PAYMENT_DIRBANKAUS_ACCNAM', 'Joe Bloggs', 'Bank Account Name', '6', '1', now());");
     $db->Execute("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, date_added) values ('Bank Name', 'MODULE_PAYMENT_DIRBANKAUS_BANKNAM', 'The Bank', 'Bank Name', '6', '1', now());");
     $db->Execute("insert into " . TABLE_CONFIGURATION . " (configuration_title, configuration_key, configuration_value, configuration_description, configuration_group_id, sort_order, set_function, use_function, date_added) values ('Set Order Status', 'MODULE_PAYMENT_DIRBANKAUS_ORDER_STATUS_ID', '0', 'Set the status of orders made with this payment module to this value', '6', '0', 'zen_cfg_pull_down_order_statuses(', 'zen_get_order_status_name', now())");
  }


    function remove() {
      global $db;
      $db->Execute("delete from " . TABLE_CONFIGURATION . " where configuration_key in ('" . implode("', '", $this->keys()) . "')");
    }


    function keys() {
      return array('MODULE_PAYMENT_DIRBANKAUS_STATUS', 'MODULE_PAYMENT_DIRBANKAUS_ZONE', 'MODULE_PAYMENT_DIRBANKAUS_SORT_ORDER', 'MODULE_PAYMENT_DIRBANKAUS_BSB', 'MODULE_PAYMENT_DIRBANKAUS_ACCNUM', 'MODULE_PAYMENT_DIRBANKAUS_ACCNAM', 'MODULE_PAYMENT_DIRBANKAUS_PAYID', 'MODULE_PAYMENT_DIRBANKAUS_BANKNAM', 'MODULE_PAYMENT_DIRBANKAUS_ORDER_STATUS_ID');
    }
  }

Thread: Help with a couple of error logs (Create Account & Dirbankaus)

Thread Tools

Search Thread

Display

Help with a couple of error logs (Create Account & Dirbankaus)

Re: Help with a couple of error logs (Create Account & Dirbankaus)

Re: Help with a couple of error logs (Create Account & Dirbankaus)

Re: Help with a couple of error logs (Create Account & Dirbankaus)

Re: Help with a couple of error logs (Create Account & Dirbankaus)

Re: Help with a couple of error logs (Create Account & Dirbankaus)

Re: Help with a couple of error logs (Create Account & Dirbankaus)

Re: Help with a couple of error logs (Create Account & Dirbankaus)

Re: Help with a couple of error logs (Create Account & Dirbankaus)

Re: Help with a couple of error logs (Create Account & Dirbankaus)

Similar Threads

v155 Need help with a error logs

error in minimum state charactor create an account section HELP!

A couple issues with my Paypal account

help with 404 error: can't create account

Bookmarks

Bookmarks

Posting Permissions