Need help with an error log PHP Notice: Undefined offset: in shopping_cart.php

[rlexyd]

Just came across a few error logs generated only in the last 2 days, don't think I did anything different to the live site so not sure why they just started generating or if I should be concerned?!
I'm running 1.5.7c on PHP 7.4 with OPC installed on responsive classic template.

Searched everywhere and couldn't find anything other than this github link from torvista but I'm not sure what needs to be done?! https://github.com/zencart/zencart/issues/2894

Here is the full error log (I merged them together):

[27-Sep-2021 08:05:33 Australia/Sydney] Request URI: /index.php?main_page=shopping_cart&action=update_product, IP address: 106.00.00.00
#1  shoppingCart->in_cart_product_mixed_changed() called at [/includes/classes/shopping_cart.php:1731]
#2  shoppingCart->actionUpdateProduct() called at [/includes/main_cart_actions.php:37]
#3  require(/includes/main_cart_actions.php) called at [/includes/init_includes/init_cart_handler.php:44]
#4  require_once(/includes/init_includes/init_cart_handler.php) called at [/includes/autoload_func.php:37]
#5  require(/includes/autoload_func.php) called at [/includes/application_top.php:222]
#6  require(/includes/application_top.php) called at [/index.php:25]
--> PHP Notice: Undefined offset: 68 in /includes/classes/shopping_cart.php on line 2556.
--> PHP Notice: Undefined offset: 66 in /includes/classes/shopping_cart.php on line 2555.
--> PHP Notice: Undefined offset: 38 in /includes/classes/shopping_cart.php on line 1737.
--> PHP Notice: Undefined offset: 14 in /includes/classes/shopping_cart.php on line 2555.
--> PHP Notice: Undefined offset: 14 in /includes/classes/shopping_cart.php on line 2556.

Below is the corresponding lines:

    $changed_array = array(
         'state'=>false,
         'changed' => $product_changed,
Line 2555:          'total_change' => $product_total_change[$pr_id],
Line 2556:          'last_changed' => $product_last_changed[$pr_id],
         'increase' => $product_increase,
         'decrease' => $product_decrease,
       );

[swguy]

Turn off notices. This is not worth your while.

[rlexyd]

Turn off notices. This is not worth your while.

Ok Scott, if you say so.
Can you please direct me on how to turn off notices for this particular notice?
Also, any idea why this started generating all of a sudden but wasn't for the last few months on this new website?
I'm wondering it it was something I did that is causing this but can't think of what I have done?!

[swguy]

Normally notices *are* off. If you turned them on, you might have installed the Report All Errors plugin, which you can dial back to not show notices (only warnings, errors, etc.)

https://www.zen-cart.com/downloads.php?do=file&id=1792

Or perhaps you modified includes/extra_configures/enable_error_logging.php ?

[swguy]

Oddly enough, someone else reported this in Github Issues today. https://github.com/zencart/zencart/issues/4466

[rlexyd]

That is odd indeed, not sure what's with that.
Ok, I added the below code in /includes/classes/shopping_cart.php on line 2552 and commented out line 2555/2556, is this correct?

if (isset($product_total_change[$pr_id])) {
     $ changed_array['total_change'] = $product_total_change[$pr_id]; 
}
if (isset($product_last_changed[$pr_id])) {
     $ changed_array['last_changed'] = $product_last_changed[$pr_id]; 
}
         $changed_array = array(
         'state'=>false,
         'changed' => $product_changed,
//         'total_change' => $product_total_change[$pr_id],
//         'last_changed' => $product_last_changed[$pr_id],
         'increase' => $product_increase,
         'decrease' => $product_decrease,
       );

[swguy]

No this is wrong. The two isset blocks need to be *below* the array definition.

[rlexyd]

No this is wrong. The two isset blocks need to be *below* the array definition.

Thanks again Scott, I moved it to under the code.

    $changed_array = array(
         'state'=>false,
         'changed' => $product_changed,
//         'total_change' => $product_total_change[$pr_id],
//         'last_changed' => $product_last_changed[$pr_id],
         'increase' => $product_increase,
         'decrease' => $product_decrease,
       );
       
    if (isset($product_total_change[$pr_id])) {
     $ changed_array['total_change'] = $product_total_change[$pr_id]; 
      }
    if (isset($product_last_changed[$pr_id])) {
     $ changed_array['last_changed'] = $product_last_changed[$pr_id]; 
      }