Featured Products - choosing/deleting of 10th item on first page error / bug?

[swguy]

Carl, would you mind putting those two changes into a PR for 1.5.7 just in case there's a "d" release? thanks.

[mc12345678]

Carl, would you mind putting those two changes into a PR for 1.5.7 just in case there's a "d" release? thanks.

Perhaps saving some peace of mind and guessing that carl(what) from going what?! :) to use a line from a classic movie: my name is not Shirley...

Perhaps easier for clarity to identify what "2" changes are being suggested. carlwhat suggested in two places to remove the page reassignment. Another "set" of 2 suggestions was to comment out the page reassignments and to do remove the possibility of revising $_GET parameters... I'm sure there are other suggestions in carlwhat's posts that one might ponder upon.

[carlwhat]

Carl, would you mind putting those two changes into a PR for 1.5.7 just in case there's a "d" release? thanks.

i have a few outstanding PRs on the repo. at some point when activity resumes there, i would have no problem doing a PR.

Perhaps saving some peace of mind and guessing that carl(what) from going what?!

[mc12345678]

FYI, upon further review, this appears to be an issue with the following admin pages (reported with a mix of ZC 1.5.7 and 1.5.8 files affected based on research/discovery):
banner_manager
category_product_listing
customer_groups (v1.5.8+)
customers
ez_pages (Feature "recently" removed from 1.5.8 without identifying a reason or that it happened)
geo_zones
group_pricing
manufacturers (Feature "recently" removed from 1.5.8 without identifying a reason or that it happened)
orders
reviews (Feature "recently" removed from 1.5.8 without identifying a reason or that it happened)

This was identified by performing a search on $check_count on the github repo then verifying the same $check_count = 1; in the code preceding the splitPageResults call. Then at least with orders, it was confirmed by attempting to access the last record of the first page when the number of orders exceeded or equaled the number to be displayed per page.

[swguy]

Thanks for doing this investigation. Noted on bug list in Github.