Upgrade to PHP 7.2 error

**nicksab** · 15 Dec 2021, 01:03 AM

Hello,

I am trying to fix a few errors so i can switch my hosting to PHP 7.2. I am currently stuck on a PHP 5.6 until i solved the following errors:

[14-Dec-2021 14:20:15 America/Los_Angeles] Request URI: /all-flowers/christmas-spirit-in-a-wood-box, IP address: 66.249.79.112
#1 zen_categories_ul_generator->buildBranch() called at [/home/zch1akhw6q3m/public_html/includes/classes/categories_ul_generator.php:85]
#2 zen_categories_ul_generator->buildTree() called at [/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_mega_menu.php:56]
#3 require(/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_mega_menu.php) called at [/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_header.php:200]
#4 require(/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_header.php) called at [/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_main_page.php:119]
#5 require(/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_main_page.php) called at [/home/zch1akhw6q3m/public_html/index.php:97]
--> PHP Warning: A non-numeric value encountered in /home/zch1akhw6q3m/public_html/includes/classes/categories_ul_generator.php on line 58.

[14-Dec-2021 14:20:15 America/Los_Angeles] Request URI: /all-flowers/christmas-spirit-in-a-wood-box, IP address: 66.249.79.112
#1 zen_categories_ul_generator->buildBranch() called at [/home/zch1akhw6q3m/public_html/includes/classes/categories_ul_generator.php:85]
#2 zen_categories_ul_generator->buildTree() called at [/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_mega_menu.php:56]
#3 require(/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_mega_menu.php) called at [/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_header.php:200]
#4 require(/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_header.php) called at [/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_main_page.php:119]
#5 require(/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_main_page.php) called at [/home/zch1akhw6q3m/public_html/index.php:97]
--> PHP Warning: A non-numeric value encountered in /home/zch1akhw6q3m/public_html/includes/classes/categories_ul_generator.php on line 73.

[14-Dec-2021 14:20:15 America/Los_Angeles] Request URI: /all-flowers/christmas-spirit-in-a-wood-box, IP address: 66.249.79.112
#1 sizeof() called at [/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_mega_menu.php:199]
#2 require(/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_mega_menu.php) called at [/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_header.php:200]
#3 require(/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_header.php) called at [/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_main_page.php:119]
#4 require(/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_main_page.php) called at [/home/zch1akhw6q3m/public_html/index.php:97]
--> PHP Warning: sizeof(): Parameter must be an array or an object that implements Countable in /home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_mega_menu.php on line 199.

Here is the mentioned line in the different file at the corredsponding line:

/categories_ul_generator.php on line 58.

PHP Code:


      $result = sprintf($this->parent_group_start_string, ($submenu==true) ? ' class="level'. ($level+1) . '"' : '' );

/categories_ul_generator.php on line 73.

PHP Code:


                    $result .= $this->buildBranch($category_id, $level+1, $submenu, $category_link . '_');

/tpl_mega_menu.php line 199

PHP Code:


                for ($i=0;$i<sizeof($manufacturer_sidebox_array);$i++) {

Anyone can help me fix these please

Thank you in advance

**mc12345678** · 15 Dec 2021, 01:15 AM

To address the categories_ul_generator.php file issue, take a look at what is done at this specific line of the distributed version of that file for ZC 1.5.6. The line number in the below file/link is 58 which in your file is going to be a lower numbered line:https://github.com/zencart/zencart/b...erator.php#L58

As far as the mega_menu file, basically it seems there is a condition before that line that is preventing $manufacturer_sidebox_array from actually being an array.

There are things that could be done just before that line to "cheat" ones way through, but a real fix would be to go back up in the code to ensure that the variable is either first declared an empty array or otherwise assigned to an array type variable.

I would not be surprised if the issue is flushed out more in one of the associated forum threads for that template or one similar to it.

**nicksab** · 15 Dec 2021, 02:05 AM

Originally Posted by mc12345678

To address the categories_ul_generator.php file issue, take a look at what is done at this specific line of the distributed version of that file for ZC 1.5.6. The line number in the below file/link is 58 which in your file is going to be a lower numbered line:https://github.com/zencart/zencart/b...erator.php#L58

As far as the mega_menu file, basically it seems there is a condition before that line that is preventing $manufacturer_sidebox_array from actually being an array.

There are things that could be done just before that line to "cheat" ones way through, but a real fix would be to go back up in the code to ensure that the variable is either first declared an empty array or otherwise assigned to an array type variable.

I would not be surprised if the issue is flushed out more in one of the associated forum threads for that template or one similar to it.

Thank you so much for the fast reply.

I replaced my version of category_ul_generator.php with the original from ZC 1.5.6 and the related errors are gone for now.

I am still facing tpl_mega_menu error:

[14-Dec-2021 16:56:46 America/Los_Angeles] Request URI: /christmas-flowers-and-centerpieces, IP address: 76.103.115.109
#1 sizeof() called at [/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_mega_menu.php:199]
#2 require(/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_mega_menu.php) called at [/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_header.php:200]
#3 require(/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_header.php) called at [/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_main_page.php:119]
#4 require(/home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_main_page.php) called at [/home/zch1akhw6q3m/public_html/index.php:97]
--> PHP Warning: sizeof(): Parameter must be an array or an object that implements Countable in /home/zch1akhw6q3m/public_html/includes/templates/Royal_Fleur/common/tpl_mega_menu.php on line 199.

I am not a coder or expert in any way. I checked the related thread for pure css mega menu but no luck regarding this error.

Any ideas how to go about it?

Thank you again for your help

Here is the most of the related code i believe:

PHP Code:


     </li><!-- eof quick links -->
        

     <li class="manufacturers-li"><a href="<?php echo zen_href_link(FILENAME_DEFAULT); ?>" class="drop"><?php echo HEADER_TITLE_MANUFACTURERS; ?></a><!--bof shop by brand   -->
            <div class="dropdown_1column">
                <div class="col_1 firstcolumn">

              <ul >
               <?php
        
  $show_manufacturers= true;

// for large lists of manufacturers uncomment this section
/*
  if (($_GET['main_page']==FILENAME_DEFAULT and ($_GET['cPath'] == '' or $_GET['cPath'] == 0)) or  ($request_type == 'SSL')) {
    $show_manufacturers= false;
  } else {
    $show_manufacturers= true;
  }
*/

// Set to true to display manufacturers images in place of names
define('DISPLAY_MANUFACTURERS_IMAGES',false);

if ($show_manufacturers) {

// only check products if requested - this may slow down the processing of the manufacturers sidebox
  if (PRODUCTS_MANUFACTURERS_STATUS == '1') {
    $manufacturer_sidebox_query = "select distinct m.manufacturers_id, m.manufacturers_name, m.manufacturers_image
                            from " . TABLE_MANUFACTURERS . " m
                            left join " . TABLE_PRODUCTS . " p on m.manufacturers_id = p.manufacturers_id
                            where m.manufacturers_id = p.manufacturers_id and p.products_status= 1
                            order by manufacturers_name";
  } else {
    $manufacturer_sidebox_query = "select m.manufacturers_id, m.manufacturers_name, m.manufacturers_image
                            from " . TABLE_MANUFACTURERS . " m
                            order by manufacturers_name";
  }

  $manufacturer_sidebox = $db->Execute($manufacturer_sidebox_query);

  if ($manufacturer_sidebox->RecordCount()>0) {
    $number_of_rows = $manufacturer_sidebox->RecordCount()+1;

// Display a list
    $manufacturer_sidebox_array = array();
//        kuroi: commented out to avoid starting list with text scrolling list entries such as "reset" and "please select"
//    if (!isset($_GET['manufacturers_id']) || $_GET['manufacturers_id'] == '' ) {
//      $manufacturer_sidebox_array[] = array('id' => '', 'text' => PULL_DOWN_ALL);
//    } else {
//      $manufacturer_sidebox_array[] = array('id' => '', 'text' => PULL_DOWN_MANUFACTURERS);
//    }

    while (!$manufacturer_sidebox->EOF) {
      $manufacturer_sidebox_name = ((strlen($manufacturer_sidebox->fields['manufacturers_name']) > MAX_DISPLAY_MANUFACTURER_NAME_LEN) ? substr($manufacturer_sidebox->fields['manufacturers_name'], 0, MAX_DISPLAY_MANUFACTURER_NAME_LEN) . '..' : $manufacturer_sidebox->fields['manufacturers_name']);
      $manufacturer_sidebox_image = $manufacturer_sidebox->fields['manufacturers_image'];
      $manufacturer_sidebox_array[] =
        array('id' => $manufacturer_sidebox->fields['manufacturers_id'],
              'text' => DISPLAY_MANUFACTURERS_IMAGES ?
                zen_image(DIR_WS_IMAGES . $manufacturer_sidebox_image, $manufacturer_sidebox_name) :
                $manufacturer_sidebox_name);
      $manufacturer_sidebox->MoveNext();
    }
      
  }
} // $show_manufacturers
                for ($i=0;$i<sizeof($manufacturer_sidebox_array);$i++) {
      $content = '';
      $content .= '<li ><a class="hide" href="' . zen_href_link(FILENAME_DEFAULT, 'manufacturers_id=' . $manufacturer_sidebox_array[$i]['id']) . '">';
      $content .= $manufacturer_sidebox_array[$i]['text'];
      $content .= '</a></li>' . "\n";
      echo $content;
    }
?>
            </ul>
        </div>
            </div>
        </li><!-- eof shop by brand    -->

**nicksab** · 15 Dec 2021, 03:06 AM

I went ahead and deleted that whole section of code since i was not displaying the manufacturers anyway.

I understand it is a bit of " butcher way "of doing but the site seems to be working fine so far.

It is at royal-fleur.com runing under PHP 7.3. No error logged so far.

Thank you for helping me

**mc12345678** · 15 Dec 2021, 03:52 AM

Originally Posted by nicksab

Thank you so much for the fast reply.

I replaced my version of category_ul_generator.php with the original from ZC 1.5.6 and the related errors are gone for now.

I am still facing tpl_mega_menu error:

I am not a coder or expert in any way. I checked the related thread for pure css mega menu but no luck regarding this error.

Any ideas how to go about it?

Thank you again for your help

Here is the most of the related code i believe:

PHP Code:


     </li><!-- eof quick links -->
        

     <li class="manufacturers-li"><a href="<?php echo zen_href_link(FILENAME_DEFAULT); ?>" class="drop"><?php echo HEADER_TITLE_MANUFACTURERS; ?></a><!--bof shop by brand   -->
            <div class="dropdown_1column">
                <div class="col_1 firstcolumn">

              <ul >
               <?php
        
  $show_manufacturers= true;

// for large lists of manufacturers uncomment this section
/*
  if (($_GET['main_page']==FILENAME_DEFAULT and ($_GET['cPath'] == '' or $_GET['cPath'] == 0)) or  ($request_type == 'SSL')) {
    $show_manufacturers= false;
  } else {
    $show_manufacturers= true;
  }
*/

// Set to true to display manufacturers images in place of names
define('DISPLAY_MANUFACTURERS_IMAGES',false);

if ($show_manufacturers) {

// only check products if requested - this may slow down the processing of the manufacturers sidebox
  if (PRODUCTS_MANUFACTURERS_STATUS == '1') {
    $manufacturer_sidebox_query = "select distinct m.manufacturers_id, m.manufacturers_name, m.manufacturers_image
                            from " . TABLE_MANUFACTURERS . " m
                            left join " . TABLE_PRODUCTS . " p on m.manufacturers_id = p.manufacturers_id
                            where m.manufacturers_id = p.manufacturers_id and p.products_status= 1
                            order by manufacturers_name";
  } else {
    $manufacturer_sidebox_query = "select m.manufacturers_id, m.manufacturers_name, m.manufacturers_image
                            from " . TABLE_MANUFACTURERS . " m
                            order by manufacturers_name";
  }

  $manufacturer_sidebox = $db->Execute($manufacturer_sidebox_query);

  if ($manufacturer_sidebox->RecordCount()>0) {
    $number_of_rows = $manufacturer_sidebox->RecordCount()+1;

// Display a list
    $manufacturer_sidebox_array = array();
//        kuroi: commented out to avoid starting list with text scrolling list entries such as "reset" and "please select"
//    if (!isset($_GET['manufacturers_id']) || $_GET['manufacturers_id'] == '' ) {
//      $manufacturer_sidebox_array[] = array('id' => '', 'text' => PULL_DOWN_ALL);
//    } else {
//      $manufacturer_sidebox_array[] = array('id' => '', 'text' => PULL_DOWN_MANUFACTURERS);
//    }

    while (!$manufacturer_sidebox->EOF) {
      $manufacturer_sidebox_name = ((strlen($manufacturer_sidebox->fields['manufacturers_name']) > MAX_DISPLAY_MANUFACTURER_NAME_LEN) ? substr($manufacturer_sidebox->fields['manufacturers_name'], 0, MAX_DISPLAY_MANUFACTURER_NAME_LEN) . '..' : $manufacturer_sidebox->fields['manufacturers_name']);
      $manufacturer_sidebox_image = $manufacturer_sidebox->fields['manufacturers_image'];
      $manufacturer_sidebox_array[] =
        array('id' => $manufacturer_sidebox->fields['manufacturers_id'],
              'text' => DISPLAY_MANUFACTURERS_IMAGES ?
                zen_image(DIR_WS_IMAGES . $manufacturer_sidebox_image, $manufacturer_sidebox_name) :
                $manufacturer_sidebox_name);
      $manufacturer_sidebox->MoveNext();
    }
      
  }
} // $show_manufacturers
                for ($i=0;$i<sizeof($manufacturer_sidebox_array);$i++) {
      $content = '';
      $content .= '<li ><a class="hide" href="' . zen_href_link(FILENAME_DEFAULT, 'manufacturers_id=' . $manufacturer_sidebox_array[$i]['id']) . '">';
      $content .= $manufacturer_sidebox_array[$i]['text'];
      $content .= '</a></li>' . "\n";
      echo $content;
    }
?>
            </ul>
        </div>
            </div>
        </li><!-- eof shop by brand    -->

Showing this using [CODE][/CODE] tags instead of [PHP][/PHP] so that I can use my own color coding changing:

Code:

     </li><!-- eof quick links -->
        

     <li class="manufacturers-li"><a href="<?php echo zen_href_link(FILENAME_DEFAULT); ?>" class="drop"><?php echo HEADER_TITLE_MANUFACTURERS; ?></a><!--bof shop by brand   -->
            <div class="dropdown_1column">
                <div class="col_1 firstcolumn">

              <ul >
               <?php
        
  $show_manufacturers= true;

// for large lists of manufacturers uncomment this section
/*
  if (($_GET['main_page']==FILENAME_DEFAULT and ($_GET['cPath'] == '' or $_GET['cPath'] == 0)) or  ($request_type == 'SSL')) {
    $show_manufacturers= false;
  } else {
    $show_manufacturers= true;
  }
*/

// Set to true to display manufacturers images in place of names
define('DISPLAY_MANUFACTURERS_IMAGES',false);

if ($show_manufacturers) {

// only check products if requested - this may slow down the processing of the manufacturers sidebox
  if (PRODUCTS_MANUFACTURERS_STATUS == '1') {
    $manufacturer_sidebox_query = "select distinct m.manufacturers_id, m.manufacturers_name, m.manufacturers_image
                            from " . TABLE_MANUFACTURERS . " m
                            left join " . TABLE_PRODUCTS . " p on m.manufacturers_id = p.manufacturers_id
                            where m.manufacturers_id = p.manufacturers_id and p.products_status= 1
                            order by manufacturers_name";
  } else {
    $manufacturer_sidebox_query = "select m.manufacturers_id, m.manufacturers_name, m.manufacturers_image
                            from " . TABLE_MANUFACTURERS . " m
                            order by manufacturers_name";
  }

  $manufacturer_sidebox = $db->Execute($manufacturer_sidebox_query);

  if ($manufacturer_sidebox->RecordCount()>0) {
    $number_of_rows = $manufacturer_sidebox->RecordCount()+1;

// Display a list
    $manufacturer_sidebox_array = array(); // This is being copied "up" to outside this nexted "if" (if show... if >0).
//        kuroi: commented out to avoid starting list with text scrolling list entries such as "reset" and "please select"
//    if (!isset($_GET['manufacturers_id']) || $_GET['manufacturers_id'] == '' ) {
//      $manufacturer_sidebox_array[] = array('id' => '', 'text' => PULL_DOWN_ALL);
//    } else {
//      $manufacturer_sidebox_array[] = array('id' => '', 'text' => PULL_DOWN_MANUFACTURERS);
//    }

    while (!$manufacturer_sidebox->EOF) {
      $manufacturer_sidebox_name = ((strlen($manufacturer_sidebox->fields['manufacturers_name']) > MAX_DISPLAY_MANUFACTURER_NAME_LEN) ? substr($manufacturer_sidebox->fields['manufacturers_name'], 0, MAX_DISPLAY_MANUFACTURER_NAME_LEN) . '..' : $manufacturer_sidebox->fields['manufacturers_name']);
      $manufacturer_sidebox_image = $manufacturer_sidebox->fields['manufacturers_image'];
      $manufacturer_sidebox_array[] =
        array('id' => $manufacturer_sidebox->fields['manufacturers_id'],
              'text' => DISPLAY_MANUFACTURERS_IMAGES ?
                zen_image(DIR_WS_IMAGES . $manufacturer_sidebox_image, $manufacturer_sidebox_name) :
                $manufacturer_sidebox_name);
      $manufacturer_sidebox->MoveNext();
    }
      
  }
} // $show_manufacturers
                for ($i=0;$i<sizeof($manufacturer_sidebox_array);$i++) {
      $content = '';
      $content .= '<li ><a class="hide" href="' . zen_href_link(FILENAME_DEFAULT, 'manufacturers_id=' . $manufacturer_sidebox_array[$i]['id']) . '">';
      $content .= $manufacturer_sidebox_array[$i]['text'];
      $content .= '</a></li>' . "\n";
      echo $content;
    }
?>
            </ul>
        </div>
            </div>
        </li><!-- eof shop by brand    -->

TO:

Code:

     </li><!-- eof quick links -->
        

     <li class="manufacturers-li"><a href="<?php echo zen_href_link(FILENAME_DEFAULT); ?>" class="drop"><?php echo HEADER_TITLE_MANUFACTURERS; ?></a><!--bof shop by brand   -->
            <div class="dropdown_1column">
                <div class="col_1 firstcolumn">

              <ul >
               <?php
        
  $show_manufacturers= true;

// for large lists of manufacturers uncomment this section
/*
  if (($_GET['main_page']==FILENAME_DEFAULT and ($_GET['cPath'] == '' or $_GET['cPath'] == 0)) or  ($request_type == 'SSL')) {
    $show_manufacturers= false;
  } else {
    $show_manufacturers= true;
  }
*/

// Set to true to display manufacturers images in place of names
define('DISPLAY_MANUFACTURERS_IMAGES',false);

if (empty($manufacturer_sidebox_array)) { // Allows value to be set ahead of executing this code.
  $manufacturer_sidebox_array = array(); // This ensures that the variable is always declared as an array even if not showing manufacturers.
}

if ($show_manufacturers) {

// only check products if requested - this may slow down the processing of the manufacturers sidebox
  if (PRODUCTS_MANUFACTURERS_STATUS == '1') {
    $manufacturer_sidebox_query = "select distinct m.manufacturers_id, m.manufacturers_name, m.manufacturers_image
                            from " . TABLE_MANUFACTURERS . " m
                            left join " . TABLE_PRODUCTS . " p on m.manufacturers_id = p.manufacturers_id
                            where m.manufacturers_id = p.manufacturers_id and p.products_status= 1
                            order by manufacturers_name";
  } else {
    $manufacturer_sidebox_query = "select m.manufacturers_id, m.manufacturers_name, m.manufacturers_image
                            from " . TABLE_MANUFACTURERS . " m
                            order by manufacturers_name";
  }

  $manufacturer_sidebox = $db->Execute($manufacturer_sidebox_query);

  if ($manufacturer_sidebox->RecordCount()>0) {
    $number_of_rows = $manufacturer_sidebox->RecordCount()+1;

// Display a list
    $manufacturer_sidebox_array = array();
//        kuroi: commented out to avoid starting list with text scrolling list entries such as "reset" and "please select"
//    if (!isset($_GET['manufacturers_id']) || $_GET['manufacturers_id'] == '' ) {
//      $manufacturer_sidebox_array[] = array('id' => '', 'text' => PULL_DOWN_ALL);
//    } else {
//      $manufacturer_sidebox_array[] = array('id' => '', 'text' => PULL_DOWN_MANUFACTURERS);
//    }

    while (!$manufacturer_sidebox->EOF) {
      $manufacturer_sidebox_name = ((strlen($manufacturer_sidebox->fields['manufacturers_name']) > MAX_DISPLAY_MANUFACTURER_NAME_LEN) ? substr($manufacturer_sidebox->fields['manufacturers_name'], 0, MAX_DISPLAY_MANUFACTURER_NAME_LEN) . '..' : $manufacturer_sidebox->fields['manufacturers_name']);
      $manufacturer_sidebox_image = $manufacturer_sidebox->fields['manufacturers_image'];
      $manufacturer_sidebox_array[] =
        array('id' => $manufacturer_sidebox->fields['manufacturers_id'],
              'text' => DISPLAY_MANUFACTURERS_IMAGES ?
                zen_image(DIR_WS_IMAGES . $manufacturer_sidebox_image, $manufacturer_sidebox_name) :
                $manufacturer_sidebox_name);
      $manufacturer_sidebox->MoveNext();
    }
      
  }
} // $show_manufacturers
                for ($i=0;$i<sizeof($manufacturer_sidebox_array);$i++) {
      $content = '';
      $content .= '<li ><a class="hide" href="' . zen_href_link(FILENAME_DEFAULT, 'manufacturers_id=' . $manufacturer_sidebox_array[$i]['id']) . '">';
      $content .= $manufacturer_sidebox_array[$i]['text'];
      $content .= '</a></li>' . "\n";
      echo $content;
    }
?>
            </ul>
        </div>
            </div>
        </li><!-- eof shop by brand    -->

**torvista** · 15 Dec 2021, 02:36 PM

As a general rule for any php version complaining like this, they have already been fixed at some point: my site is on php 8.13.
You need to look at the development versions of the same file on GitHub, most files are mostly the same.

**nicksab** · 16 Dec 2021, 12:24 AM

Originally Posted by mc12345678

Showing this using [CODE][/CODE] tags instead of [PHP][/PHP] so that I can use my own color coding changing:

Code:

     </li><!-- eof quick links -->
        

     <li class="manufacturers-li"><a href="<?php echo zen_href_link(FILENAME_DEFAULT); ?>" class="drop"><?php echo HEADER_TITLE_MANUFACTURERS; ?></a><!--bof shop by brand   -->
            <div class="dropdown_1column">
                <div class="col_1 firstcolumn">

              <ul >
               <?php
        
  $show_manufacturers= true;

// for large lists of manufacturers uncomment this section
/*
  if (($_GET['main_page']==FILENAME_DEFAULT and ($_GET['cPath'] == '' or $_GET['cPath'] == 0)) or  ($request_type == 'SSL')) {
    $show_manufacturers= false;
  } else {
    $show_manufacturers= true;
  }
*/

// Set to true to display manufacturers images in place of names
define('DISPLAY_MANUFACTURERS_IMAGES',false);

if ($show_manufacturers) {

// only check products if requested - this may slow down the processing of the manufacturers sidebox
  if (PRODUCTS_MANUFACTURERS_STATUS == '1') {
    $manufacturer_sidebox_query = "select distinct m.manufacturers_id, m.manufacturers_name, m.manufacturers_image
                            from " . TABLE_MANUFACTURERS . " m
                            left join " . TABLE_PRODUCTS . " p on m.manufacturers_id = p.manufacturers_id
                            where m.manufacturers_id = p.manufacturers_id and p.products_status= 1
                            order by manufacturers_name";
  } else {
    $manufacturer_sidebox_query = "select m.manufacturers_id, m.manufacturers_name, m.manufacturers_image
                            from " . TABLE_MANUFACTURERS . " m
                            order by manufacturers_name";
  }

  $manufacturer_sidebox = $db->Execute($manufacturer_sidebox_query);

  if ($manufacturer_sidebox->RecordCount()>0) {
    $number_of_rows = $manufacturer_sidebox->RecordCount()+1;

// Display a list
    $manufacturer_sidebox_array = array(); // This is being copied "up" to outside this nexted "if" (if show... if >0).
//        kuroi: commented out to avoid starting list with text scrolling list entries such as "reset" and "please select"
//    if (!isset($_GET['manufacturers_id']) || $_GET['manufacturers_id'] == '' ) {
//      $manufacturer_sidebox_array[] = array('id' => '', 'text' => PULL_DOWN_ALL);
//    } else {
//      $manufacturer_sidebox_array[] = array('id' => '', 'text' => PULL_DOWN_MANUFACTURERS);
//    }

    while (!$manufacturer_sidebox->EOF) {
      $manufacturer_sidebox_name = ((strlen($manufacturer_sidebox->fields['manufacturers_name']) > MAX_DISPLAY_MANUFACTURER_NAME_LEN) ? substr($manufacturer_sidebox->fields['manufacturers_name'], 0, MAX_DISPLAY_MANUFACTURER_NAME_LEN) . '..' : $manufacturer_sidebox->fields['manufacturers_name']);
      $manufacturer_sidebox_image = $manufacturer_sidebox->fields['manufacturers_image'];
      $manufacturer_sidebox_array[] =
        array('id' => $manufacturer_sidebox->fields['manufacturers_id'],
              'text' => DISPLAY_MANUFACTURERS_IMAGES ?
                zen_image(DIR_WS_IMAGES . $manufacturer_sidebox_image, $manufacturer_sidebox_name) :
                $manufacturer_sidebox_name);
      $manufacturer_sidebox->MoveNext();
    }
      
  }
} // $show_manufacturers
                for ($i=0;$i<sizeof($manufacturer_sidebox_array);$i++) {
      $content = '';
      $content .= '<li ><a class="hide" href="' . zen_href_link(FILENAME_DEFAULT, 'manufacturers_id=' . $manufacturer_sidebox_array[$i]['id']) . '">';
      $content .= $manufacturer_sidebox_array[$i]['text'];
      $content .= '</a></li>' . "\n";
      echo $content;
    }
?>
            </ul>
        </div>
            </div>
        </li><!-- eof shop by brand    -->

TO:

Code:

     </li><!-- eof quick links -->
        

     <li class="manufacturers-li"><a href="<?php echo zen_href_link(FILENAME_DEFAULT); ?>" class="drop"><?php echo HEADER_TITLE_MANUFACTURERS; ?></a><!--bof shop by brand   -->
            <div class="dropdown_1column">
                <div class="col_1 firstcolumn">

              <ul >
               <?php
        
  $show_manufacturers= true;

// for large lists of manufacturers uncomment this section
/*
  if (($_GET['main_page']==FILENAME_DEFAULT and ($_GET['cPath'] == '' or $_GET['cPath'] == 0)) or  ($request_type == 'SSL')) {
    $show_manufacturers= false;
  } else {
    $show_manufacturers= true;
  }
*/

// Set to true to display manufacturers images in place of names
define('DISPLAY_MANUFACTURERS_IMAGES',false);

if (empty($manufacturer_sidebox_array)) { // Allows value to be set ahead of executing this code.
  $manufacturer_sidebox_array = array(); // This ensures that the variable is always declared as an array even if not showing manufacturers.
}

if ($show_manufacturers) {

// only check products if requested - this may slow down the processing of the manufacturers sidebox
  if (PRODUCTS_MANUFACTURERS_STATUS == '1') {
    $manufacturer_sidebox_query = "select distinct m.manufacturers_id, m.manufacturers_name, m.manufacturers_image
                            from " . TABLE_MANUFACTURERS . " m
                            left join " . TABLE_PRODUCTS . " p on m.manufacturers_id = p.manufacturers_id
                            where m.manufacturers_id = p.manufacturers_id and p.products_status= 1
                            order by manufacturers_name";
  } else {
    $manufacturer_sidebox_query = "select m.manufacturers_id, m.manufacturers_name, m.manufacturers_image
                            from " . TABLE_MANUFACTURERS . " m
                            order by manufacturers_name";
  }

  $manufacturer_sidebox = $db->Execute($manufacturer_sidebox_query);

  if ($manufacturer_sidebox->RecordCount()>0) {
    $number_of_rows = $manufacturer_sidebox->RecordCount()+1;

// Display a list
    $manufacturer_sidebox_array = array();
//        kuroi: commented out to avoid starting list with text scrolling list entries such as "reset" and "please select"
//    if (!isset($_GET['manufacturers_id']) || $_GET['manufacturers_id'] == '' ) {
//      $manufacturer_sidebox_array[] = array('id' => '', 'text' => PULL_DOWN_ALL);
//    } else {
//      $manufacturer_sidebox_array[] = array('id' => '', 'text' => PULL_DOWN_MANUFACTURERS);
//    }

    while (!$manufacturer_sidebox->EOF) {
      $manufacturer_sidebox_name = ((strlen($manufacturer_sidebox->fields['manufacturers_name']) > MAX_DISPLAY_MANUFACTURER_NAME_LEN) ? substr($manufacturer_sidebox->fields['manufacturers_name'], 0, MAX_DISPLAY_MANUFACTURER_NAME_LEN) . '..' : $manufacturer_sidebox->fields['manufacturers_name']);
      $manufacturer_sidebox_image = $manufacturer_sidebox->fields['manufacturers_image'];
      $manufacturer_sidebox_array[] =
        array('id' => $manufacturer_sidebox->fields['manufacturers_id'],
              'text' => DISPLAY_MANUFACTURERS_IMAGES ?
                zen_image(DIR_WS_IMAGES . $manufacturer_sidebox_image, $manufacturer_sidebox_name) :
                $manufacturer_sidebox_name);
      $manufacturer_sidebox->MoveNext();
    }
      
  }
} // $show_manufacturers
                for ($i=0;$i<sizeof($manufacturer_sidebox_array);$i++) {
      $content = '';
      $content .= '<li ><a class="hide" href="' . zen_href_link(FILENAME_DEFAULT, 'manufacturers_id=' . $manufacturer_sidebox_array[$i]['id']) . '">';
      $content .= $manufacturer_sidebox_array[$i]['text'];
      $content .= '</a></li>' . "\n";
      echo $content;
    }
?>
            </ul>
        </div>
            </div>
        </li><!-- eof shop by brand    -->

Thank you. It worked perfect.

**nicksab** · 16 Dec 2021, 12:26 AM

Originally Posted by torvista

As a general rule for any php version complaining like this, they have already been fixed at some point: my site is on php 8.13.
You need to look at the development versions of the same file on GitHub, most files are mostly the same.

Thanks for the tip. My site is using some old plugin which haven't been updated for awhile in the plugin section.

I am slowly getting the habit of going on github instead but not all the plugin are easy to find.

Thread: Upgrade to PHP 7.2 error

Thread Tools

Search Thread

Display

Upgrade to PHP 7.2 error

Re: Upgrade to PHP 7.2 error

Re: Upgrade to PHP 7.2 error

Re: Upgrade to PHP 7.2 error

Re: Upgrade to PHP 7.2 error

Re: Upgrade to PHP 7.2 error

Re: Upgrade to PHP 7.2 error

Re: Upgrade to PHP 7.2 error

Similar Threads

PHP Fatal error: 1366:Incorrect decimal value after upgrade to 1.5.6

v156 Upgrade to 1.5.6b PHP Fatal error PayPal IPN

v155 php 7.0 upgrade to 7.1 display error

PHP 5.3 forced a 1.39h upgrade Admin error

ver. 1.3.6 coupon_admin.php error (didn't upgrade all files properly)

Bookmarks

Bookmarks

Posting Permissions