Install bugs

[cstdenis2]

(submitting again because post never showed up in the forum)

zen-cart-v1.5.7c
PHP 8.0.15
MariaDB 10.5.13

1.

 PHP Fatal error:  Uncaught TypeError: mysqli_close(): Argument #1 ($mysql) must be of type mysqli, bool given in /usr/home/sites/zen15/www/includes/classes/db/mysql/query_factory.php:130
Stack trace:
#0 /usr/home/sites/zen15/www/includes/classes/db/mysql/query_factory.php(130): mysqli_close()
#1 /usr/home/sites/zen15/www/includes/classes/db/mysql/query_factory.php(135): queryFactory->close()
#2 /usr/home/sites/zen15/www/zc_install/includes/classes/class.systemChecker.php(44): queryFactory->__destruct()
#3 /usr/home/sites/zen15/www/zc_install/includes/modules/pages/index/header_php.php(62): systemChecker->runTests()
#4 /usr/home/sites/zen15/www/zc_install/index.php(40): require('/usr/home/sites...')
#5 {main}
  thrown in /usr/home/sites/zen15/www/includes/classes/db/mysql/query_factory.php on line 130

Fix

--- includes/classes/db/mysql/query_factory.php.old     2022-02-09 22:06:21.496980000 -0800
+++ includes/classes/db/mysql/query_factory.php 2022-02-09 20:22:46.536533000 -0800
@@ -127,7 +127,8 @@
   }

   function close() {
-    @mysqli_close($this->link);
+    if($this->link)
+        @mysqli_close($this->link);
     unset($this->link);
   }

2.

[09-Feb-2022 21:55:04 America/Vancouver] PHP Warning:  fopen(includes/nginx_conf/zencart_ngx_server.conf): Failed to open stream: Permission denied in /usr/home/sites/zen15/www/_zc_install/includes/modules/pages/completion/header_php.php on line 62
[09-Feb-2022 21:55:04 America/Vancouver] PHP Fatal error:  Uncaught TypeError: fwrite(): Argument #1 ($stream) must be of type resource, bool given in /usr/home/sites/zen15/www/_zc_install/includes/modules/pages/completion/header_php.php:63
Stack trace:
#0 /usr/home/sites/zen15/www/_zc_install/includes/modules/pages/completion/header_php.php(63): fwrite()
#1 /usr/home/sites/zen15/www/_zc_install/index.php(40): require('/usr/home/sites...')
#2 {main}
  thrown in /usr/home/sites/zen15/www/_zc_install/includes/modules/pages/completion/header_php.php on line 63

root@www-php8:/home/sites/zen15/www/logs # ll ../_zc_install/includes/nginx_conf/
total 10
-rw-r--r--  1 zen15  nginx     24 Mar  5  2021 .gitignore
-rw-r--r--  1 zen15  nginx  12694 Mar  5  2021 ngx_server_template.txt
-rw-r--r--  1 zen15  nginx   2257 Mar  5  2021 zencart_ngx_http.conf

[swguy]

To confirm: You're using Ngnix, not Apache?

[mc12345678]

(submitting again because post never showed up in the forum)

zen-cart-v1.5.7c
PHP 8.0.15
MariaDB 10.5.13

1.

 PHP Fatal error:  Uncaught TypeError: mysqli_close(): Argument #1 ($mysql) must be of type mysqli, bool given in /usr/home/sites/zen15/www/includes/classes/db/mysql/query_factory.php:130
Stack trace:
#0 /usr/home/sites/zen15/www/includes/classes/db/mysql/query_factory.php(130): mysqli_close()
#1 /usr/home/sites/zen15/www/includes/classes/db/mysql/query_factory.php(135): queryFactory->close()
#2 /usr/home/sites/zen15/www/zc_install/includes/classes/class.systemChecker.php(44): queryFactory->__destruct()
#3 /usr/home/sites/zen15/www/zc_install/includes/modules/pages/index/header_php.php(62): systemChecker->runTests()
#4 /usr/home/sites/zen15/www/zc_install/index.php(40): require('/usr/home/sites...')
#5 {main}
  thrown in /usr/home/sites/zen15/www/includes/classes/db/mysql/query_factory.php on line 130

Fix

--- includes/classes/db/mysql/query_factory.php.old     2022-02-09 22:06:21.496980000 -0800
+++ includes/classes/db/mysql/query_factory.php 2022-02-09 20:22:46.536533000 -0800
@@ -127,7 +127,8 @@
   }

   function close() {
-    @mysqli_close($this->link);
+    if($this->link)
+        @mysqli_close($this->link);
     unset($this->link);
   }

While there is not a good/consistent reason that the above function would be called twice, but wouldn't a subsequent call cause a log item in attempting to access an unset variable?

Would suggest modifying the fix to:

--- includes/classes/db/mysql/query_factory.php.old     2022-02-09 22:06:21.496980000 -0800
+++ includes/classes/db/mysql/query_factory.php 2022-02-09 20:22:46.536533000 -0800
@@ -127,7 +127,8 @@
   }

   function close() {
-    @mysqli_close($this->link);
+    if(!empty($this->link)) {
+        @mysqli_close($this->link);
+    }
     unset($this->link);
   }

[carlwhat]

with regards to the first bug being reported, according to github, this issue was already addressed in the move since v157c being released.

v157c:
https://github.com/zencart/zencart/b....php#L129-L132


current v157 codeset:
https://github.com/zencart/zencart/b....php#L129-L133

[mc12345678]

with regards to the first bug being reported, according to github, this issue was already addressed in the move since v157c being released.

v157c:
https://github.com/zencart/zencart/b....php#L129-L132


current v157 codeset:
https://github.com/zencart/zencart/b....php#L129-L133

To which my previous comment still applies for the same reason that a notice is thrown on a subsequent call to that code after $this->link is unset from a previous success of executing that code.

[carlwhat]

To which my previous comment still applies for the same reason that a notice is thrown on a subsequent call to that code after $this->link is unset from a previous success of executing that code.

YAGNI.

not a fan. look at the code. can not see steps necessary to introduce said notice.

[cstdenis2]

To confirm: You're using Ngnix, not Apache?

Yes, that is correct.

[swguy]

Can you update your copy of the close() function from Zen Cart 1.5.8 on Github and confirm that things work properly?

public function close(): void
{
if (!$this->link) return;
@mysqli_close($this->link);
unset($this->link);
}