Zen-Cart v1 5 7d update

[mc12345678]

The files
zc_install\sql\updates\mysql_upgrade_zencart_157.sql and
\includes\version.php

have not been updated for 157d

Same is or was true for zc_install/sql/install/mysql_zencart.sql

[Elemi]

I would expect the query at the line of concern to look something like:

AND pa.options_id = ' . $option_id . '

And instead would be "better" as:

AND pa.options_id = ' . (is_numeric($option_id) ? $option_id : "'" . $option_id . "'") . '

hmmmmm.... I updated that and crashed my site!
So I've just reverted that back.

[markau]

Does 157d work on php 8.1?

It is said that php 7.4 will lose support in Oct this year. So I am looking for a cart that works on php 8.1

[markau]

Just tested 157d on php 8.1, worked very well

[mc12345678]

hmmmmm.... I updated that and crashed my site!
So I've just reverted that back.

What can I say, not enough information given especially when accessing the file to find that it was not as expected and then not identifying that.

Now that I've gone and done all the work to find the plugin that installs that file, the below change works if using PHP 8.x or higher:

At line 108, replace

                                        AND pa.options_id = $options_id

With:

                                        AND pa.options_id = " . (is_numeric($options_id) ? $options_id : '\'' . $options_id . '\'') . "

Note that the content surrounding the third instance of $options_id is three single quotes with a back slash before the second one and that double quotes are otherwise used to match the format in the file.

The plugin to which this applies is: Keep Cart

[lat9]

What can I say, not enough information given especially when accessing the file to find that it was not as expected and then not identifying that.

Now that I've gone and done all the work to find the plugin that installs that file, the below change works if using PHP 8.x or higher:

At line 108, replace

                                        AND pa.options_id = $options_id

With:

                                        AND pa.options_id = " . (is_numeric($options_id) ? $options_id : '\'' . $options_id . '\'') . "

Note that the content surrounding the third instance of $options_id is three single quotes with a back slash before the second one and that double quotes are otherwise used to match the format in the file.

The plugin to which this applies is: Keep Cart

v2.0.2 of the plugin submitted to correct the error. Note that the change uses

                                        AND pa.options_id = " . (int)$options_id . "

[Elemi]

v2.0.2 of the plugin submitted to correct the error. Note that the change uses

                                        AND pa.options_id = " . (int)$options_id . "

Thank you, that's all working now :-)

[lat9]

Thank you, that's all working now :-)