Attribute adding long code to product id

[apollowilcox]

We are experimenting a bit with product attributes (information only for now) and having an issue that i am unable to find addressed this in forum. I apologize if i'm repeating a topic.

The order confirmation email has a long attribute code (looks like a GUID) added to the item ID. Not only is it confusing to the reader, but it also triggers an error because the product ID value is too long for the field.


The yellow highlighted is the actual item Id and is appropriate shown. The long code highlighted in blue is unwanted. The second item on the order does not have any attributes assigned.

I have looked for config settings to turn this off; and i have looked into the code to try to rem out the line. Two strikes so far.

Is this presentation normal? Is there a way i can get rid of the code?

Thanks,

[swguy]

In 1.5.7d, includes/classes/order.php line 1014, that line is supposed to show ordered quantity 'x' the product name.
See if you have made changes to that file.

[apollowilcox]

Thanks swguy. Yes, we have made three minor touches to that file. And i have stared at that file long and hard trying to see if its the source of this current issue. I sense you are confirming that this is the right file, so maybe i'll upload a vanilla version, and see if it addresses this. Seem logical? I'm open to any ideas. Thanks much.

[apollowilcox]

Specifically, one change we made was to remove the 'model' from our email as the model is a meaningless value (to our customer) in our setup. Instead, we have it list the Product ID and then the name.
Vanilla Line 1021 from includes/classes/order.php is:

 '<td class="product-details" align="right" valign="top" width="30">' . $this->products[$i]['qty'] . '&nbsp;x</td>' . "\n" .
      '<td class="product-details" valign="top">' . nl2br($this->products[$i]['name']) . ($this->products[$i]['model'] != '' ? ' (' . nl2br($this->products[$i]['model']) . ') ' : '') . "\n" .
      '<nobr>' .
      '<small><em> '. nl2br($this->products_ordered_attributes) .'</em></small>' .
      '</nobr>' .
      '</td>' . "\n" .

And our code is:

'<td class="product-details" align="right" valign="top" width="30">' . $this->products[$i]['qty'] . '&nbsp;x</td>' . "\n" .
      '<td class="product-details" valign="top">' . '<strong>' . nl2br($this->products[$i]['id']) . '</strong>' . ($this->products[$i]['name'] != '' ? ' (' . nl2br($this->products[$i]['name']) . ') ' : '') . "\n" .
      '<nobr>' .
      '<em> '. nl2br($this->products_ordered_attributes) .'</em>' .		//MMW: removed <small> tags.
      '</nobr>' .
      '</td>' . "\n" .

Its like this additional attribute code is being somehow attached to the ID field, since both are being presented as bold (<strong>). As mentioned, unless something here gets your attention as being wrong, i'll copy the vanilla and see what happens. Thanks.

[swguy]

Then just change

$this->products[$i]['id']
to
(int)$this->products[$i]['id']

Be sure to hit both plain text and HTML.
This is lines 1014 and 1021 in a vanilla copy of includes/classes/order.php

[apollowilcox]

Then just change

$this->products[$i]['id']
to
(int)$this->products[$i]['id']

Be sure to hit both plain text and HTML.
This is lines 1014 and 1021 in a vanilla copy of includes/classes/order.php

Yeah, that's an efficient solution. Much appreciated!

[apollowilcox]

Follow up questions on same issue: We are using a few options/values/attributes and with v1.5.8a, when adding a product (with an option attached) to a shopping cart, we get an error:

pzen_addpro_cart() called at [/..../store/pzen_ajx_cart.php:46]
--> PHP Fatal error: 1406ata too long for column 'products_id' at row 1 :: INSERT INTO zen_customers_basket
(customers_id, products_id, customers_basket_quantity,
customers_basket_date_added)
VALUES (19517, '88348:f5a65b2fbfe9247f559dd4c029afff79', '4', '20230414') ==> (as called by) /..../store/includes/classes/shopping_cart.php on line 294 <== in

It seems (to my php-handicapped eye) that the long option-addon code after the product_id does not fit into the products_id field of the zen customer basket.

Leveraging the elegant solution offered above in the thread, I tried tweaking \includes\classes\shopping_cart.php line 292 to add (int)$product_id to the zen_customer_basket and that worked. And a similar tweak at line 580 to find and REMOVE the item from the basket.

What i cannot get to work is a CHANGE of quantity to an (option-assigned) product in the cart/ basket. The shopping-cart page freezes. Adding (int) to line 407 in the update_quantity failed to work.

Is there an easier way around all of this? Am i on the right track?

Thank you.

[lat9]

Follow up questions on same issue: We are using a few options/values/attributes and with v1.5.8a, when adding a product (with an option attached) to a shopping cart, we get an error:


It seems (to my php-handicapped eye) that the long option-addon code after the product_id does not fit into the products_id field of the zen customer basket.

Leveraging the elegant solution offered above in the thread, I tried tweaking \includes\classes\shopping_cart.php line 292 to add (int)$product_id to the zen_customer_basket and that worked. And a similar tweak at line 580 to find and REMOVE the item from the basket.

What i cannot get to work is a CHANGE of quantity to an (option-assigned) product in the cart/ basket. The shopping-cart page freezes. Adding (int) to line 407 in the update_quantity failed to work.

Is there an easier way around all of this? Am i on the right track?

Thank you.

The {zen_}customers_basket:roducts_id field is, in a standard Zen Cart distribution, defined as a tinytext field. That field type can hold up to 255 characters and the uprid (i.e. for an attributed product) you'd posted is only 39 characters.

Don't add that (int) cast, since that will result in the truncation/loss of the attributes' reference. Check, instead, that the database field hasn't been mangled by that Themeforest template.

[apollowilcox]

The {zen_}customers_basket:roducts_id field is, in a standard Zen Cart distribution, defined as a tinytext field. That field type can hold up to 255 characters and the uprid (i.e. for an attributed product) you'd posted is only 39 characters.

Don't add that (int) cast, since that will result in the truncation/loss of the attributes' reference. Check, instead, that the database field hasn't been mangled by that Themeforest template.

Thanks much for this info. You were exactly right. The product_id field type was incorrect / non-vanilla, and it is unclear how / why it was changed.

As I prepare to change customers_basket.products_id to type TinyText, where might I find all the original vanilla settings for this field so that all values for this field end up as correct/ vanilla? I can easily change it to tinytext, but it is also asking for length, collation, etc. Trying to do this exactly right...



Thank you so much for your help.

[apollowilcox]

Also, will i need to change this key?



Thank you much.