Results 1 to 9 of 9
  1. #1
    Join Date
    Jan 2015
    Posts
    423
    Plugin Contributions
    0

    Default upgrading Flexible Return Authorization (RMA) for ZC v1.5.x

    I have made some good progress upgrading my site but still have some errors I can figure out.

    I am using Flexible Return Authorization (RMA). I am getting some warnings that i need some help on.

    Error 1
    [10-Nov-2022 20:22:38 Europe/Berlin] Request URI: /invertersupply.com/index.php?main_page=returns, IP address: 127.0.0.1
    #0 C:\xampp\htdocs/xxx.com\includes\templates\theme871\templates\tpl_returns_default.php(142): zen_debug_error_handler()
    #1 C:\xampp\htdocs/xxx.com\includes\templates\theme871\common\tpl_main_page.php(407): require('C:\\xampp\\htdocs...')
    #2 C:\xampp\htdocs/xxx.com\index.php(94): require('C:\\xampp\\htdocs...')
    --> PHP Warning: Undefined variable $name in C:\xampp\htdocs/xxx.com\includes\templates\theme871\templates\tpl_returns_default.php on line 142.


    Code:
    <?php
    
    switch (RETURN_NAME) {
    
        case 0:
    
            echo '<li><label class="inputLabel"  for="contactname">' . ENTRY_NAME . RETURN_OPTIONAL_IMAGE . '</label>' . zen_draw_input_field('name', '', 'size="40" id="name"') . '</li>';
    
            break;
    
        case 1:
    
            echo '<li><label class="inputLabel"  for="contactname">' . (($error == true && $entry_name_error == true) ? ENTRY_NAME . RETURN_WARNING_IMAGE : ENTRY_NAME . RETURN_REQUIRED_IMAGE) . '<span style="color:#ed1c24;font-weight:400;"> *</span></label>' . (($error == true && $entry_name_error == true) ? zen_draw_input_field('contactname', $name, 'size="40" id="contactname"') . ENTRY_NAME_ERROR : zen_draw_input_field('contactname', $name, 'size="40" id="contactname"')) . '</li>';
    
            break;
    
        case 2:
    
            echo '';
    
            break;
    
    }
    
    ?>
    and the other error same page is

    [10-Nov-2022 20:22:38 Europe/Berlin] Request URI: /invertersupply.com/index.php?main_page=returns, IP address: 127.0.0.1
    #0 C:\xampp\htdocs/xxx.com\includes\templates\theme871\templates\tpl_returns_default.php(31): zen_debug_error_handler()
    #1 C:\xampp\htdocs/xxx.com\includes\templates\theme871\common\tpl_main_page.php(407): require('C:\\xampp\\htdocs...')
    #2 C:\xampp\htdocs/xxx.com\index.php(94): require('C:\\xampp\\htdocs...')
    --> PHP Warning: Undefined array key "action" in C:\xampp\htdocs/xxx.com\includes\templates\theme871\templates\tpl_returns_default.php on line 31.
    Code:
    <?php if (RETURN_STORE_NAME_ADDRESS == 'true' && ($_GET['action'] == 'success')) { ?>

  2. #2
    Join Date
    Nov 2005
    Location
    los angeles
    Posts
    2,668
    Plugin Contributions
    11

    Default Re: upgrading Flexible Return Authorization (RMA) for ZC v1.5.x

    chad,
    in that template file, there are 2 uses of $name for drawing an input field; in both situations, i would replace them as as:

    PHP Code:
    //from
    $name 
    //to
    ($name ?? ''
    similarly for your get problem, i would replace as so:

    PHP Code:
    //from
    ($_GET['action'] == 'success')
    //to
    (($_GET['action'] ?? 'noaction') == 'success'
    best.
    author of square Webpay.
    mxWorks has premium plugins. donations: venmo or paypal accepted.
    premium consistent excellent support. available for hire.

  3. #3
    Join Date
    Jan 2015
    Posts
    423
    Plugin Contributions
    0

    Default Re: upgrading Flexible Return Authorization (RMA) for ZC v1.5.x

    when I replace $name with ($name ?? '') I get a syntax error. am i putting it in incorrectly? both of the examples same issue with sytax error

  4. #4
    Join Date
    Nov 2005
    Location
    los angeles
    Posts
    2,668
    Plugin Contributions
    11

    Default Re: upgrading Flexible Return Authorization (RMA) for ZC v1.5.x

    if there’s a syntax error than yes.

    what version of php are you running?

    and post the whole line of code that you are getting the error on.
    author of square Webpay.
    mxWorks has premium plugins. donations: venmo or paypal accepted.
    premium consistent excellent support. available for hire.

  5. #5
    Join Date
    Jan 2015
    Posts
    423
    Plugin Contributions
    0

    Default Re: upgrading Flexible Return Authorization (RMA) for ZC v1.5.x

    Quote Originally Posted by carlwhat View Post
    if there’s a syntax error than yes.

    what version of php are you running?

    and post the whole line of code that you are getting the error on.
    php 8.1

    here is the tpl_returns_default.php file

    Code:
    <?php
    
    /**
    
     * Flexible Returns Authorization (RMA) Template
    
     *
    
     * @package templateSystem
    
     * @copyright Copyright 2003-2005 Zen Cart Development Team
    
     * @copyright Portions Copyright 2003 osCommerce
    
     * @license http://www.zen-cart.com/license/2_0.txt GNU Public License V2.0
    
     * @version $Id: tpl_returns_default.php 2.3.3 4/13/2010 Clyde Jones $
    
     */
    
    ?>
    
    <div class="centerColumn" id="returnAuthorization">
    
    <h1><?php echo HEADING_TITLE; ?></h1>
    
    <?php echo zen_draw_form('returns', zen_href_link(FILENAME_RETURNS, 'action=send', 'SSL')); ?>
    
    
    
    <?php if (RETURN_STORE_NAME_ADDRESS == 'true' && ($_GET['action'] == 'success')) { ?>
    
    <?php
    
    /**
    
    show nothing
    
     */
    
    } else if (RETURN_STORE_NAME_ADDRESS == 'true') { ?>
    
     
    
    <?php } ?>
    
    <?php
    
      if (isset($_GET['action']) && ($_GET['action'] == 'success')) {
    
    ?>
    
    <br class="clearBoth" />
    
    <div class="mainContent success">
    
    <?php 
    
    $order_number = $_GET['order_id']; 
    
    ?>
    
    <?php echo '<div id="returnSuccess">' . TEXT_SUCCESS . TEXT_SUCCESS_RMA_REFERENCE . '<a href="javascript:popupWindow(\'' . zen_href_link(FILENAME_POPUP_RETURNS, 'action=success' . '&order_id=' . $order_number) . '\')">' . TEXT_SUCCESS_POPUP . '</a>' . TEXT_SUCCESS_RMA_REFERENCE1 . '</div>'  ?>
    
    <?php
    
    $orderID = $_GET['order_id'];
    
    $autoRMA = ORDER_STATUS_RMA;
    
    $reason = $_SESSION['comments'];
    
    $action = $_SESSION['action'];
    
    if (ORDER_STATUS_RMA_OPTION == 'true') {
    
    $db->Execute("update " . TABLE_ORDERS . " set orders_status = $autoRMA, last_modified = now() where orders_id = '" . (int)$orderID . "'");
    
    }
    
    if (ORDER_COMMENTS_RMA_OPTION == 'true') {
    
    $returnRMA = $orderID . $rma_number;
    
    $db->Execute("insert into " . TABLE_ORDERS_STATUS_HISTORY . " (comments, orders_status_id, orders_id, date_added, rma_number, action) values ('" . zen_db_input(zen_db_prepare_input($reason)) ."', '" . zen_db_input(zen_db_prepare_input($autoRMA)) ."', '" . (int)$orderID ."', now(), '" . zen_db_input(zen_db_prepare_input($returnRMA)) ."', '" . zen_db_input(zen_db_prepare_input($action)) ."')");
    
    }
    
    ?>
    
    <?php
    
      } else {
    
    ?> 
    
    <?php if (DEFINE_RETURNS_STATUS >= '1' and DEFINE_RETURNS_STATUS <= '2') { ?>
    
    <div id="returnAuthorizationMainContent">
    
    <?php  
    
    /**
    
     * require html_define for the Returns page
    
     */
    
    require($define_page);
    
    ?>
    
    </div>
    
    <?php } ?>
    
    <?php if ($messageStack->size('returns') > 0) echo $messageStack->output('returns'); ?>
    
    <div class="alert" id="back"><?php echo RETURN_REQUIRED_IMAGE . RETURN_REQUIRED_INFORMATION . RETURN_OPTIONAL_IMAGE . RETURN_OPTIONAL_INFORMATION; ?></div>
    
    <br class="clearBoth" />
    
    <div style="color:#ed1c24;">* Required information</div>
    
    
    <legend class="personal"><?php echo CONTACT_INFORMATION; ?></legend>
    
     
    
    <?php
    
    switch (RETURN_NAME) {
    
        case 0:
    
            echo '<li><label class="inputLabel"  for="contactname">' . ENTRY_NAME . RETURN_OPTIONAL_IMAGE . '</label>' . zen_draw_input_field('name', '', 'size="40" id="name"') . '</li>';
    
            break;
    
        case 1:
    
            echo '<li><label class="inputLabel"  for="contactname">' . (($error == true && $entry_name_error == true) ? ENTRY_NAME . RETURN_WARNING_IMAGE : ENTRY_NAME . RETURN_REQUIRED_IMAGE) . '<span style="color:#ed1c24;font-weight:400;"> *</span></label>' . (($error == true && $entry_name_error == true) ? zen_draw_input_field('contactname', $name, 'size="40" id="contactname"') . ENTRY_NAME_ERROR : zen_draw_input_field('contactname', $name, 'size="40" id="contactname"')) . '</li>';
    
            break;
    
        case 2:
    
            echo '';
    
            break;
    
    }
    
    ?>
    
    <?php
    
    switch (RETURN_EMAIL) {
    
        case 0:
    
            echo '<li><label class="inputLabel"  for="emailaddress">' . ENTRY_EMAIL . RETURN_OPTIONAL_IMAGE . '</label>' . zen_draw_input_field('email', '', 'size="40" id="email"') . '</li>';
    
            break;
    
        case 1:
    
            echo '<li><label class="inputLabel"  for="emailaddress">' . (($error == true && $entry_email_error == true)? ENTRY_EMAIL . RETURN_WARNING_IMAGE : ENTRY_EMAIL . RETURN_REQUIRED_IMAGE) . '<span style="color:#ed1c24;font-weight:400;"> *</span></label>' . (($error == true && $entry_email_error == true)? zen_draw_input_field('email', ($error ? $_POST['email'] : $email), ' size="40" id="emailaddress"') . ENTRY_EMAIL_ERROR : zen_draw_input_field('email', ($error ? $_POST['email'] : $email), ' size="40" id="emailaddress"')) . '</li>';
    
            break;
    
        case 2:
    
            echo '';
    
            break;
    
    }
    
    ?>
    
    <?php
    
    switch (RETURN_PHONE) {
    
        case 0:
    
            echo '<li><label class="inputLabel"  for="telephone">' . ENTRY_TELEPHONE . RETURN_OPTIONAL_IMAGE . '</label>' . zen_draw_input_field('telephone', '', 'size="40" id="telephone"') . '</li>';
    
            break;
    
        case 1:
    
            echo '<li><label class="inputLabel"  for="telephone">' . (($error == true && $entry_telephone_error == true) ? ENTRY_TELEPHONE . RETURN_WARNING_IMAGE : ENTRY_TELEPHONE . RETURN_REQUIRED_IMAGE) . '<span style="color:#ed1c24;font-weight:400;"> *</span></label>' . (($error == true && $entry_telephone_error == true) ? zen_draw_input_field('telephone', $telephone, 'size="40" id="telephone"') . ENTRY_TELEPHONE_ERROR : zen_draw_input_field('telephone', $telephone, 'size="40" id="telephone"')) . '</li>';
    
            break;
    
        case 2:
    
            echo '';
    
            break;
    
    }
    
    ?>
    
    <?php
    
    switch (RETURN_STREET) {
    
        case 0:
    
            echo '<li><label class="inputLabel"  for="address">' . ENTRY_ADDRESS . RETURN_OPTIONAL_IMAGE . '</label>' . zen_draw_input_field('address', '', 'size="40" id="address"') . '</li>';
    
            break;
    
        case 1:
    
            echo '<li><label class="inputLabel"  for="address">' . (($error == true && $entry_street_address_error == true) ? ENTRY_ADDRESS . RETURN_WARNING_IMAGE : ENTRY_ADDRESS . RETURN_REQUIRED_IMAGE) . '</label>' . (($error == true && $entry_street_address_error == true) ? zen_draw_input_field('address', $address, 'size="40" id="address"') . ENTRY_ADDRESS_ERROR : zen_draw_input_field('address', $address, 'size="40" id="address"')) . '</li>';
    
            break;
    
        case 2:
    
            echo '';
    
            break;
    
    }
    
    ?>
    
    <?php
    
    switch (RETURN_CITY) {
    
        case 0:
    
            echo '<li><label class="inputLabel"  for="city">' . RETURNS_ENTRY_CITY . RETURN_OPTIONAL_IMAGE . '</label>' . zen_draw_input_field('city', '', 'size="40" id="city"') . '</li>';
    
            break;
    
        case 1:
    
            echo '<li><label class="inputLabel"  for="city">' . (($error == true && $entry_city_error == true) ? RETURNS_ENTRY_CITY . RETURN_WARNING_IMAGE : RETURNS_ENTRY_CITY . RETURN_REQUIRED_IMAGE) . '</label>' . (($error == true && $entry_city_error == true) ? zen_draw_input_field('city', $city, 'size="40" id="city"') . ENTRY_CITY_TEXT_ERROR : zen_draw_input_field('city', $city, 'size="40" id="city"')) . '</li>';
    
            break;
    
        case 2:
    
            echo '';
    
            break;
    
    }
    
    ?>
    
    <?php
    
    switch (RETURN_STATE) {
    
        case 0:
    
            echo '<li><label class="inputLabel"  for="state">' . RETURNS_ENTRY_STATE . RETURN_OPTIONAL_IMAGE . '</label>' . zen_draw_input_field('state', '', 'size="40" id="state"') . '</li>';
    
            break;
    
        case 1:
    
            echo '<li><label class="inputLabel"  for="state">' . (($error == true && $entry_state_error == true) ? RETURNS_ENTRY_STATE . RETURN_WARNING_IMAGE : RETURNS_ENTRY_STATE . RETURN_REQUIRED_IMAGE) . '</label>' . (($error == true && $entry_state_error == true) ? zen_draw_input_field('state', $state, 'size="40" id="state"') . ENTRY_STATE_TEXT_ERROR : zen_draw_input_field('state', $state, 'size="40" id="state"')) . '</li>';
    
            break;
    
        case 2:
    
            echo '';
    
            break;
    
    }
    
    ?>
    
    <?php
    
    switch (RETURN_POSTCODE) {
    
        case 0:
    
            echo '<li><label class="inputLabel"  for="postcode">' . ENTRY_POSTCODE . RETURN_OPTIONAL_IMAGE . '</label>' . zen_draw_input_field('postcode', '', 'size="40" id="postcode"') . '</li>';
    
            break;
    
        case 1:
    
            echo '<li><label class="inputLabel"  for="postcode">' . (($error == true && $entry_postcode_error == true) ? ENTRY_POSTCODE . RETURN_WARNING_IMAGE : ENTRY_POSTCODE . RETURN_REQUIRED_IMAGE) . '</label>' . (($error == true && $entry_postcode_error == true) ? zen_draw_input_field('postcode', $postcode, 'size="40" id="postcode"') . ENTRY_POSTCODE_ERROR : zen_draw_input_field('postcode', $postcode, 'size="40" id="postcode"')) . '</li>';
    
            break;
    
        case 2:
    
            echo '';
    
            break;
    
    }
    
    ?>
    
    <?php
    
    switch (RETURN_COUNTRY) {
    
        case 0:
    
            echo '<li><label class="inputLabel"  for="country">' . RETURNS_ENTRY_COUNTRY . RETURN_OPTIONAL_IMAGE . '</label>' . zen_draw_input_field('country', '', 'size="40" id="country"') . '</li>';
    
            break;
    
        case 1:
    
            echo '<li><label class="inputLabel"  for="country">' . (($error == true && $entry_country_error == true) ? RETURNS_ENTRY_COUNTRY . RETURN_WARNING_IMAGE : RETURNS_ENTRY_COUNTRY . RETURN_REQUIRED_IMAGE) . '</label>' . (($error == true && $entry_country_error == true) ? zen_draw_input_field('country', $country, 'size="40" id="country"') . ENTRY_COUNTRY_TEXT_ERROR : zen_draw_input_field('country', $country, 'size="40" id="order_number"')) . '</li>';
    
            break;
    
        case 2:
    
            echo '';
    
            break;
    
    }
    
    ?>
    
    
    
    
     
    
    <?php
    
    switch (RETURN_ORDER_NUMBER) {
    
        case 0:
    
            echo '<li><label class="inputLabel"  for="order_number">' . ENTRY_ORDER_NUMBER . RETURN_OPTIONAL_IMAGE . '</label>' . zen_draw_input_field('order_number', '', 'size="40" id="order_number"') . '</li>';
    
            break;
    
        case 1:
    
            echo '<li><label class="inputLabel"  for="order_number">' . (($error == true && $entry_order_number_error == true) ? ENTRY_ORDER_NUMBER . RETURN_WARNING_IMAGE : ENTRY_ORDER_NUMBER . RETURN_REQUIRED_IMAGE) . '<span style="color:#ed1c24;font-weight:400;"> *</span></label>' . (($error == true && $entry_order_number_error == true) ? zen_draw_input_field('order_number', $order_number, 'size="40" id="order_number"') . ENTRY_ORDER_NUMBER_ERROR : zen_draw_input_field('order_number', $order_number, 'size="40" maxlength="7" id="order_number"')) . '</li>';
    
            break;
    
        case 2:
    
            echo '';
    
            break;
    
    }
    
    ?>
    
    <?php  echo '<input type="hidden" name="rma_number" value="'.$rma_number.'">'; ?> 
    
    <?php
    
    switch (RETURN_ITEM_NAME) {
    
        case 0:
    
            echo '<li><label class="inputLabel"  for="item_name">' . ENTRY_ITEM_NAME . RETURN_OPTIONAL_IMAGE . '</label>' . zen_draw_input_field('item_name', '', 'size="40" id="item_name"') . '</li>';
    
            break;
    
        case 1:
    
            echo '<li><label class="inputLabel"  for="item_name">' . (($error == true && $entry_item_name_error == true) ? ENTRY_ITEM_NAME . RETURN_WARNING_IMAGE : ENTRY_ITEM_NAME . RETURN_REQUIRED_IMAGE) . '</label>' . (($error == true && $entry_item_name_error == true) ? zen_draw_input_field('item_name', $item_name, 'size="40" id="item_name"') . ENTRY_ITEM_NAME_ERROR : zen_draw_input_field('item_name', $item_name, 'size="40" id="item_name"')) . '</li>';
    
            break;
    
        case 2:
    
            echo '';
    
            break;
    
    }
    
    ?>
    
    <?php
    
    switch (RETURN_ITEM_NUMBER) {
    
        case 0:
    
            echo '<li><label class="inputLabel"  for="item_number">' . ENTRY_ITEM_NUMBER . RETURN_OPTIONAL_IMAGE . '</label>' . zen_draw_input_field('item_number', '', 'size="40" id="item_number"') . '</li>';
    
            break;
    
        case 1:
    
            echo '<li><label class="inputLabel"  for="item_number">' . (($error == true && $entry_item_number_error == true) ? ENTRY_ITEM_NUMBER . RETURN_WARNING_IMAGE : ENTRY_ITEM_NUMBER . RETURN_REQUIRED_IMAGE) . '</label>' . (($error == true && $entry_item_number_error == true) ? zen_draw_input_field('item_number', $item_number, 'size="40" id="item_number"') . ENTRY_ITEM_NUMBER_ERROR : zen_draw_input_field('item_number', $item_number, 'size="40" id="item_number"')) . '</li>';
    
            break;
    
        case 2:
    
            echo '';
    
            break;
    
    }
    
    ?>
    
    <?php
    
    switch (RETURN_VALUE) {
    
        case 0:
    
            echo '<li><label class="inputLabel"  for="total_value">' . ENTRY_VALUE . RETURN_OPTIONAL_IMAGE . '</label>' . zen_draw_input_field('total_value', '', 'size="40" id="total_value"') . '</li>';
    
            break;
    
        case 1:
    
            echo '<li><label class="inputLabel"  for="total_value">' . (($error == true && $entry_value_error == true) ? ENTRY_VALUE . RETURN_WARNING_IMAGE : ENTRY_VALUE . RETURN_REQUIRED_IMAGE) . '</label>' . (($error == true && $entry_value_error == true) ? zen_draw_input_field('order_number', $order_number, 'size="40" id="order-number"') . ENTRY_VALUE_ERROR : zen_draw_input_field('order_number', $order_number, 'size="40" id="order-number"')) . '</li>';
    
            break;
    
        case 2:
    
            echo '';
    
            break;
    
    }
    
    ?>
    
    <?php
    
    if (RETURN_ACTION_LIST_OPTIONS != ''){
    
    foreach(explode(",", RETURN_ACTION_LIST_OPTIONS) as $k => $v) {
    
    $entry_action_array[] = array('id' => $v, 'text' => preg_replace('/\<[^*]*/', '', $v));
    
    }
    
    ?>
    
    <?php
    
    switch (RETURN_ACTION_LIST) {
    
        case 0:
    
            echo '<li><h4><?php echo ENTRY_ACTION_INFO; ?></h4><label class="inputLabel">' . ENTRY_ACTION . RETURN_OPTIONAL_IMAGE . '</label>' . zen_draw_pull_down_menu('action', $entry_action_array) . '</li>';
    
            break;
    
        case 1:
    
            echo '<li><h4><?php echo ENTRY_ACTION_INFO; ?></h4><label class="inputLabel">' . ENTRY_ACTION . RETURN_REQUIRED_IMAGE . '<span style="color:#ed1c24;font-weight:400;"> *</span></label>' . zen_draw_pull_down_menu('action', $entry_action_array) . '</li>';
    
            break;
    
    }
    
    ?>
    
    <?php
    
      }
    
    ?>
    
    
    <?php
    
    switch (RETURN_REASON) {
    
        case 0:
    
            echo '<li><label class="inputLabel"  for="reason">' . ENTRY_REASON_TEXT . RETURN_OPTIONAL_IMAGE . '</label>' . zen_draw_textarea_field('reason', '30', '7', $reason, 'id="reason"') . '</li>';
    
            break;
    
        case 1:
    
            echo '<li><label class="inputLabel"  for="reason">' . (($error == true && $entry_reason_error == true) ? ENTRY_REASON_TEXT . RETURN_WARNING_IMAGE : ENTRY_REASON_TEXT . RETURN_REQUIRED_IMAGE) . '<span style="color:#ed1c24;font-weight:400;"> *</span></label>' . (($error == true && $entry_reason_error == true) ? zen_draw_textarea_field('reason', '30', '7', $reason, 'id="reason"') . ENTRY_REASON_TEXT_ERROR : zen_draw_textarea_field('reason', '30', '7', $reason, 'id="reason"')) . '</li>';
    
            break;
    
    }
    
    ?>
    
     
    
    
    <div style="float:right; margin-right:0px;" class="buttonRow forward"><?php echo zen_image_submit(BUTTON_IMAGE_SEND, BUTTON_SEND_ALT); ?></div>
    
    <?php
    
      }
    
    ?>
    
    </form>
    
    </div>

  6. #6
    Join Date
    Feb 2006
    Location
    Tampa Bay, Florida
    Posts
    9,621
    Plugin Contributions
    123

    Default Re: upgrading Flexible Return Authorization (RMA) for ZC v1.5.x

    When I use php -l with that file and PHP 8.1, I don't get a syntax error.
    Are you sure you're using PHP 8.1?
    That Software Guy. My Store: Zen Cart Modifications
    Available for hire - See my ad in Services
    Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
    Do you benefit from Zen Cart? Then please support the project.

  7. #7
    Join Date
    Jan 2015
    Posts
    423
    Plugin Contributions
    0

    Default Re: upgrading Flexible Return Authorization (RMA) for ZC v1.5.x

    Quote Originally Posted by swguy View Post
    When I use php -l with that file and PHP 8.1, I don't get a syntax error.
    Are you sure you're using PHP 8.1?


    just doubled checked and yes it is PHP version: 8.1.10

  8. #8
    Join Date
    Nov 2005
    Location
    los angeles
    Posts
    2,668
    Plugin Contributions
    11

    Default Re: upgrading Flexible Return Authorization (RMA) for ZC v1.5.x

    i think you misunderstood. i was asking for the line that you were getting a syntax error.

    using a php8.1 language level, the lines i talked about changing should now look like:

    PHP Code:
    <?php
        
    if (RETURN_STORE_NAME_ADDRESS == 'true' && (($_GET['action'] ?? 'noaction') == 'success')) { ?>
    that line is located here:

    https://github.com/tmccaff/Zencart-R...efault.php#L19

    and the second one:

    PHP Code:
    case 1:

                        echo 
    '<li><label class="inputLabel"  for="contactname">' . (($error == true && $entry_name_error == true) ? ENTRY_NAME RETURN_WARNING_IMAGE ENTRY_NAME .
                                
    RETURN_REQUIRED_IMAGE) . '<span style="color:#ed1c24;font-weight:400;"> *</span></label>' . (($error == true && $entry_name_error == true) ? zen_draw_input_field('contactname', ($name ?? ''), 'size="40" id="contactname"') . ENTRY_NAME_ERROR zen_draw_input_field('contactname', ($name ?? ''), 'size="40" id="contactname"')) . '</li>';

                        break; 
    https://github.com/tmccaff/Zencart-R...fault.php#L109

    best.
    author of square Webpay.
    mxWorks has premium plugins. donations: venmo or paypal accepted.
    premium consistent excellent support. available for hire.

  9. #9
    Join Date
    Jan 2015
    Posts
    423
    Plugin Contributions
    0

    Default Re: upgrading Flexible Return Authorization (RMA) for ZC v1.5.x

    As always you guys are correct. I really appreciate it.

 

 

Similar Threads

  1. v151 Flexible Return Authorization (RMA) for ZC v1.5.x [Support Thread]
    By DivaVocals in forum All Other Contributions/Addons
    Replies: 167
    Last Post: 11 Apr 2021, 08:56 PM
  2. v156 Flexible Return Authorization (RMA)
    By chadlly2003 in forum General Questions
    Replies: 5
    Last Post: 9 Jan 2020, 04:19 AM
  3. Return Authorization Module (RMA)
    By voltage in forum All Other Contributions/Addons
    Replies: 648
    Last Post: 3 Jun 2015, 09:37 PM
  4. Return Authorization Module (RMA)
    By dscott1966 in forum All Other Contributions/Addons
    Replies: 0
    Last Post: 11 Nov 2006, 08:04 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR