upgrade to 1.5.8 fedex webservice depreciated

[chadlly2003]

I am upgrading from 1.57 to 1.58 and using fedex web services module
https://www.numinix.com/zen-cart-plu...vices-shipping


This is the error I am getting if someone can assist me with


error:
[14-Nov-2022 22:41:55 Europe/Berlin] Request URI: /xxx.com/index.php?main_page=shopping_cart, IP address: 127.0.0.1
#0 C:\xampp\htdocs\xxx.com\includes\classes\shipping.php(90): zen_debug_error_handler()
#1 C:\xampp\htdocs\xxx.com\includes\classes\shipping.php(90): include_once()
#2 C:\xampp\htdocs\xxx.com\includes\modules\shipping_estimator.php(148): shipping->__construct()
#3 C:\xampp\htdocs\xxx.com\includes\templates\theme871\templates\tpl_shopping_cart_ default.php(312): require('C:\\xampp\\htdocs...')
#4 C:\xampp\htdocs\xxx.com\includes\templates\theme871\common\tpl_main_page.php(407 ): require('C:\\xampp\\htdocs...')
#5 C:\xampp\htdocs\xxx.com\index.php(94): require('C:\\xampp\\htdocs...')
--> PHP Deprecated: Optional parameter $method declared before required parameter $client is implicitly treated as a required parameter in C:\xampp\htdocs\xxx.com\includes\modules\shipping\fedexwebservices.php on line 623.


Code on line 623

function do_request($method = '', $request, $client) {
  global $db, $shipping_weight, $shipping_num_boxes, $cart, $order, $all_products_ship_free;
    try {
      $response = $client->getRates($request);

[carlwhat]

the easiest solution is as follows:

//from
function do_request($method = '', $request, $client) {

//to
function do_request($method = '', $request = '', $client = '') { 

best.

[njcyx]

Hi @chadlly2003, if you are using php 8.0, you can probably try my code below:

https://www.zen-cart.com/showthread....33#post1390933

@numinix shown up in a different thread recently and they will updated this FedEx module for zc1.58 soon (but not yet).

https://www.zen-cart.com/showthread....36#post1391136

Update: I just checked my code near line 623 and it is the following:

function do_request($method, $request, $client) {

If my code doesn't help your error, maybe you can try @carlwhat way to fix...

[chadlly2003]

njcyx,

I grabbed those files. I am getting two warnigns



[17-Nov-2022 17:01:08 Europe/Berlin] Request URI: /xxx.com/index.php?main_page=shopping_cart, IP address: 127.0.0.1
#0 [internal function]: zen_debug_error_handler()
#1 C:\xampp\htdocs\xxx.com\includes\modules\shipping\fedexwebservices.php(278): utf8_encode()
#2 C:\xampp\htdocs\xxx.com\includes\modules\shipping\fedexwebservices.php(537): fedexwebservices->build_request()
#3 C:\xampp\htdocs\xxx.com\includes\classes\shipping.php(201): fedexwebservices->quote()
#4 C:\xampp\htdocs\xxx.com\includes\modules\shipping_estimator.php(151): shipping->quote()
#5 C:\xampp\htdocs\xxx.com\includes\templates\theme871\templates\tpl_shopping_cart_ default.php(312): require('C:\\xampp\\htdocs...')
#6 C:\xampp\htdocs\xxx.com\includes\templates\theme871\common\tpl_main_page.php(407 ): require('C:\\xampp\\htdocs...')
#7 C:\xampp\htdocs\xxx.com\index.php(94): require('C:\\xampp\\htdocs...')
--> PHP Deprecated: utf8_encode(): Passing null to parameter #1 ($string) of type string is deprecated in C:\xampp\htdocs\xxx.com\includes\modules\shipping\fedexwebservices.php on line 278.

'StreetLines' => array(utf8_encode($street_address), utf8_encode($street_address2))

[17-Nov-2022 17:01:08 Europe/Berlin] Request URI: /xxx.com/index.php?main_page=shopping_cart, IP address: 127.0.0.1
#0 [internal function]: zen_debug_error_handler()
#1 C:\xampp\htdocs\xxx.com\includes\modules\shipping\fedexwebservices.php(279): utf8_encode()
#2 C:\xampp\htdocs\xxx.com\includes\modules\shipping\fedexwebservices.php(537): fedexwebservices->build_request()
#3 C:\xampp\htdocs\xxx.com\includes\classes\shipping.php(201): fedexwebservices->quote()
#4 C:\xampp\htdocs\xxx.com\includes\modules\shipping_estimator.php(151): shipping->quote()
#5 C:\xampp\htdocs\xxx.com\includes\templates\theme871\templates\tpl_shopping_cart_ default.php(312): require('C:\\xampp\\htdocs...')
#6 C:\xampp\htdocs\xxx.com\includes\templates\theme871\common\tpl_main_page.php(407 ): require('C:\\xampp\\htdocs...')
#7 C:\xampp\htdocs\xxx.com\index.php(94): require('C:\\xampp\\htdocs...')
--> PHP Deprecated: utf8_encode(): Passing null to parameter #1 ($string) of type string is deprecated in C:\xampp\htdocs\xxx.com\includes\modules\shipping\fedexwebservices.php on line 279.

'City' => utf8_encode($city), //customer city

[swguy]

You might want to drop back to PHP 8.0 until some of the mod authors catch up.

[chadlly2003]

I was able to fix my errors

find this

'StreetLines' => array(utf8_encode($street_address), utf8_encode($street_address2))

replace with

'StreetLines' => array(utf8_encode($street_address ?? ''), utf8_encode($street_address2 ?? '')),

find

 'City' => utf8_encode($city)

replace

'City' => utf8_encode($city ?? '')

[swguy]

That's good, but why is the City null?

[chadlly2003]

That's good, but why is the City null?

Hmm not sure why it is null?

[carlwhat]

That's good, but why is the City null?

good point.

of course, this will be a temporary fix as well. the OP must only be using php 8.1; as in php 8.2 that function call will be deprecated and removed in php 9.0.

see:

https://tinyurl.com/2mp9swzw

[chadlly2003]

i got one last error in the admin

[17-Nov-2022 18:54:31 Europe/Berlin] Request URI: /invertersupply.com/power/index.php?cmd=modules&set=shipping, IP address: 127.0.0.1
#0 C:\xampp\htdocs\invertersupply.com\includes\modules\shipping\fedexwebservices.ph p(71): zen_debug_error_handler()
#1 C:\xampp\htdocs\invertersupply.com\power\modules.php(187): fedexwebservices->__construct()
#2 C:\xampp\htdocs\invertersupply.com\power\index.php(11): require('C:\\xampp\\htdocs...')
--> PHP Warning: Trying to access array offset on value of type null in C:\xampp\htdocs\invertersupply.com\includes\modules\shipping\fedexwebservices.ph p on line 71.

$countryId = $db->Execute("SELECT countries_id FROM ".TABLE_COUNTRIES." WHERE countries_name = '".$order->delivery['country']."'");