Quick question regarding third party and zencart 1.5.8

[chadlly2003]

zencart: 1.5.8
php 8.1.1.2


I use a program called shipworks to sync my orders for shipping purposes.

I am getting a strange error. Anyone have any suggestions


[06-Dec-2022 14:32:40 America/New_York] Request URI: /xxx/shipworks3.php, IP address: 66.176.65.97
--> PHP Fatal error: Uncaught Error: Call to undefined function zen_get_orders_status() in /home/inverter/public_html/xxxr/shipworks3.php:740
Stack trace:
#0 /home/inverter/public_html/xxx/shipworks3.php(169): Action_GetStatusCodes()
#1 {main}
thrown in /home/inverter/public_html/xxx/shipworks3.php on line 740.


line 740

$codes = zen_get_orders_status();

below is just some more of the code not sure if needed

function Action_GetStatusCodes()
        {
                writeStartTag("StatusCodes");

                $codes = zen_get_orders_status();
                
			   // reset($codes);
               // while (list($key, $val) = each($codes))
				
			foreach($codes as $key => $value) {
					
                 
                        writeStartTag("StatusCode");
                        writeElement("Code", $val['id']);
                        writeElement("Name", $val['text']);
                        writeCloseTag("StatusCode");
                }

[swguy]

This is a bug. We'll fix it ASAP.

Tracking: https://github.com/zencart/zencart/issues/5447

[swguy]

If you need a temporary work around, just put the code for this function in admin/includes/functions/extra_functions/temporary_get_order_status.php until a permanent fix for this issue is posted.

<?php
function zen_get_orders_status() {
global $db;

$orders_status_array = array();
$orders_status = $db->Execute("SELECT orders_status_id, orders_status_name
FROM " . TABLE_ORDERS_STATUS . "
WHERE language_id = " . (int)$_SESSION['languages_id'] . "
ORDER BY orders_status_id");

while (!$orders_status->EOF) {
$orders_status_array[] = array('id' => $orders_status->fields['orders_status_id'],
'text' => $orders_status->fields['orders_status_name']);
$orders_status->MoveNext();
}

return $orders_status_array;
}

[carlwhat]

zencart: 1.5.8
php 8.1.1.2


I use a program called shipworks to sync my orders for shipping purposes.

I am getting a strange error. Anyone have any suggestions


[06-Dec-2022 14:32:40 America/New_York] Request URI: /xxx/shipworks3.php, IP address: 66.176.65.97
--> PHP Fatal error: Uncaught Error: Call to undefined function zen_get_orders_status() in /home/inverter/public_html/xxxr/shipworks3.php:740
Stack trace:
#0 /home/inverter/public_html/xxx/shipworks3.php(169): Action_GetStatusCodes()
#1 {main}
thrown in /home/inverter/public_html/xxx/shipworks3.php on line 740.


line 740

$codes = zen_get_orders_status();

below is just some more of the code not sure if needed

function Action_GetStatusCodes()
        {
                writeStartTag("StatusCodes");

                $codes = zen_get_orders_status();
                
			   // reset($codes);
               // while (list($key, $val) = each($codes))
				
			foreach($codes as $key => $value) {
					
                 
                        writeStartTag("StatusCode");
                        writeElement("Code", $val['id']);
                        writeElement("Name", $val['text']);
                        writeCloseTag("StatusCode");
                }

chad,
what happens if you replace as so:

// from
$codes = zen_get_orders_status();
//to
$codes = zen_get_orders_status_pulldown_array(); 

[chadlly2003]

chad,
what happens if you replace as so:

// from
$codes = zen_get_orders_status();
//to
$codes = zen_get_orders_status_pulldown_array(); 

this is the error what i made with the changes you suggested

06-Dec-2022 20:10:07 America/New_York] Request URI: /xxx/shipworks3.php, IP address: 66.176.65.97
--> PHP Fatal error: Uncaught Error: Call to undefined function Â##zen_get_orders_status_pulldown_array() in /home/inverter/public_html/xxx/shipworks3.php:740
Stack trace:
#0 /home/inverter/public_html/xxx/shipworks3.php(169): Action_GetStatusCodes()
#1 {main}
  thrown in /home/inverter/public_html/xxx/shipworks3.php on line 740.

[swguy]

Check your edit - it looks like a couple of stray characters snuck in.

[chadlly2003]

sw guy.

I tried your recommendations but it just gave me another error

[06-Dec-2022 20:24:00 America/New_York] Request URI: /power/shipworks3.php, IP address: 66.176.65.97
--> PHP Fatal error: Uncaught Error: Call to undefined function each() in /home/inverter/public_html/xxx/shipworks3.php:742
Stack trace:
#0 /home/inverter/public_html/xxx/shipworks3.php(169): Action_GetStatusCodes()
#1 {main}
  thrown in /home/inverter/public_html/xxx/shipworks3.php on line 742.

[chadlly2003]

[06-Dec-2022 20:28:04 America/New_York] Request URI: /xxx/shipworks3.php, IP address: 66.176.65.97
--> PHP Fatal error: Uncaught Error: Call to undefined function Â##zen_get_orders_status_pulldown_array() in /home/inverter/public_html/power/shipworks3.php:740
Stack trace:
#0 /home/inverter/public_html/xxx/shipworks3.php(169): Action_GetStatusCodes()
#1 {main}
thrown in /home/inverter/public_html/xxx/shipworks3.php on line 740.

[carlwhat]

sw guy.

I tried your recommendations but it just gave me another error

[06-Dec-2022 20:24:00 America/New_York] Request URI: /power/shipworks3.php, IP address: 66.176.65.97
--> PHP Fatal error: Uncaught Error: Call to undefined function each() in /home/inverter/public_html/xxx/shipworks3.php:742
Stack trace:
#0 /home/inverter/public_html/xxx/shipworks3.php(169): Action_GetStatusCodes()
#1 {main}
  thrown in /home/inverter/public_html/xxx/shipworks3.php on line 742.

@swguy is correct.

now shipworks3 needs to be updated.

each was deprecated in php 8.0.

the vendor needs to update the code to work with php8.x see:

https://www.php.net/manual/en/function.each

and you need to fix your editor!

best.

[swguy]

@carlwhat is correct - here's how to fix the `each` issue:

https://docs.zen-cart.com/user/upgra...ach-deprecated