Hello
IMHO $currentPage !=0 expression in admin/countries.php file (lines ##147, 165, 172, 176, 183, 187, 190, 195, 222) should be relaced to $currentPage !== '' (as in some another lines of the same file or probably even better - to !empty($currentPage))
Otherwise variable type conversion does not work correct (at least in PHP v 7.4.25 I am still using) - $currentPage can be empty or a one letter string, but definitely not an integer
Sorry, if I do understand something wrong or if this issue has already been in discussion (I tried to search, but Ihave not found anything). I'll be very thankful for any community opinion
Results 1 to 6 of 6
-
9 Mar 2023, 07:26 PM #1
New Zenner
- Join Date
- Apr 2011
- Location
- Espoo, Finland
- Posts
- 49
- Plugin Contributions
- 0
"$currentPage != 0" expression in admin/countries.php
-
9 Mar 2023, 08:03 PM #2
Administrator
- Join Date
- Feb 2006
- Location
- Tampa Bay, Florida
- Posts
- 9,690
- Plugin Contributions
- 123
Re: "$currentPage != 0" expression in admin/countries.php
Thanks for taking the time to report this. Investigating.
That Software Guy. My Store: Zen Cart Modifications
Available for hire - See my ad in Services
Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
Do you benefit from Zen Cart? Then please support the project.
-
9 Mar 2023, 08:09 PM #3
Administrator
- Join Date
- Feb 2006
- Location
- Tampa Bay, Florida
- Posts
- 9,690
- Plugin Contributions
- 123
Re: "$currentPage != 0" expression in admin/countries.php
This looks like it's fixed in Github - would you please grab the latest copy of admin/countries.php and retest? Thanks.
https://github.com/zencart/zencart/b.../countries.phpThat Software Guy. My Store: Zen Cart Modifications
Available for hire - See my ad in Services
Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
Do you benefit from Zen Cart? Then please support the project.
-
9 Mar 2023, 09:02 PM #4
New Zenner
- Join Date
- Apr 2011
- Location
- Espoo, Finland
- Posts
- 49
- Plugin Contributions
- 0
Re: "$currentPage != 0" expression in admin/countries.php
Copy grabbed from Github seems working faultlessly.
Thank you for support and sorry for fuss
-
9 Mar 2023, 09:13 PM #5
Administrator
- Join Date
- Sep 2009
- Location
- Stuart, FL
- Posts
- 12,486
- Plugin Contributions
- 88
Re: "$currentPage != 0" expression in admin/countries.php
Better to have a duplicate report than have the issue remain!
Originally Posted by yesaul
-
9 Mar 2023, 09:25 PM #6
Administrator
- Join Date
- Feb 2006
- Location
- Tampa Bay, Florida
- Posts
- 9,690
- Plugin Contributions
- 123
Re: "$currentPage != 0" expression in admin/countries.php
It's also fun to see people adopting 1.5.8 (even if they hit a few speed bumps along the way). Good luck with your store.
That Software Guy. My Store: Zen Cart Modifications
Available for hire - See my ad in Services
Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
Do you benefit from Zen Cart? Then please support the project.
Reply With Quote
Similar Threads
-
v151 i got an error message "PHP Fatal error: 1055:Expression #1......"
By sungmo in forum General QuestionsReplies: 6Last Post: 19 Aug 2019, 04:32 PM -
PHP Warning "failed to open stream" on admin/index.php
By tundrasnake in forum Installing on a Windows ServerReplies: 4Last Post: 19 May 2009, 02:29 AM -
"Orders" Page in Admin - change "Delivered" to "Shipped"?
By ktessitore in forum Managing Customers and OrdersReplies: 3Last Post: 21 Feb 2009, 06:25 AM
Bookmarks