PHP Warning: Undefined variable

[carlwhat]

when i look at the code, just above the code that you have there, i see:

$meta_products_price = ''; 

do you not have that in your code?

see:

https://github.com/zencart/zencart/b....php#L264-L270

perhaps that line is not in the v158a fileset that you are using?

see this merged PR:

https://github.com/zencart/zencart/p...c06b299b40b7d2

it seems it was corrected almost 2 months ago.

best.

[strelitzia]

Hmm, I'll check the 1.5.8a download I have

[strelitzia]

when i look at the code, just above the code that you have there, i see:

$meta_products_price = ''; 

do you not have that in your code?

see:

https://github.com/zencart/zencart/b....php#L264-L270

perhaps that line is not in the v158a fileset that you are using?

see this merged PR:

https://github.com/zencart/zencart/p...c06b299b40b7d2

it seems it was corrected almost 2 months ago.

best.

Nope, even a fresh download from the link on the ZC page NOW doesn't have those updates. If it was fixed 2 months ago I would have expected the downloadable package to have been updated.

[swguy]

My head is spinning reviewing this.

Was this change made subsequent to the release of 1.5.8a?

[swguy]

BTW, this:

> On the test site, users are required to login to see pricing.

Is a pretty important detail.

[swguy]

> If it was fixed 2 months ago I would have expected the downloadable package to have been updated.

That's not how it works.

The downloadable package is updated when a release is done. Releases are only done when a critical mass of bug fixes warrants it. And a new release would not re-use the name 1.5.8a - it would be called 1.5.8b or something else.

You can check the deltas between Github and the last release any time to see what has been fixed since the last release.

[carlwhat]

Nope, even a fresh download from the link on the ZC page NOW doesn't have those updates. If it was fixed 2 months ago I would have expected the downloadable package to have been updated.

the 158a fileset does not have the fix, see:

https://github.com/zencart/zencart/b.../meta_tags.php

with regards to the download, as swguy guy stated, it is not how it works.

if it was me, and i was a developer supporting ZC, i would learn the process and check to see if bugs have already been fixed on the github repo prior to posting here on the forum. and when i am testing, i always use the latest code up on the repo as opposed to the lettered releases...

but hey that's just me...

best.

[strelitzia]

> If it was fixed 2 months ago I would have expected the downloadable package to have been updated.

That's not how it works.

The downloadable package is updated when a release is done. Releases are only done when a critical mass of bug fixes warrants it. And a new release would not re-use the name 1.5.8a - it would be called 1.5.8b or something else.

You can check the deltas between Github and the last release any time to see what has been fixed since the last release.

Hi Scott,

I'm aware of the naming convention for updates to Zen Cart. ��
Whilst I can understand why you don't update the downloadable each time a bug fix is committed, it doesn't help those that are casual or first time users of Zen Cart. They can't be expected to go digging around in GitHub repos to see if any bugs have been reported and fixed.
I guess this is one the reasons why WooCommerce is such a popular eCommerce platform because bug fixes are rolled out automatically without the need for poking around GitHub to see what needs to be updated in freshly downloaded software.
Zen Cart really needs to become more user friendly to "non developers" if it wants to try and increase its market share.

[swguy]

> WooCommerce is such a popular eCommerce platform because bug fixes are rolled out automatically ...

Again, this is not how it works.

WooCommerce does do more frequent releases than Zen Cart does. Much more frequent.
But they don't release automatically; every release involves human decision making.

We could do more frequent releases too, but some storeowners complain if the release cadence is too frequent.

The approach we've taken is to release when a critical mass of bug fixes warrants it. It's a balance.

The team has worked hard over the past few releases to simplify, automate and document the release process, so that moving forward, more frequent releases could be a possibility. But we certainly wouldn't do a release just because there was a debug log created in an infrequently used configuration one one specific page.

[torvista]

They can't be expected to go digging around in GitHub repos to see if any bugs have been reported and fixed

Well, unfortunately that is the nature of the beast. There cannot be a release for every minor change.

ZC is a DIY solution, so yes it is beneficial to take an interest in what is going on in the development branch, precisely to catch these incremental fixes.

Everyone should subscribe to the notifications from the repository, if only to take an active interest in the development.
It is easy to use a Github client (I use Gitkraken, Windows) to see exactly what has been being added and why.

I incorporate all the changes pretty soon after they are merged, after testing of course...ideally users could be more active and do testing before they are merged.
Seeing the incremental changes helps to learn how things work.

It also becomes a constant "upgrade" process but it's one I do when convenient: it is not forced on me in a panic when hosting changes php with no warning and the debug logs pile up.

Zen Cart (nor any software of the ilk) cannot be fit and forget, since php versions and browser behaviours are moving targets, becoming ever stricter and continually forcing code tightening.