Page 3 of 3 FirstFirst 123
Results 21 to 23 of 23
  1. #21
    Join Date
    Jun 2008
    Location
    Japan
    Posts
    123
    Plugin Contributions
    5

    Default Re: Discount coupon value

    I did more testings and found few small bugs. I went through all ot modules and three of them are modified.
    Discount coupons had a lot to do. For any reason, the tax re-calculation modes were kind of reversed. I had some doubt at the beginning, but other modules code (GV and group discount) confirmed that.
    Other discount modules, GV and Group Pricing needed few corrections too but lighter than coupons module.
    I am ready to make new PRs (lost penny and coupon), it might be easier for others to review or modify. Although now that V2.0.0 is released, I am not sure anybody will still have some energy left...
    Last edited by pilou2; 10 Apr 2024 at 07:39 PM.

  2. #22
    Join Date
    Feb 2006
    Location
    Tampa Bay, Florida
    Posts
    9,715
    Plugin Contributions
    123

    Default Re: Discount coupon value

    Quote Originally Posted by pilou2 View Post
    Although now that V2.0.0 is released, I am not sure anybody will still have some energy left...
    Please proceed! There's always another release around the corner. We appreciate the hard work you have put into fixing this problem.
    That Software Guy. My Store: Zen Cart Support
    Available for hire - See my ad in Services
    Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
    Do you benefit from Zen Cart? Then please support the project.

  3. #23
    Join Date
    Jan 2004
    Posts
    66,374
    Blog Entries
    7
    Plugin Contributions
    274

    Default Re: Discount coupon value

    Quote Originally Posted by pilou2 View Post
    Here are the results:
    Attachment 20530Attachment 20531
    I acknowledge that you've made many updates to proposed coding changes since posting these screenshots, so I'm posting to ask whether the latest code still works as shown in these images?
    ... because in the US (tax-included-pricing is 'false'), if a person redeems a coupon worth $8.00, they'll want to see that coupon being worth $8.00 not $7.28 in the subtotals.
    .

    Zen Cart - putting the dream of business ownership within reach of anyone!
    Donate to: DrByte directly or to the Zen Cart team as a whole

    Remember: Any code suggestions you see here are merely suggestions. You assume full responsibility for your use of any such suggestions, including any impact ANY alterations you make to your site may have on your PCI compliance.
    Furthermore, any advice you see here about PCI matters is merely an opinion, and should not be relied upon as "official". Official PCI information should be obtained from the PCI Security Council directly or from one of their authorized Assessors.

 

 
Page 3 of 3 FirstFirst 123

Similar Threads

  1. v155 Discount Coupon - Minimum Order Value Excluding Tax
    By allmart in forum Discounts/Coupons, Gift Certificates, Newsletters, Ads
    Replies: 12
    Last Post: 20 Jul 2020, 06:38 PM
  2. Replies: 6
    Last Post: 19 Jun 2011, 07:06 AM
  3. Replies: 18
    Last Post: 12 Mar 2010, 06:37 PM
  4. Ideas/Suggestions for Discount Coupon - How to give a credit and a discount
    By vegascoug in forum Discounts/Coupons, Gift Certificates, Newsletters, Ads
    Replies: 0
    Last Post: 15 Nov 2007, 05:40 PM
  5. Coupon welcome message showing discount when coupon is expired
    By tracyselena in forum Discounts/Coupons, Gift Certificates, Newsletters, Ads
    Replies: 4
    Last Post: 26 Jan 2007, 06:32 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR