CKEditor 4.14

[barco57]

is this in reference to the white text headers on the tables in some product descriptions? if it is, then cell properties. CKeditor 5 is a major upgrade of the editor and it is going to break some stuff.

[Bruce1952]

is this in reference to the white text headers on the tables in some product descriptions? if it is, then cell properties. CKeditor 5 is a major upgrade of the editor and it is going to break some stuff.

Yes it is the description shown in the top of the table and I have thousands of them.

1. In the old listings they show in white lettering.

2. If I do any adjustment at all and I don't change any of the lettering which I can see in the listing and press update then the lettering changes to black.

3. It also changes the borders so they can't be seen.

To me that is a major fault in the software even if it is a major upgrade. Whoever did it just did a quick fix is my thoughts but then again I am not a coding expert.

The coding in the software should not change any previous format I would have thought.

[barco57]

CKeditor- is third party software.
Your choices are to deal with the changes ckeditor 5 bring to the table, switch back to ckeditor 4 and close the red popup when it shows up, or turn the editor off and learn how to hand code your html for description. The only reason a popup was added to the CDN version of ckeditor 4 was because the ckeditor team is tired of supporting it when they have moved on with new architecture with ckeditor5 a while ago. For people that really, really want to stay on ckeditor4 you can pay to get continued support and updates with a licensing key.

[Bruce1952]

CKeditor- is third party software.
Your choices are to deal with the changes ckeditor 5 bring to the table, switch back to ckeditor 4 and close the red popup when it shows up, or turn the editor off and learn how to hand code your html for description. The only reason a popup was added to the CDN version of ckeditor 4 was because the ckeditor team is tired of supporting it when they have moved on with new architecture with ckeditor5 a while ago. For people that really, really want to stay on ckeditor4 you can pay to get continued support and updates with a licensing key.

One more question and that is:

In the future when using the software for new uploads I should not have any issues like I am having after the update?

[dbltoe]

We're having a major problem in that the link options do not include the box with target options.

The only presented option is open in new tab.

It's essential that several of our customers have the new window and popup options as well.

The new admin/includes/ckeditor.php presents link options at line 190:

        link: {            defaultProtocol: 'https://',
            allowedProtocols: [ 'https?', 'tel', 'sms', 'mailto'],
            decorators: {
                openInNewTab: {
                    mode: 'manual',
                    label: 'Open in a new tab',
                    attributes: {
                        target: '_blank',
                        rel: 'noopener noreferrer'
                    }
                }
            }
        },

Is it possible to modify this code to get the other options back that were in 4.14?

[dbltoe]

The old CKeditor used the onclick function to control the popup.

onclick="window.open(this.href, '', 'resizable=no,status=no,location=no,toolbar=no,menubar=no,fullscreen=no,scrollbars=no,dependent=no,width=420,height=420'); return false;"

Having to find the products that utilized the popup and adding the OnClick to just a few of 2,700 products is not a process I'm willing to fall back on.

[swguy]

See post #23 from @barco.
https://www.zen-cart.com/showthread....77#post1402377

[barco57]

Maybe try reading the docs https://ckeditor.com/docs/ckeditor5/...ures/link.html
I don't see a way to do what you want, unless maybe add more decorators, but then you have to dig through the api to figure out what decorators are available.... I already gave up on the tables stuff

[dbltoe]

You know me and the "dog with a bone" syndrome. I've been poking at this beast from every angle.

The doccs for links in 5 make mention of manual decorators but only open in a new tab is even mentioned. They seem to think automatic is the way to go and, even then, they present only one option and it doesn't make much sense either.

Going from seven target options to only open in a new tab is rediculous! I can't think of a better way for a user to miss the info you're trying to present. New window (_blank) would at least put the info in the customer's face. I have found no reference as to the extra options being available in ANY version 5 setup.

Have you looked at the suggested 4.24.0? I am going to look at it.

As a workaround, we will probably use the site specific to create several OnClick scenarios used on a site and add them to links needing them when creating/editing products, categories, etc.

[barco57]

4.24.0 is the same functionally as previous version, the only changes are for security (basically a bunch of cross-site scripting fixes)