VAT-mod for European companies

[cdaugustin]

Hi,

Here are my zones definitions:
name: EU -- contains all countries in Eu except UK
United Kingdom contains only UK
Tax classes: EU tax

Tax rates: i have two of them: one for the EU zone, one for the United Kingdom zone. Both are under the EU tax class. The EU one has priority 3 the uk one has priority 1. First is 5% second is 10%.

If i have My Store: Display prices with TAX true --> prices will appear with their tax on the catalog. They will apear with the right tax value on the shopping cart and on the step 1 of the checkout. But the moment i get to step 2 the values go back to their untaxed values. (on step 3 Tax: 0 ).

Now the user im testing this with has both its shipping and billing address to Germany (which is under EU zone)

Also on the registration process and on my details on a user account the VAT field doesnt appear anywhere. Strangely it appears on the admin module when i edit a user.

Thanks for your patiance.

[callumgilhooly]

Hi,

I've just installed this mod (great work by the way) and it almost works perfectly.

What's happening is:

When a user registers and puts their VAT number in the registration field, the registration appears to work fine but when that user goes to checkout, the vat appears. However, when I look at that users details in admin, the VAT number box is empty. As soon as I put the vat number in through admin, it works fine for the user and the vat is removed.

Why wouldn't the VAT number be captured during registration? I'm presuming I copied all the file across correctly as apart from this it works fine.

Any ideas?

Thanks

Callum

[cdaugustin]

Hi,
I have found the problem it seems you have a bug in the zen_tva_geo_tax() function in the /includes/classes/order.php file

here is the original function:

function zen_tva_geo_tax($tax_country_id, $billing_company, $billing_tva_intracom){
$tax_geo_zone_id = $this->zen_get_country_geo_zone_id($tax_country_id);
if($tax_country_id == STORE_COUNTRY ) return true; // store
if($tax_geo_zone_id == 0) return true; // no geo-zone
if($tax_geo_zone_id != 0 && !$billing_tva_intracom) return true; // geo-zone & no vat
elseif(!$billing_company && !$billing_tva_intracom) return false; // no vat
else return false;
}


Now i have observed that the function does not treat the case where there is actually a vat and a geo zone here is how i modified it and everything works perfect:

function zen_tva_geo_tax($tax_country_id, $billing_company, $billing_tva_intracom){
$tax_geo_zone_id = $this->zen_get_country_geo_zone_id($tax_country_id);
if($tax_country_id == STORE_COUNTRY ) return true; // store

/* geo-zone & vat --added by augustin */
if($tax_geo_zone_id != 0 && $billing_tva_intracom) return true;
/* end added by augustin*/

if($tax_geo_zone_id == 0) return true; // no geo-zone
if($tax_geo_zone_id != 0 && !$billing_tva_intracom) return true; // geo-zone & no vat
elseif(!$billing_company && !$billing_tva_intracom) return false; // no vat
else return false;
}


everything works just fine

[vike]

hi callum.
i cant seem to be able to reproduce your bug and without being able to see your code i dont think im no good on making any qualified guesses.. but as i think of it i come up with one step of debuging. =]

but first, could you be a little more specific about where in the checkout:

the vat apears

anyway the file containing the mentioned error would be:

catalog/includes/modules/create_account.php

other files in the user-interface performing about the same is:

catalog/includes/modules/checkout_new_address.php and
catalog/includes/modules/pages/address_book_process/header_php.php

you should make sure also this code doesnt work in your current install by processing a vat-number (other than the one entered to be able to check the result) through the adressbook and adding a vat-number to a new adress through checkout.

but if that also doesnt work i can only ask, just be sure, about you using the 130 version of zencart? and if probably so the only idea i get is to try installing a zencart 130 distribution and then just simply replacing the installation files with the files from the modification and check if that works. if so you can somehow compare the installations and work from there.. =]

good luck!
vike

[vike]

hi augustin (and anyone interested)
good you found the place and could change it to suite you.

i have though now rewritten that function to get it more optimized. it needs testing and some consultation with beez before it can be put in a new release of the mod, but hopefully its doing the same as before. =] ive chosen not to hard-implement your request quite there, as im thinking it may not be a common reqest of execution.
accordingly, the new code will (perhaps) take no consideration of zone-definitions by default, but will possibly do through un-commenting some lines of code, or perhaps configure via the admin-interface.

more work also needs to be done to the work ive sat with all night - much of that late nights around this mod btw

beez is on semester for the week, and perhaps also that is why id gladly get some feedback on my resent changes/additions to the mod:

i have made use of a yet internal configuration-constant to choose whether, an unknown tax rate of 0% should be used for customers from countries not in any zone-definition (as zencart default behavior), or if it else should fall back on the products tax-configuration.

i cant really understand that default behavior to suddenly skip tax totaly if an undefined country buys a product. but then im no zencart administrator as beez, who said to me it could be good of use as an indication of missconfiguration.. but then whats the purpose of product tax at all, as it will allways be overridden by tax-rate-configuration if thats done correct? ..any one explaning that to me will get a free copy of our next release! ;D

but thatd be all of zen fer tonite. peace in the mornin lite!
vike

[callumgilhooly]

Thanks Vike,

From the address book area, the adding of the VAT number worked so I have replaced the create_account pages and it appears to work fine now. Thanks for pointing me in the right direction (PHP/Zen novice here!)

Thanks again

Callum

[pivey]

Hello Beez,

I checked the VAT verification for Greece again...It does not work!
Works for all countries well.
Could you try it yourself? EL999943280 a valid TAX Number

I use your latest version.....

Cheers
Dimi

[Beez]

It seems like the validating server is down for Greece... http://ec.europa.eu/taxation_customs...&VAT=999943280 As it seems to work for other countries...

Try again later and if it still doesn't work, let me know!

[aspudden]

Nice Work !!
Will test soon ..

ASp

[PeterBKK]

Anyone who have tested this VAT-mod together with Super-Order????