Thread: Ask A Question

Page 33 of 40 FirstFirst ... 233132333435 ... LastLast
Results 321 to 330 of 399
  1. #321
    Join Date
    Jul 2012
    Posts
    16,734
    Plugin Contributions
    17

    Default Re: Ask A Question

    Just uploaded an updated version (2.1) to incorporate that direction in the README.txt file. When it has been fully reviewed/accepted it will be available from here.
    ZC Installation/Maintenance Support <- Site
    Contribution for contributions welcome...

  2. #322
    Join Date
    Jul 2012
    Posts
    16,734
    Plugin Contributions
    17

    Default Re: Ask A Question

    Quote Originally Posted by mc12345678 View Post
    Just uploaded an updated version (2.1) to incorporate that direction in the README.txt file. When it has been fully reviewed/accepted it will be available from here.
    Version 2.1 is now available from here.

    Again, only the instruction was updated/modified to explain to attempt to access the page using 'SSL', the code associated with the plugin's operation was not modified.
    ZC Installation/Maintenance Support <- Site
    Contribution for contributions welcome...

  3. #323
    Join Date
    Jul 2012
    Posts
    16,734
    Plugin Contributions
    17

    Default Re: Ask A Question

    FYI, re-reviewed the code a little. While the modification of the calling code to request that the page be loaded using the SSL is a definite help/good start, I found that in the header code, if the site had ENABLE_SSL set to true and the page was not requested to be served using the SSL, then it would redirect to the contact_us page... This code is an issue beginning at line 121 of: includes/modules/pages/ask_a_question/header_php.php

    The line was:
    Code:
    if (ENABLE_SSL == 'true' && $request_type != 'SSL') {
      zen_redirect(zen_href_link(FILENAME_CONTACT_US, '', 'SSL'));
    }
    and should be changed to:
    Code:
    if (ENABLE_SSL == 'true' && $request_type != 'SSL') {
      zen_redirect(zen_href_link(FILENAME_ASK_A_QUESTION, zen_get_all_get_params(), 'SSL'));
    }
    As will be seen in Version 2.2 of this plugin that has just been uploaded and will be available from here once it has been reviewed and posted.
    ZC Installation/Maintenance Support <- Site
    Contribution for contributions welcome...

  4. #324
    Join Date
    Jul 2012
    Posts
    16,734
    Plugin Contributions
    17

    Default Re: Ask A Question

    Quote Originally Posted by mc12345678 View Post
    FYI, re-reviewed the code a little. While the modification of the calling code to request that the page be loaded using the SSL is a definite help/good start, I found that in the header code, if the site had ENABLE_SSL set to true and the page was not requested to be served using the SSL, then it would redirect to the contact_us page... This code is an issue beginning at line 121 of: includes/modules/pages/ask_a_question/header_php.php

    The line was:
    Code:
    if (ENABLE_SSL == 'true' && $request_type != 'SSL') {
      zen_redirect(zen_href_link(FILENAME_CONTACT_US, '', 'SSL'));
    }
    and should be changed to:
    Code:
    if (ENABLE_SSL == 'true' && $request_type != 'SSL') {
      zen_redirect(zen_href_link(FILENAME_ASK_A_QUESTION, zen_get_all_get_params(), 'SSL'));
    }
    As will be seen in Version 2.2 of this plugin that has just been uploaded and will be available from here once it has been reviewed and posted.
    Version 2.2 of the plugin is available from here.
    ZC Installation/Maintenance Support <- Site
    Contribution for contributions welcome...

  5. #325
    Join Date
    Dec 2010
    Location
    UK
    Posts
    1,771
    Plugin Contributions
    3

    Default Re: Ask A Question

    1.5.5d
    latest version of Ask a Q.
    getting error log:
    PHP Code:
    Request URI: /, IP address: *******
    #1 header() called at [/home/***/public_html/includes/templates/custom/common/html_header.php:17]
    #2 require(/home/***/public_html/includes/templates/custom/common/html_header.php) called at [/home/***/public_html/index.php:43]

     
    PHP WarningCannot modify header information headers already sent by (output started at /home/***/public_html/includes/languages/english/extra_definitions/digi/ask_a_question_defines.php:15in /home/***/public_html/includes/templates/custom/common/html_header.php on line 17 
    TIA

  6. #326
    Join Date
    Jul 2012
    Posts
    16,734
    Plugin Contributions
    17

    Default Re: Ask A Question

    Quote Originally Posted by picandnix View Post
    1.5.5d
    latest version of Ask a Q.
    getting error log:
    PHP Code:
    Request URI: /, IP address: *******
    #1 header() called at [/home/***/public_html/includes/templates/custom/common/html_header.php:17]
    #2 require(/home/***/public_html/includes/templates/custom/common/html_header.php) called at [/home/***/public_html/index.php:43]

     
    PHP WarningCannot modify header information headers already sent by (output started at /home/***/public_html/includes/languages/english/extra_definitions/digi/ask_a_question_defines.php:15in /home/***/public_html/includes/templates/custom/common/html_header.php on line 17 
    TIA
    Cleanest resolution appears to be to remove the closing PHP tag ( ?> ) at the end of includes/languages/english/extra_definitions/ask_a_question_defines.php. This will also then "remove" the additional line entry that appears after that. The "additional" line can remain, it is just that it currently appears after the closing PHP tag.

    Thanks for pointing out that issue. If it doesn't prevent the warning from occurring, it still doesn't hurt to remove it as described.

    Warning: Headers already sent...
    ZC Installation/Maintenance Support <- Site
    Contribution for contributions welcome...

  7. #327
    Join Date
    Dec 2010
    Location
    UK
    Posts
    1,771
    Plugin Contributions
    3

    Default Re: Ask A Question

    Quote Originally Posted by mc12345678 View Post
    Cleanest resolution appears to be to remove the closing PHP tag ( ?> ) at the end of includes/languages/english/extra_definitions/ask_a_question_defines.php. This will also then "remove" the additional line entry that appears after that. The "additional" line can remain, it is just that it currently appears after the closing PHP tag.

    Thanks for pointing out that issue. If it doesn't prevent the warning from occurring, it still doesn't hurt to remove it as described.

    Warning: Headers already sent...
    So far so good

  8. #328
    Join Date
    Feb 2006
    Location
    Tampa Bay, Florida
    Posts
    9,696
    Plugin Contributions
    123

    Default Re: Ask A Question

    @picandnix This issue does not occur in a fresh download; you accidentally added a line after the closing ?> in the file
    includes/languages/english/extra_definitions/custom/ask_a_question_defines.php

    Zen Cart core has stopped putting a final ?> at the end of files for this very reason - it's such an easy accidental mistake to make.
    That Software Guy. My Store: Zen Cart Modifications
    Available for hire - See my ad in Services
    Plugin Moderator, Documentation Curator, Chief Cook and Bottle-Washer.
    Do you benefit from Zen Cart? Then please support the project.

  9. #329
    Join Date
    Dec 2010
    Location
    UK
    Posts
    1,771
    Plugin Contributions
    3

    Default Re: Ask A Question

    Quote Originally Posted by swguy View Post
    @picandnix This issue does not occur in a fresh download; you accidentally added a line after the closing ?> in the file
    includes/languages/english/extra_definitions/custom/ask_a_question_defines.php

    Zen Cart core has stopped putting a final ?> at the end of files for this very reason - it's such an easy accidental mistake to make.
    Thank you both

  10. #330
    Join Date
    Feb 2010
    Location
    Minnesota
    Posts
    387
    Plugin Contributions
    0

    Default Re: Ask A Question

    I have added this plugin and do not get the option of asking a question on product pages. This is a very simple plugin to add but where did I go wrong.
    I am using zencart version 155e with a template of westminster_new.

    Any ideas?

    Thanks in advance

 

 
Page 33 of 40 FirstFirst ... 233132333435 ... LastLast

Similar Threads

  1. Ask A Question module
    By okibi in forum All Other Contributions/Addons
    Replies: 1
    Last Post: 18 Apr 2007, 01:55 PM
  2. Ask a question 1.7
    By Kodam in forum All Other Contributions/Addons
    Replies: 7
    Last Post: 4 Apr 2007, 11:16 PM

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
disjunctive-egg
Zen-Cart, Internet Selling Services, Klamath Falls, OR